* Re: [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates
@ 2014-01-21 6:51 99% ` justin
0 siblings, 0 replies; 1+ results
From: justin @ 2014-01-21 6:51 UTC (permalink / raw
To: gentoo-science
Cc: Denis Dupeyron (calchan), Ulrich Mueller (ulm), Sebastien Fabro
[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]
On 20/01/14 18:53, Reinis Danne wrote:
> Hi!
>
> I have cleaned up a bit alternatives-2.eclass to make it easier to review.
> Also if someone knows any shortcommings of this eclass as it is, then point
> it out, I'll try to address them.
>
> I hope this can be soon moved to the main tree thus closing the divide between
> science overlay and portage tree.
>
> Reinis Danne (10):
> alternatives-2.eclass: Update copyright
> alternatives-2.eclass: Remove unused variables
> alternatives-2.eclass: Move EXPORT_FUNCTIONS to top
> alternatives-2.eclass: Remove commented-out code
> alternatives-2.eclass: Put commonly used path in local variable
> alternatives-2.eclass: Fix eclass name in comments
> alternatives-2.eclass: Add EAPI check
> alternatives-2.eclass: Add documentation comments
> alternatives-2.eclass: Minor comment changes
> alternatives-2.eclass: Use consistent quoting
>
> eclass/alternatives-2.eclass | 110 +++++++++++++++++++++++++++++++------------
> 1 file changed, 79 insertions(+), 31 deletions(-)
>
Thanks for all your work.
Sebastien, Dennis, Ulrich and everybody else, let's gather a list of the
remaining issue to resolve.
Reinis, could you branch the sci overlay on github and and push your
changes there. Everybody, let's stick to clear commit msgs for the
eclass so that the review goes easy.
Justin
P.s. Sorry guys for CCing you directly. I am not sure if you are all
following the list.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-01-20 17:53 [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates Reinis Danne
2014-01-21 6:51 99% ` justin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox