From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E4B19138247 for ; Tue, 21 Jan 2014 19:26:47 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8887AE0F6C; Tue, 21 Jan 2014 19:26:46 +0000 (UTC) Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CFEF3E0F58 for ; Tue, 21 Jan 2014 19:26:45 +0000 (UTC) Received: by mail-ee0-f45.google.com with SMTP id b15so4147963eek.18 for ; Tue, 21 Jan 2014 11:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=uNbiBaIGl+86Rp8m8slz7Hz6Q4jJuuYBKXQjQKm5cmY=; b=jLnWkEl2UzIr0cbLTyA4T3CujYsuBMPaozbddLAiIxcvxLvxiow5bXnrw+GPT1p9e0 nC+GRhUg2a/VU3jD18Ge/zBw4esifkGd7GLBcmJDoSNLCWQyyhH/rzlet/GMnmEs6Z3B j4I4lXsBK5H7Foka8sxhnvnhKkwQMRLER8L5tSame+lm1U+zgRP7lMUMBoW8EakzNF7w 7DFIPecWSc/Jmc/eqQbNmTpFWY/Nqkz5g0Nlu1Fn5VCez7ZiRTrPdKsYknyHu0f+syfE SyOCCwBqIylvnxfnTfu5+haHpHMcc66tayO8s7+xr4mPMLl2urqTLIFfkudW5pXRIaFM ZAOA== X-Received: by 10.14.6.5 with SMTP id 5mr24953168eem.51.1390332404350; Tue, 21 Jan 2014 11:26:44 -0800 (PST) Received: from dhcppc1 (dsl-trebrasgw2-58c0d8-67.dhcp.inet.fi. [88.192.216.67]) by mx.google.com with ESMTPSA id m47sm18084771eey.7.2014.01.21.11.26.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jan 2014 11:26:43 -0800 (PST) Date: Tue, 21 Jan 2014 21:26:41 +0200 From: Reinis Danne To: gentoo-science@lists.gentoo.org Subject: Re: [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates Message-ID: <20140121192641.GB13149@dhcppc1> Mail-Followup-To: gentoo-science@lists.gentoo.org References: <1390240392-12173-1-git-send-email-rei4dan@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-science@lists.gentoo.org Reply-to: gentoo-science@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) X-Archives-Salt: 7bf8efca-bf5e-4f07-91a7-4d67d66d72a7 X-Archives-Hash: c3513a4947e8a1949fb1cb7d8d6bfe10 On Tue, Jan 21, 2014 at 09:04:56AM -0800, Sébastien Fabbro wrote: > On Mon, Jan 20, 2014 at 9:53 AM, Reinis Danne wrote: > > > > > I have cleaned up a bit alternatives-2.eclass to make it easier to review. > > Also if someone knows any shortcommings of this eclass as it is, then point > > it out, I'll try to address them. > > > > I hope this can be soon moved to the main tree thus closing the divide > > between > > science overlay and portage tree. > > > > > Your changes are mostly minor and only apply to the eclass, so I have no > comments. You should commit them to the overlay, code reviews on the github > review panel are more practical than on the mailing list. > One important thing the creation of eselect modules could be done directly > from eselect rather than the eclass, keeping the eclass much more simple, > and allowing users to create their own providers easily. I may work on it. > I had some local changes of eselect and I added the repo [1] to the github > gentoo-science, that you can test by unmasking eselect-9999. How the eselect module creation could work? Something like this? ~# eselect module create blas ~# eselect blas add atlas importance src dest [src dest [..]] ... ~# eselect blas remove atlas ~# eselect delete blas > > Known issues of the alternatives framework: > * when having more than 1 provider, updating a package that provided the > eselected provider, will not re-eselect the same provider unless it was the > first on the list Fixed by "alternatives-2.eclass: Fix check for uninstalling". > * possible residual orphan files Haven't observed any after my patch series applied. > * given the number of bugs, we should keep the linking to the reference > names libraries, so we could eselect providers without re-compiling all > reverse dependencies. We could do this in the open sourced providers by > changing the soname of the libraries we compile, and in the binary ones > (mkl,amcl...) with a link script generated library. Yes, this is ok and AFAICT it is like that now in the overlay. > > > [1] https://github.com/gentoo-science/eselect > > Sebastien