public inbox for gentoo-science@lists.gentoo.org
 help / color / mirror / Atom feed
From: Reinis Danne <rei4dan@gmail.com>
To: gentoo-science@lists.gentoo.org
Subject: Re: [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates
Date: Tue, 21 Jan 2014 21:26:41 +0200	[thread overview]
Message-ID: <20140121192641.GB13149@dhcppc1> (raw)
In-Reply-To: <CAA-OU2qgiadwBAEduFBDS7zSCsLZDcYoZgYTt5fZ-YXOhhASww@mail.gmail.com>

On Tue, Jan 21, 2014 at 09:04:56AM -0800, Sébastien Fabbro wrote:
> On Mon, Jan 20, 2014 at 9:53 AM, Reinis Danne <rei4dan@gmail.com> wrote:
> 
> >
> > I have cleaned up a bit alternatives-2.eclass to make it easier to review.
> > Also if someone knows any shortcommings of this eclass as it is, then point
> > it out, I'll try to address them.
> >
> > I hope this can be soon moved to the main tree thus closing the divide
> > between
> > science overlay and portage tree.
> >
> 
> 
> Your changes are mostly minor and only apply to the eclass, so I have no
> comments. You should commit them to the overlay, code reviews on the github
> review panel are more practical than on the mailing list.
> One important thing the creation of eselect modules could be done directly
> from eselect rather than the eclass, keeping the eclass much more simple,
> and allowing users to create their own providers easily. I may work on it.
> I had some local changes of eselect and I added the repo [1] to the github
> gentoo-science, that you can test by unmasking eselect-9999.

How the eselect module creation could work? Something like this?

~# eselect module create blas
~# eselect blas add atlas importance src dest [src dest [..]]
...
~# eselect blas remove atlas
~# eselect delete blas

> 
> Known issues of the alternatives framework:
> * when having more than 1 provider, updating a  package that provided the
> eselected provider, will not re-eselect the same provider unless it was the
> first on the list

Fixed by "alternatives-2.eclass: Fix check for uninstalling".

> * possible residual orphan files

Haven't observed any after my patch series applied.

> * given the number of bugs, we should keep the linking to the reference
> names libraries, so we could eselect providers without re-compiling all
> reverse dependencies. We could do this in the open sourced providers by
> changing the soname of the libraries we compile, and in the binary ones
> (mkl,amcl...) with a link script generated library.

Yes, this is ok and AFAICT it is like that now in the overlay.

> 
> 
> [1] https://github.com/gentoo-science/eselect
> 
> Sebastien


  reply	other threads:[~2014-01-21 19:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 17:53 [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 01/10] alternatives-2.eclass: Update copyright Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 02/10] alternatives-2.eclass: Remove unused variables Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 03/10] alternatives-2.eclass: Move EXPORT_FUNCTIONS to top Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 04/10] alternatives-2.eclass: Remove commented-out code Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 05/10] alternatives-2.eclass: Put commonly used path in local variable Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 06/10] alternatives-2.eclass: Fix eclass name in comments Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 07/10] alternatives-2.eclass: Add EAPI check Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 08/10] alternatives-2.eclass: Add documentation comments Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 09/10] alternatives-2.eclass: Minor comment changes Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 10/10] alternatives-2.eclass: Use consistent quoting Reinis Danne
2014-01-21  6:51 ` [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates justin
2014-01-21 18:32   ` Reinis Danne
2014-01-21 17:04 ` Sébastien Fabbro
2014-01-21 19:26   ` Reinis Danne [this message]
2014-01-21 20:04     ` Sébastien Fabbro
2014-01-21 20:35       ` François Bissey
2014-01-21 21:30       ` Reinis Danne
2014-01-21 22:46         ` Sébastien Fabbro
2014-01-22  7:13           ` justin
2014-01-21 21:21   ` justin
2014-01-21 21:26     ` François Bissey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140121192641.GB13149@dhcppc1 \
    --to=rei4dan@gmail.com \
    --cc=gentoo-science@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox