From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-science+bounces-1902-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
by finch.gentoo.org (Postfix) with ESMTP id CD040138247
for <garchives@archives.gentoo.org>; Tue, 21 Jan 2014 18:32:37 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 8014EE102E;
Tue, 21 Jan 2014 18:32:34 +0000 (UTC)
Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com [209.85.215.170])
(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id ADD52E0FCA
for <gentoo-science@lists.gentoo.org>; Tue, 21 Jan 2014 18:32:33 +0000 (UTC)
Received: by mail-ea0-f170.google.com with SMTP id k10so3971766eaj.1
for <gentoo-science@lists.gentoo.org>; Tue, 21 Jan 2014 10:32:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20120113;
h=date:from:to:subject:message-id:mail-followup-to:references
:mime-version:content-type:content-disposition:in-reply-to
:user-agent;
bh=phn4OU+M62+/bs4D9p6UfFibQ5z/TszmXVaWQ5V5/84=;
b=D8DL4sGXTy7hRTsirb+pwx/FK5zXaxaQjjc+HPzpb9V1RIjq3lRoGf7w7UEX8Wk084
GWchHsEd804zpsiO8v2A3EcuFlg3Q9ChgIc5JgMxt01MN6WAot9mLb5I9ICo1Xv1q55X
BoLNY6OFmprE8EXtWDTURM+TJptqh5KozsIBa5Upn70Qf2uT3P0OQcAaESK3BXRgrebB
Vf/E4iGToLLiu6oKI+59MYc0HVuFOCC6u5xma7cXjYkFujf7hH0EDFcKn6wTHFzpCwZQ
wFlkwzhgcc3TtX9yC1p+LCvim3s9KxPIhPpE9IqRGVrlDdg/DgcwQG07EBfeqS6K6ua/
o6qg==
X-Received: by 10.14.32.132 with SMTP id o4mr25393399eea.14.1390329152400;
Tue, 21 Jan 2014 10:32:32 -0800 (PST)
Received: from dhcppc1 (dsl-trebrasgw2-58c0d8-67.dhcp.inet.fi. [88.192.216.67])
by mx.google.com with ESMTPSA id n7sm17610075eef.5.2014.01.21.10.32.31
for <gentoo-science@lists.gentoo.org>
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Tue, 21 Jan 2014 10:32:31 -0800 (PST)
Date: Tue, 21 Jan 2014 20:32:29 +0200
From: Reinis Danne <rei4dan@gmail.com>
To: gentoo-science@lists.gentoo.org
Subject: Re: [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates
Message-ID: <20140121183229.GA13149@dhcppc1>
Mail-Followup-To: gentoo-science@lists.gentoo.org
References: <1390240392-12173-1-git-send-email-rei4dan@gmail.com>
<52DE18F6.9080906@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-science@lists.gentoo.org>
List-Help: <mailto:gentoo-science+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-science+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-science+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-science.gentoo.org>
X-BeenThere: gentoo-science@lists.gentoo.org
Reply-to: gentoo-science@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52DE18F6.9080906@gentoo.org>
User-Agent: Mutt/1.5.22 (2013-10-16)
X-Archives-Salt: 0bb9a9b1-eb53-4e1e-a4f6-136bc6527c46
X-Archives-Hash: e6ea6c09512b4d96a320ab9f6a71ca2e
On Tue, Jan 21, 2014 at 07:51:34AM +0100, justin wrote:
> On 20/01/14 18:53, Reinis Danne wrote:
> > Hi!
> >
> > I have cleaned up a bit alternatives-2.eclass to make it easier to review.
> > Also if someone knows any shortcommings of this eclass as it is, then point
> > it out, I'll try to address them.
> >
> > I hope this can be soon moved to the main tree thus closing the divide between
> > science overlay and portage tree.
> >
> > Reinis Danne (10):
> > alternatives-2.eclass: Update copyright
> > alternatives-2.eclass: Remove unused variables
> > alternatives-2.eclass: Move EXPORT_FUNCTIONS to top
> > alternatives-2.eclass: Remove commented-out code
> > alternatives-2.eclass: Put commonly used path in local variable
> > alternatives-2.eclass: Fix eclass name in comments
> > alternatives-2.eclass: Add EAPI check
> > alternatives-2.eclass: Add documentation comments
> > alternatives-2.eclass: Minor comment changes
> > alternatives-2.eclass: Use consistent quoting
> >
> > eclass/alternatives-2.eclass | 110 +++++++++++++++++++++++++++++++------------
> > 1 file changed, 79 insertions(+), 31 deletions(-)
> >
>
> Thanks for all your work.
>
> Sebastien, Dennis, Ulrich and everybody else, let's gather a list of the
> remaining issue to resolve.
>
>
> Reinis, could you branch the sci overlay on github and and push your
> changes there. Everybody, let's stick to clear commit msgs for the
> eclass so that the review goes easy.
They are in alternatives-2 branch on
https://github.com/Reinis/sci
Added also:
alternatives-2.eclass: Fix einfo message in pkg_postinst
alternatives-2.eclass: Fix check for uninstalling
alternatives-2.eclass: Don't source eselect modules
With that it keeps provider selected if it is reinstalled/updated
and avoids recreating the eselect module every single time.
Reinis