From: Reinis Danne <rei4dan@gmail.com>
To: gentoo-science@lists.gentoo.org
Subject: Re: [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates
Date: Tue, 21 Jan 2014 20:32:29 +0200 [thread overview]
Message-ID: <20140121183229.GA13149@dhcppc1> (raw)
In-Reply-To: <52DE18F6.9080906@gentoo.org>
On Tue, Jan 21, 2014 at 07:51:34AM +0100, justin wrote:
> On 20/01/14 18:53, Reinis Danne wrote:
> > Hi!
> >
> > I have cleaned up a bit alternatives-2.eclass to make it easier to review.
> > Also if someone knows any shortcommings of this eclass as it is, then point
> > it out, I'll try to address them.
> >
> > I hope this can be soon moved to the main tree thus closing the divide between
> > science overlay and portage tree.
> >
> > Reinis Danne (10):
> > alternatives-2.eclass: Update copyright
> > alternatives-2.eclass: Remove unused variables
> > alternatives-2.eclass: Move EXPORT_FUNCTIONS to top
> > alternatives-2.eclass: Remove commented-out code
> > alternatives-2.eclass: Put commonly used path in local variable
> > alternatives-2.eclass: Fix eclass name in comments
> > alternatives-2.eclass: Add EAPI check
> > alternatives-2.eclass: Add documentation comments
> > alternatives-2.eclass: Minor comment changes
> > alternatives-2.eclass: Use consistent quoting
> >
> > eclass/alternatives-2.eclass | 110 +++++++++++++++++++++++++++++++------------
> > 1 file changed, 79 insertions(+), 31 deletions(-)
> >
>
> Thanks for all your work.
>
> Sebastien, Dennis, Ulrich and everybody else, let's gather a list of the
> remaining issue to resolve.
>
>
> Reinis, could you branch the sci overlay on github and and push your
> changes there. Everybody, let's stick to clear commit msgs for the
> eclass so that the review goes easy.
They are in alternatives-2 branch on
https://github.com/Reinis/sci
Added also:
alternatives-2.eclass: Fix einfo message in pkg_postinst
alternatives-2.eclass: Fix check for uninstalling
alternatives-2.eclass: Don't source eselect modules
With that it keeps provider selected if it is reinstalled/updated
and avoids recreating the eselect module every single time.
Reinis
next prev parent reply other threads:[~2014-01-21 18:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 17:53 [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 01/10] alternatives-2.eclass: Update copyright Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 02/10] alternatives-2.eclass: Remove unused variables Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 03/10] alternatives-2.eclass: Move EXPORT_FUNCTIONS to top Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 04/10] alternatives-2.eclass: Remove commented-out code Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 05/10] alternatives-2.eclass: Put commonly used path in local variable Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 06/10] alternatives-2.eclass: Fix eclass name in comments Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 07/10] alternatives-2.eclass: Add EAPI check Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 08/10] alternatives-2.eclass: Add documentation comments Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 09/10] alternatives-2.eclass: Minor comment changes Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 10/10] alternatives-2.eclass: Use consistent quoting Reinis Danne
2014-01-21 6:51 ` [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates justin
2014-01-21 18:32 ` Reinis Danne [this message]
2014-01-21 17:04 ` Sébastien Fabbro
2014-01-21 19:26 ` Reinis Danne
2014-01-21 20:04 ` Sébastien Fabbro
2014-01-21 20:35 ` François Bissey
2014-01-21 21:30 ` Reinis Danne
2014-01-21 22:46 ` Sébastien Fabbro
2014-01-22 7:13 ` justin
2014-01-21 21:21 ` justin
2014-01-21 21:26 ` François Bissey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121183229.GA13149@dhcppc1 \
--to=rei4dan@gmail.com \
--cc=gentoo-science@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox