From: Reinis Danne <rei4dan@gmail.com>
To: gentoo-science@lists.gentoo.org
Subject: [gentoo-science] [PATCH 04/10] alternatives-2.eclass: Remove commented-out code
Date: Mon, 20 Jan 2014 19:53:06 +0200 [thread overview]
Message-ID: <1390240392-12173-5-git-send-email-rei4dan@gmail.com> (raw)
In-Reply-To: <1390240392-12173-1-git-send-email-rei4dan@gmail.com>
---
eclass/alternatives-2.eclass | 5 -----
1 file changed, 5 deletions(-)
diff --git a/eclass/alternatives-2.eclass b/eclass/alternatives-2.eclass
index a431d26..98317dd 100644
--- a/eclass/alternatives-2.eclass
+++ b/eclass/alternatives-2.eclass
@@ -22,7 +22,6 @@ EXPORT_FUNCTIONS pkg_postinst pkg_prerm
# alternatives_for alternative provider importance source target [ source target [...]]
alternatives_for() {
- #echo alternatives_for "${@}"
(( $# >= 5 )) && (( ($#-3)%2 == 0)) || die "${FUNCNAME} requires exactly 3+N*2 arguments where N>=1"
local alternative=${1} provider=${2} importance=${3} index src target ret=0
@@ -115,7 +114,6 @@ alternatives-2_pkg_postinst() {
if [[ ! -f "${EROOT%/}/usr/share/eselect/modules/auto/${alt}.eselect" \
|| "$(source "${EROOT%/}/usr/share/eselect/modules/auto/${alt}.eselect" &>/dev/null; echo "${VERSION}")" \
-ne "${module_version}" ]]; then
- #einfo "Creating alternatives module for ${alt}"
if [[ ! -d ${EROOT%/}/usr/share/eselect/modules/auto ]]; then
install -d "${EROOT%/}"/usr/share/eselect/modules/auto || eerror "Could not create eselect modules dir"
fi
@@ -132,7 +130,6 @@ alternatives-2_pkg_postinst() {
EOF
fi
- #echo eselect "${alt}" update "${provider}"
einfo "Creating ${provider} alternative module for ${alt}"
eselect "${alt}" update "${provider}"
@@ -146,8 +143,6 @@ alternatives-2_pkg_prerm() {
for a in "${ALTERNATIVES_PROVIDED[@]}"; do
alt="${a%:*}"
provider="${a#*:}"
- #echo "Making sure ${alt} has a valid provider"
- #echo eselect "${alt}" update${ignore} "${provider}"
eselect "${alt}" update${ignore} "${provider}" && continue
einfo "Removed ${provider} alternative module for ${alt}, current is $(eselect ${alt} show)"
if [[ $? -eq 2 ]]; then
--
1.8.5.3
next prev parent reply other threads:[~2014-01-20 17:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 17:53 [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 01/10] alternatives-2.eclass: Update copyright Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 02/10] alternatives-2.eclass: Remove unused variables Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 03/10] alternatives-2.eclass: Move EXPORT_FUNCTIONS to top Reinis Danne
2014-01-20 17:53 ` Reinis Danne [this message]
2014-01-20 17:53 ` [gentoo-science] [PATCH 05/10] alternatives-2.eclass: Put commonly used path in local variable Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 06/10] alternatives-2.eclass: Fix eclass name in comments Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 07/10] alternatives-2.eclass: Add EAPI check Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 08/10] alternatives-2.eclass: Add documentation comments Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 09/10] alternatives-2.eclass: Minor comment changes Reinis Danne
2014-01-20 17:53 ` [gentoo-science] [PATCH 10/10] alternatives-2.eclass: Use consistent quoting Reinis Danne
2014-01-21 6:51 ` [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates justin
2014-01-21 18:32 ` Reinis Danne
2014-01-21 17:04 ` Sébastien Fabbro
2014-01-21 19:26 ` Reinis Danne
2014-01-21 20:04 ` Sébastien Fabbro
2014-01-21 20:35 ` François Bissey
2014-01-21 21:30 ` Reinis Danne
2014-01-21 22:46 ` Sébastien Fabbro
2014-01-22 7:13 ` justin
2014-01-21 21:21 ` justin
2014-01-21 21:26 ` François Bissey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390240392-12173-5-git-send-email-rei4dan@gmail.com \
--to=rei4dan@gmail.com \
--cc=gentoo-science@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox