From: "Jorge Manuel B. S. Vicetto" <jmbsvicetto@gentoo.org>
To: gentoo-releng@lists.gentoo.org
Cc: s390@gentoo.org
Subject: Re: [gentoo-releng] [PATCH] s390: mv flat package.keywords file to package.accept_keywords dir
Date: Tue, 13 Mar 2018 12:23:03 -0100 [thread overview]
Message-ID: <CADvE9N=piu3JpC=c2-LcfyFQBXUjO6mpO=dqBcTNqwRYVX9GEQ@mail.gmail.com> (raw)
In-Reply-To: <CANSUr=KnjJhMC9BhD-JOCWvw_fpxd0F2v-t91OHYNDgR4ieGJw@mail.gmail.com>
Hi Ben.
On Tue, Mar 13, 2018 at 12:08 PM, Ben Kohler <bkohler@gmail.com> wrote:
> Attached is a small mv-only patch to fix recent s390 netboot build
> failures. Please review.
>
> -Ben
There was only one potential issue I could see with that change, but
I've now confirmed it isn't a problem. We have hard coded the
directory names for doing the "cleaning", but we have both
package.accept_keywords and package.keywords in that list.
https://gitweb.gentoo.org/proj/catalyst.git/tree/catalyst/base/stagebase.py
line 1221
BTW, I just noticed the following typo in line 1220 "portage_preix":
log.debug("clean(), portage_preix = %s, no sticky-config",
self.settings["portage_prefix"])
Please grant S390 (vapier?) until the weekend to reply. If there's no
reply or if they agree, feel free to commit the change.
Thanks,
Jorge
next prev parent reply other threads:[~2018-03-13 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 13:08 [gentoo-releng] [PATCH] s390: mv flat package.keywords file to package.accept_keywords dir Ben Kohler
2018-03-13 13:14 ` [gentoo-releng] " Ben Kohler
2018-03-21 12:53 ` Ben Kohler
2018-03-13 13:23 ` Jorge Manuel B. S. Vicetto [this message]
2018-03-13 13:34 ` [gentoo-releng] " Ben Kohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADvE9N=piu3JpC=c2-LcfyFQBXUjO6mpO=dqBcTNqwRYVX9GEQ@mail.gmail.com' \
--to=jmbsvicetto@gentoo.org \
--cc=gentoo-releng@lists.gentoo.org \
--cc=s390@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox