From: Ben Kohler <bkohler@gentoo.org>
To: gentoo-releng@lists.gentoo.org
Subject: [gentoo-releng] [PATCH 2/2] catalyst-auto-x86*.conf: explicitly list files to be transferred
Date: Fri, 15 May 2020 08:07:19 -0500 [thread overview]
Message-ID: <20200515130719.3138513-2-bkohler@gentoo.org> (raw)
In-Reply-To: <20200515130719.3138513-1-bkohler@gentoo.org>
Previously when we were copying locally there was no (major) problem
with wildcarding a long list of files to be transferred after every
single spec finishes. Now that we are transferring to a remote host,
this results in a lot of wasted transfer time & bandwidth.
I have adjusted the post_build function to only transfer the new files
known to be produced by each spec (which has files meant to be
published).
Signed-off-by: Ben Kohler <bkohler@gentoo.org>
---
tools/catalyst-auto-x86-experimental.conf | 71 +++++++++++++----------
tools/catalyst-auto-x86.conf | 57 +++++++++---------
2 files changed, 67 insertions(+), 61 deletions(-)
diff --git a/tools/catalyst-auto-x86-experimental.conf b/tools/catalyst-auto-x86-experimental.conf
index 3fd60287..061cab92 100644
--- a/tools/catalyst-auto-x86-experimental.conf
+++ b/tools/catalyst-auto-x86-experimental.conf
@@ -30,17 +30,27 @@ EXTENSIONS="[.tar.xz,.tar.bz2,.tar.gz,.tar,.sfs]"
update_symlinks() {
# Symlink the latest stages3 to build from
for d in ${BUILD_SRCDIR_BASE}/{default,hardened} ; do
- pushd $d >/dev/null
+ pushd "${d}" >/dev/null || exit
for f in $(ls stage3*${EXTENSIONS} | grep -v latest | give_latest_from_dates ) ; do
- of=${f/20[0-9][0-9].[0-9]/latest} # for 20XX.Y stuff
- of=${of/20[0-9][0-9][0-1][0-9][0-9][0-9]/latest} # for 20YYMMDD stuff
- ln -sf $f $of
+ # 20yymmddThhmmssZ
+ # 20yymmddhhmmss
+ # 20yymmdd
+ # 20yy.n
+ of=$(perl -p \
+ -e 's/20\d{6}T\d{6}Z/latest/g;' \
+ -e 's/20\d{6}\d{6}/latest/g;' \
+ -e 's/20\d{6}/latest/g;' \
+ -e 's/20\d{2}\.\d{2}/latest/g;' \
+ <<<"$f")
+ ln -svf "$f" "$of"
done
- popd >/dev/null
+ popd >/dev/null || exit
done
}
post_build() {
+ local set=$1 spec=$2
+
cmd=(
rsync
-e 'ssh -i /root/.ssh/id_rsa -o UserKnownHostsFile=/dev/null -o VerifyHostKeyDNS=yes -o StrictHostKeyChecking=no'
@@ -59,34 +69,31 @@ post_build() {
DEST_HARDENED=${ARCH}@releng-incoming.gentoo.org:${BUILD_DESTDIR_BASE}/hardened
;;
esac
- pushd ${BUILD_SRCDIR_BASE}/default >/dev/null
- mkdir -p ${TMPDIR}/empty
- "${cmd[@]}" ${TMPDIR}/empty ${DEST_DEFAULT}
- for file in $(ls stage{3,4}*{${DATESTAMP},${TIMESTAMP}}*${EXTENSIONS} ); do
- if [ -f $file ]; then
- "${cmd[@]}" ${file}* ${DEST_DEFAULT}
- fi
- done
- if [ -f *${DATESTAMP}*.iso ]; then
- "${cmd[@]}" *${DATESTAMP}*.iso* ${DEST_DEFAULT}
- elif [ -f *${TIMESTAMP}*.iso ]; then
- "${cmd[@]}" *${TIMESTAMP}*.iso* ${DEST_DEFAULT}
- fi
- popd >/dev/null
- pushd ${BUILD_SRCDIR_BASE}/hardened >/dev/null
- "${cmd[@]}" ${TMPDIR}/empty ${DEST_HARDENED}
- for file in $(ls stage{3,4}*{${DATESTAMP},${TIMESTAMP}}*${EXTENSIONS} ); do
- if [ -f $file ]; then
- "${cmd[@]}" $file* ${DEST_HARDENED}
- fi
- done
- if [ -f *${DATESTAMP}*.iso ]; then
- "${cmd[@]}" *${DATESTAMP}*.iso* ${DEST_HARDENED}
- elif [ -f *${TIMESTAMP}*.iso ]; then
- "${cmd[@]}" *${TIMESTAMP}*.iso* ${DEST_HARDENED}
- fi
- popd >/dev/null
+ pushd "${BUILD_SRCDIR_BASE}"/default >/dev/null || exit
+ case ${spec} in
+ stage3.spec)
+ "${cmd[@]}" stage3-i486-${TIMESTAMP}.tar.xz* "${DEST_DEFAULT}"
+ ;;
+ installcd-stage2-minimal.spec)
+ "${cmd[@]}" install-x86-minimal-${TIMESTAMP}.iso* "${DEST_DEFAULT}"
+ ;;
+ i686/stage3.spec)
+ "${cmd[@]}" stage3-i686-${TIMESTAMP}.tar.xz* "${DEST_DEFAULT}"
+ ;;
+ esac
+ popd >/dev/null || exit
+
+ pushd "${BUILD_SRCDIR_BASE}"/hardened >/dev/null || exit
+ case ${spec} in
+ hardened/stage3.spec)
+ "${cmd[@]}" stage3-i686-hardened-${TIMESTAMP}.tar.xz* "${DEST_HARDENED}"
+ ;;
+ hardened/admincd-stage2.spec)
+ "${cmd[@]}" admincd-x86-${TIMESTAMP}.iso* "${DEST_HARDENED}"
+ ;;
+ esac
+ popd >/dev/null || exit
}
# vim:ft=sh:
diff --git a/tools/catalyst-auto-x86.conf b/tools/catalyst-auto-x86.conf
index 27637e59..e778ce8e 100644
--- a/tools/catalyst-auto-x86.conf
+++ b/tools/catalyst-auto-x86.conf
@@ -30,7 +30,7 @@ EXTENSIONS="[.tar.xz,.tar.bz2,.tar.gz,.tar,.sfs]"
update_symlinks() {
# Symlink the latest stages3 to build from
for d in ${BUILD_SRCDIR_BASE}/{default,hardened} ; do
- pushd $d >/dev/null
+ pushd "${d}" >/dev/null || exit
for f in $(ls stage3*${EXTENSIONS} | grep -v latest | give_latest_from_dates ) ; do
# 20yymmddThhmmssZ
# 20yymmddhhmmss
@@ -44,11 +44,13 @@ update_symlinks() {
<<<"$f")
ln -svf "$f" "$of"
done
- popd >/dev/null
+ popd >/dev/null || exit
done
}
post_build() {
+ local set=$1 spec=$2
+
cmd=(
rsync
-e 'ssh -i /root/.ssh/id_rsa -o UserKnownHostsFile=/dev/null -o VerifyHostKeyDNS=yes -o StrictHostKeyChecking=no'
@@ -67,34 +69,31 @@ post_build() {
DEST_HARDENED=${ARCH}@releng-incoming.gentoo.org:${BUILD_DESTDIR_BASE}/hardened
;;
esac
- pushd ${BUILD_SRCDIR_BASE}/default >/dev/null
- mkdir -p ${TMPDIR}/empty
- "${cmd[@]}" ${TMPDIR}/empty ${DEST_DEFAULT}
- for file in $(ls stage{3,4}*${DATESTAMP}*${EXTENSIONS} stage{3,4}*${TIMESTAMP}*${EXTENSIONS} ); do
- if [ -f $file ]; then
- "${cmd[@]}" ${file}* ${DEST_DEFAULT}
- fi
- done
- if [ -f *${DATESTAMP}*.iso ]; then
- "${cmd[@]}" *${DATESTAMP}*.iso* ${DEST_DEFAULT}
- elif [ -f *${TIMESTAMP}*.iso ]; then
- "${cmd[@]}" *${TIMESTAMP}*.iso* ${DEST_DEFAULT}
- fi
- popd >/dev/null
- pushd ${BUILD_SRCDIR_BASE}/hardened >/dev/null
- "${cmd[@]}" ${TMPDIR}/empty ${DEST_HARDENED}
- for file in $(ls stage{3,4}*${DATESTAMP}*${EXTENSIONS} stage{3,4}*${TIMESTAMP}*${EXTENSIONS} ); do
- if [ -f $file ]; then
- "${cmd[@]}" $file* ${DEST_HARDENED}
- fi
- done
- if [ -f *${DATESTAMP}*.iso ]; then
- "${cmd[@]}" *${DATESTAMP}*.iso* ${DEST_HARDENED}
- elif [ -f *${TIMESTAMP}*.iso ]; then
- "${cmd[@]}" *${TIMESTAMP}*.iso* ${DEST_HARDENED}
- fi
- popd >/dev/null
+ pushd "${BUILD_SRCDIR_BASE}"/default >/dev/null || exit
+ case ${spec} in
+ stage3.spec)
+ "${cmd[@]}" stage3-i486-${TIMESTAMP}.tar.xz* "${DEST_DEFAULT}"
+ ;;
+ installcd-stage2-minimal.spec)
+ "${cmd[@]}" install-x86-minimal-${TIMESTAMP}.iso* "${DEST_DEFAULT}"
+ ;;
+ i686/stage3.spec)
+ "${cmd[@]}" stage3-i686-${TIMESTAMP}.tar.xz* "${DEST_DEFAULT}"
+ ;;
+ esac
+ popd >/dev/null || exit
+
+ pushd "${BUILD_SRCDIR_BASE}"/hardened >/dev/null || exit
+ case ${spec} in
+ hardened/stage3.spec)
+ "${cmd[@]}" stage3-i686-hardened-${TIMESTAMP}.tar.xz* "${DEST_HARDENED}"
+ ;;
+ hardened/admincd-stage2.spec)
+ "${cmd[@]}" admincd-x86-${TIMESTAMP}.iso* "${DEST_HARDENED}"
+ ;;
+ esac
+ popd >/dev/null || exit
}
# vim:ft=sh:
--
2.26.2
next prev parent reply other threads:[~2020-05-15 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 13:07 [gentoo-releng] [PATCH 1/2] catalyst-auto-amd64*.conf: explicitly list files to be transferred Ben Kohler
2020-05-15 13:07 ` Ben Kohler [this message]
2020-05-15 16:32 ` Matt Turner
2020-05-15 16:45 ` Kohler, Benjamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515130719.3138513-2-bkohler@gentoo.org \
--to=bkohler@gentoo.org \
--cc=gentoo-releng@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox