From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-python+bounces-521-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
by finch.gentoo.org (Postfix) with ESMTP id 5DD471381F3
for <garchives@archives.gentoo.org>; Wed, 21 Aug 2013 18:26:52 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id EB2D5E0ABB;
Wed, 21 Aug 2013 18:26:51 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
(using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id 65160E0ABB
for <gentoo-python@lists.gentoo.org>; Wed, 21 Aug 2013 18:26:51 +0000 (UTC)
Received: from mail-wi0-x236.google.com (mail-wi0-x236.google.com [IPv6:2a00:1450:400c:c05::236])
(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
(No client certificate requested)
(Authenticated sender: floppym)
by smtp.gentoo.org (Postfix) with ESMTPSA id 5B98533ECA7
for <gentoo-python@lists.gentoo.org>; Wed, 21 Aug 2013 18:26:50 +0000 (UTC)
Received: by mail-wi0-f182.google.com with SMTP id hi8so792262wib.15
for <gentoo-python@lists.gentoo.org>; Wed, 21 Aug 2013 11:26:48 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=google.com; s=20120113;
h=mime-version:in-reply-to:references:date:message-id:subject:from:to
:cc:content-type:content-transfer-encoding;
bh=QCrvAYQfXRlHoSM0O9ChnTc+UxbkAMy50znTjH+jNZM=;
b=QZiC+JGxppwVWbpK+QSz2Y4qEGNnlGldrllrJvP5bxaT5xdlH6kHNoOqzt/hS6FeFG
/q1oc34yLON6zjw5cMzxr66O+09AXuYxYrSsCEO69sl28GzF0JZ4uPsYLW/uGpwIYRVn
nSt0awVWieX6MyIXXIzRyxJXz4BsHNFqK+G/RYU5X12VUZq3M+UsC1pXPH+aM7XIVeHd
N+kPxdVTq+EXB9R873hoY/k/C+gHwn02g8y532dhVvrnOiS6tSS6XTqFXSEU+yU4Wr/4
Hc+L7vLVOiqj3T+B5iQDcZZeeBK0Pu0w6yMvem4AhhDQ7CGgSJog2IJfKaMhZNC9wsMa
iS8g==
Precedence: bulk
List-Post: <mailto:gentoo-python@lists.gentoo.org>
List-Help: <mailto:gentoo-python+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-python+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-python+subscribe@lists.gentoo.org>
List-Id: Discussions centering around the Python ecosystem in Gentoo Linux <gentoo-python.gentoo.org>
X-BeenThere: gentoo-python@gentoo.org
X-BeenThere: gentoo-python@lists.gentoo.org
MIME-Version: 1.0
X-Received: by 10.180.205.236 with SMTP id lj12mr6498122wic.22.1377109608212;
Wed, 21 Aug 2013 11:26:48 -0700 (PDT)
Received: by 10.194.39.231 with HTTP; Wed, 21 Aug 2013 11:26:48 -0700 (PDT)
In-Reply-To: <1377081788-1666-2-git-send-email-mgorny@gentoo.org>
References: <20130821124232.00996a19@gentoo.org>
<1377081788-1666-2-git-send-email-mgorny@gentoo.org>
Date: Wed, 21 Aug 2013 14:26:48 -0400
Message-ID: <CAJ0EP43cEveVxJ7XD52AunJfUyG6eBUoBwt_TWrBO2dq0DEysA@mail.gmail.com>
Subject: Re: [gentoo-python] [PATCH distutils-r1 2/4] Add proper error
handling to _distutils-r1_disable_ez_setup.
From: Mike Gilbert <floppym@gentoo.org>
To: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= <mgorny@gentoo.org>
Cc: gentoo-python <gentoo-python@lists.gentoo.org>,
Gentoo Python Project <python@gentoo.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 3abdbb9e-fd06-432a-8710-1962148186a8
X-Archives-Hash: 384074eeec34c50c5878f5630d63a5fb
On Wed, Aug 21, 2013 at 6:43 AM, Micha=C5=82 G=C3=B3rny <mgorny@gentoo.org>=
wrote:
> ---
> gx86/eclass/distutils-r1.eclass | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/gx86/eclass/distutils-r1.eclass b/gx86/eclass/distutils-r1.e=
class
> index 97ddbe4..fba7634 100644
> --- a/gx86/eclass/distutils-r1.eclass
> +++ b/gx86/eclass/distutils-r1.eclass
> @@ -310,8 +310,12 @@ distutils_install_for_testing() {
>
> _distutils-r1_disable_ez_setup() {
> local stub=3D"def use_setuptools(*args, **kwargs): pass"
> - [[ -f ez_setup.py ]] && echo "${stub}" > ez_setup.py
> - [[ -f distribute_setup.py ]] && echo "${stub}" > distribute_setup=
.py
> + if [[ -f ez_setup.py ]]; then
> + echo "${stub}" > ez_setup.py || die
> + fi
> + if [[ -f distribute_setup.py ]]; then
> + echo "${stub}" > distribute_setup.py || die
> + fi
> }
>
> # @FUNCTION: distutils-r1_python_prepare_all
> --
> 1.8.3.2
>
>
LGTM