From: Mike Gilbert <floppym@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>
Cc: gentoo-python <gentoo-python@lists.gentoo.org>,
Gentoo Python Project <python@gentoo.org>
Subject: Re: [gentoo-python] [PATCH distutils-r1 2/4] Add proper error handling to _distutils-r1_disable_ez_setup.
Date: Wed, 21 Aug 2013 14:26:48 -0400 [thread overview]
Message-ID: <CAJ0EP43cEveVxJ7XD52AunJfUyG6eBUoBwt_TWrBO2dq0DEysA@mail.gmail.com> (raw)
In-Reply-To: <1377081788-1666-2-git-send-email-mgorny@gentoo.org>
On Wed, Aug 21, 2013 at 6:43 AM, Michał Górny <mgorny@gentoo.org> wrote:
> ---
> gx86/eclass/distutils-r1.eclass | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/gx86/eclass/distutils-r1.eclass b/gx86/eclass/distutils-r1.eclass
> index 97ddbe4..fba7634 100644
> --- a/gx86/eclass/distutils-r1.eclass
> +++ b/gx86/eclass/distutils-r1.eclass
> @@ -310,8 +310,12 @@ distutils_install_for_testing() {
>
> _distutils-r1_disable_ez_setup() {
> local stub="def use_setuptools(*args, **kwargs): pass"
> - [[ -f ez_setup.py ]] && echo "${stub}" > ez_setup.py
> - [[ -f distribute_setup.py ]] && echo "${stub}" > distribute_setup.py
> + if [[ -f ez_setup.py ]]; then
> + echo "${stub}" > ez_setup.py || die
> + fi
> + if [[ -f distribute_setup.py ]]; then
> + echo "${stub}" > distribute_setup.py || die
> + fi
> }
>
> # @FUNCTION: distutils-r1_python_prepare_all
> --
> 1.8.3.2
>
>
LGTM
next prev parent reply other threads:[~2013-08-21 18:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 10:42 [gentoo-python] [PATCHES] distutils-r1: some cleanup + egg-info fixes Michał Górny
2013-08-21 10:43 ` [gentoo-python] [PATCH distutils-r1 1/4] Namespace _disable_ez_setup Michał Górny
2013-08-21 18:25 ` Mike Gilbert
2013-08-21 10:43 ` [gentoo-python] [PATCH distutils-r1 2/4] Add proper error handling to _distutils-r1_disable_ez_setup Michał Górny
2013-08-21 18:26 ` Mike Gilbert [this message]
2013-08-21 10:43 ` [gentoo-python] [PATCH distutils-r1 3/4] Describe _distutils-r1_disable_ez_setup() using eclassdoc Michał Górny
2013-08-21 14:13 ` Mike Gilbert
2013-08-21 20:01 ` Michał Górny
2013-08-21 10:43 ` [gentoo-python] [PATCH distutils-r1 4/4] Copy egg-info files in python_prepare_all() Michał Górny
2013-08-21 18:31 ` [gentoo-python] " Mike Gilbert
2013-08-21 19:27 ` Michał Górny
2013-08-21 19:33 ` Mike Gilbert
2013-08-21 20:01 ` Michał Górny
2013-08-25 21:16 ` [gentoo-python] [PATCHES] distutils-r1: some cleanup + egg-info fixes Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ0EP43cEveVxJ7XD52AunJfUyG6eBUoBwt_TWrBO2dq0DEysA@mail.gmail.com \
--to=floppym@gentoo.org \
--cc=gentoo-python@lists.gentoo.org \
--cc=mgorny@gentoo.org \
--cc=python@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox