[gentoo-python] Re: [PATCH python-r1 1/2] Reuse multibuild.eclass in python_export_best().

[Mike Gilbert <floppym@gentoo.org>]

On Sun, Mar 17, 2013 at 6:33 PM, Michał Górny <mgorny@gentoo.org> wrote:
> ---
>  gx86/eclass/python-r1.eclass | 22 ++++++++--------------
>  1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass
> index 12e3baa..99bd240 100644
> --- a/gx86/eclass/python-r1.eclass
> +++ b/gx86/eclass/python-r1.eclass
> @@ -661,24 +661,18 @@ python_parallel_foreach_impl() {
>  python_export_best() {
>         debug-print-function ${FUNCNAME} "${@}"
>
> -       _python_validate_useflags
> -
>         [[ ${#} -gt 0 ]] || set -- EPYTHON PYTHON
>
> -       local impl best
> -       for impl in "${_PYTHON_ALL_IMPLS[@]}"; do
> -               if has "${impl}" "${PYTHON_COMPAT[@]}" \
> -                       && _python_impl_supported "${impl}" \
> -                       && use "python_targets_${impl}"
> -               then
> -                       best=${impl}
> -               fi
> -       done
> +       local best MULTIBUILD_VARIANTS
> +       _python_obtain_impls
>
> -       [[ ${best+1} ]] || die "python_export_best(): no implementation found!"
> +       _python_set_best() {
> +               best=${MULTIBUILD_VARIANT}
> +       }
> +       multibuild_for_best_variant _python_set_best
>
> -       debug-print "${FUNCNAME}: Best implementation is: ${impl}"
> -       python_export "${impl}" "${@}"
> +       debug-print "${FUNCNAME}: Best implementation is: ${best}"
> +       python_export "${best}" "${@}"
>  }
>
>  # @FUNCTION: python_replicate_script
> --
> 1.8.1.5
>

Seems reasonable.