From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1SkfjI-0003W3-Pz for garchives@archives.gentoo.org; Fri, 29 Jun 2012 18:15:41 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 03B2DE0814; Fri, 29 Jun 2012 18:15:37 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 46D9FE0814 for ; Fri, 29 Jun 2012 18:15:37 +0000 (UTC) Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id 7CF171B40B2 for ; Fri, 29 Jun 2012 18:15:36 +0000 (UTC) Received: by wgbfm10 with SMTP id fm10so3044281wgb.10 for ; Fri, 29 Jun 2012 11:15:34 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Discussions centering around the Python ecosystem in Gentoo Linux X-BeenThere: gentoo-python@gentoo.org X-BeenThere: gentoo-python@lists.gentoo.org MIME-Version: 1.0 Received: by 10.216.4.147 with SMTP id 19mr1272220wej.109.1340993733967; Fri, 29 Jun 2012 11:15:33 -0700 (PDT) Received: by 10.223.3.142 with HTTP; Fri, 29 Jun 2012 11:15:33 -0700 (PDT) In-Reply-To: References: Date: Fri, 29 Jun 2012 14:15:33 -0400 Message-ID: Subject: [gentoo-python] Re: eclass patch to fix test rdepend From: Mike Gilbert To: =?UTF-8?B?VG9tw6HFoSBDaHbDoXRhbA==?= Cc: python@gentoo.org, gentoo-python Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: cfbf0442-3a5a-4c28-bbe0-efacbf8bb5c3 X-Archives-Hash: 376e3ed3744b2b8d7697108fbb9dbc7d On Fri, Jun 29, 2012 at 8:04 AM, Tom=C3=A1=C5=A1 Chv=C3=A1tal wrote: > Hi guys, > > I have package that uses python only during the test phase -> test > conditional needed. > > Eclass currently adds the use conditional to depend and rdepend so I > would propose two choices > 1) detect some set of build only useflags, like the test and skip > rdepend assignment on them > > Index: python.eclass > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /var/cvsroot/gentoo-x86/eclass/python.eclass,v > retrieving revision 1.155 > diff -u -b -B -r1.155 python.eclass > --- python.eclass =C2=A0 =C2=A0 =C2=A0 9 Jun 2012 10:01:19 -0000 =C2=A0 = =C2=A0 =C2=A0 1.155 > +++ python.eclass =C2=A0 =C2=A0 =C2=A0 29 Jun 2012 12:03:37 -0000 > @@ -247,10 +247,10 @@ > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if [[ "${#_PYTHON_= ATOMS[@]}" -gt 1 ]]; then > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0DEPEND+=3D"${DEPEND:+ }${USE_flag}${USE_flag:+? > ( }|| ( ${_PYTHON_ATOMS[@]} )${USE_flag:+ )}" > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 RDEPEND+=3D"${RDEPEND:+ > }${USE_flag}${USE_flag:+? ( }|| ( ${_PYTHON_ATOMS[@]} )${USE_flag:+ > )}" > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 [[ ${USE_flag} =3D=3D test ]] || > RDEPEND+=3D"${RDEPEND:+ }${USE_flag}${USE_flag:+? ( }|| ( > ${_PYTHON_ATOMS[@]} )${USE_flag:+ )}" > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0DEPEND+=3D"${DEPEND:+ }${USE_flag}${USE_flag:+? > ( }${_PYTHON_ATOMS[@]}${USE_flag:+ )}" > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 RDEPEND+=3D"${RDEPEND:+ > }${USE_flag}${USE_flag:+? ( }${_PYTHON_ATOMS[@]}${USE_flag:+ )}" > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 [[ ${USE_flag} =3D=3D test ]] || > RDEPEND+=3D"${RDEPEND:+ }${USE_flag}${USE_flag:+? ( > }${_PYTHON_ATOMS[@]}${USE_flag:+ )}" > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fi > =C2=A0 =C2=A0 =C2=A0 =C2=A0else > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0die "Invalid synta= x of PYTHON_DEPEND" > > > 2) provide something like PYTHON_DEPEND_ONLY variable. > > You write the patch. > > Please let me know what you guys decide to do as i have to atler my > ebuild if you decide to go with number two. > > Cheers > > Tom Arfrever has a patch implementing PYTHON_BDEPEND (build-time only deps). Nobody has cared enough to apply it.