[gentoo-python] [PATCH] python.eclass: Add 3.4 to _CPYTHON3_GLOBALLY_SUPPORTED_ABIS

[gentoo-python] [PATCH] python.eclass: Add 3.4 to _CPYTHON3_GLOBALLY_SUPPORTED_ABIS

[Mike Gilbert]

Index: python.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/python.eclass,v
retrieving revision 1.169
diff -u -r1.169 python.eclass
--- python.eclass	6 Feb 2014 05:34:07 -0000	1.169
+++ python.eclass	17 Feb 2014 18:40:31 -0000
@@ -35,7 +35,7 @@
 # focus on converting packages to use the new eclasses.
 
 _CPYTHON2_GLOBALLY_SUPPORTED_ABIS=(2.4 2.5 2.6 2.7)
-_CPYTHON3_GLOBALLY_SUPPORTED_ABIS=(3.1 3.2 3.3)
+_CPYTHON3_GLOBALLY_SUPPORTED_ABIS=(3.1 3.2 3.3 3.4)
 _JYTHON_GLOBALLY_SUPPORTED_ABIS=(2.5-jython 2.7-jython)
 _PYPY_GLOBALLY_SUPPORTED_ABIS=(2.7-pypy-1.7 2.7-pypy-1.8 2.7-pypy-1.9 2.7-pypy-2.0)
 _PYTHON_GLOBALLY_SUPPORTED_ABIS=(${_CPYTHON2_GLOBALLY_SUPPORTED_ABIS[@]} ${_CPYTHON3_GLOBALLY_SUPPORTED_ABIS[@]} ${_JYTHON_GLOBALLY_SUPPORTED_ABIS[@]} ${_PYPY_GLOBALLY_SUPPORTED_ABIS[@]})

Re: [gentoo-python] [PATCH] python.eclass: Add 3.4 to _CPYTHON3_GLOBALLY_SUPPORTED_ABIS

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

Dnia 2014-02-17, o godz. 13:44:04
Mike Gilbert <floppym@gentoo.org> napisał(a):

> Index: python.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/python.eclass,v
> retrieving revision 1.169
> diff -u -r1.169 python.eclass
> --- python.eclass	6 Feb 2014 05:34:07 -0000	1.169
> +++ python.eclass	17 Feb 2014 18:40:31 -0000
> @@ -35,7 +35,7 @@
>  # focus on converting packages to use the new eclasses.
>  
>  _CPYTHON2_GLOBALLY_SUPPORTED_ABIS=(2.4 2.5 2.6 2.7)
> -_CPYTHON3_GLOBALLY_SUPPORTED_ABIS=(3.1 3.2 3.3)
> +_CPYTHON3_GLOBALLY_SUPPORTED_ABIS=(3.1 3.2 3.3 3.4)
>  _JYTHON_GLOBALLY_SUPPORTED_ABIS=(2.5-jython 2.7-jython)
>  _PYPY_GLOBALLY_SUPPORTED_ABIS=(2.7-pypy-1.7 2.7-pypy-1.8 2.7-pypy-1.9 2.7-pypy-2.0)
>  _PYTHON_GLOBALLY_SUPPORTED_ABIS=(${_CPYTHON2_GLOBALLY_SUPPORTED_ABIS[@]} ${_CPYTHON3_GLOBALLY_SUPPORTED_ABIS[@]} ${_JYTHON_GLOBALLY_SUPPORTED_ABIS[@]} ${_PYPY_GLOBALLY_SUPPORTED_ABIS[@]})

To be honest, I'm against adding new implementations to the old eclass.
I'm all for letting it rot and not adding extra work on maintaining
ebuilds using it. Since it is opt-out, adding the new implementation
would mean we need to add restrictions to ebuilds.

Instead, I'd just say that we require the new eclass for py3.4.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]

Re: [gentoo-python] [PATCH] python.eclass: Add 3.4 to _CPYTHON3_GLOBALLY_SUPPORTED_ABIS

[Mike Gilbert]

On Mon, Feb 17, 2014 at 2:12 PM, Michał Górny <mgorny@gentoo.org> wrote:
> Dnia 2014-02-17, o godz. 13:44:04
> Mike Gilbert <floppym@gentoo.org> napisał(a):
>
>> Index: python.eclass
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/eclass/python.eclass,v
>> retrieving revision 1.169
>> diff -u -r1.169 python.eclass
>> --- python.eclass     6 Feb 2014 05:34:07 -0000       1.169
>> +++ python.eclass     17 Feb 2014 18:40:31 -0000
>> @@ -35,7 +35,7 @@
>>  # focus on converting packages to use the new eclasses.
>>
>>  _CPYTHON2_GLOBALLY_SUPPORTED_ABIS=(2.4 2.5 2.6 2.7)
>> -_CPYTHON3_GLOBALLY_SUPPORTED_ABIS=(3.1 3.2 3.3)
>> +_CPYTHON3_GLOBALLY_SUPPORTED_ABIS=(3.1 3.2 3.3 3.4)
>>  _JYTHON_GLOBALLY_SUPPORTED_ABIS=(2.5-jython 2.7-jython)
>>  _PYPY_GLOBALLY_SUPPORTED_ABIS=(2.7-pypy-1.7 2.7-pypy-1.8 2.7-pypy-1.9 2.7-pypy-2.0)
>>  _PYTHON_GLOBALLY_SUPPORTED_ABIS=(${_CPYTHON2_GLOBALLY_SUPPORTED_ABIS[@]} ${_CPYTHON3_GLOBALLY_SUPPORTED_ABIS[@]} ${_JYTHON_GLOBALLY_SUPPORTED_ABIS[@]} ${_PYPY_GLOBALLY_SUPPORTED_ABIS[@]})
>
> To be honest, I'm against adding new implementations to the old eclass.
> I'm all for letting it rot and not adding extra work on maintaining
> ebuilds using it. Since it is opt-out, adding the new implementation
> would mean we need to add restrictions to ebuilds.
>
> Instead, I'd just say that we require the new eclass for py3.4.
>

That's fine by me, as long as it doesn't break anything. I can't think
of any such breakage off the top of my head.

Re: [gentoo-python] [PATCH] python.eclass: Add 3.4 to _CPYTHON3_GLOBALLY_SUPPORTED_ABIS

[Patrick McLean]

On Mon, 17 Feb 2014 14:15:41 -0500
Mike Gilbert <floppym@gentoo.org> wrote:

> On Mon, Feb 17, 2014 at 2:12 PM, Michał Górny <mgorny@gentoo.org>
> wrote:
> > Dnia 2014-02-17, o godz. 13:44:04
> > Mike Gilbert <floppym@gentoo.org> napisał(a):
> >
> > To be honest, I'm against adding new implementations to the old
> > eclass. I'm all for letting it rot and not adding extra work on
> > maintaining ebuilds using it. Since it is opt-out, adding the new
> > implementation would mean we need to add restrictions to ebuilds.
> >
> > Instead, I'd just say that we require the new eclass for py3.4.
> 
> That's fine by me, as long as it doesn't break anything. I can't think
> of any such breakage off the top of my head.
> 
Agreed, I don't see how it could break anything and it could help
speed up migrating the remaining packages to the new eclasses.