From: Mike Gilbert <floppym@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>
Cc: gentoo-python <gentoo-python@lists.gentoo.org>,
Gentoo Python Project <python@gentoo.org>
Subject: [gentoo-python] Re: python-any-r1 and MERGE_TYPE
Date: Thu, 10 Oct 2013 19:05:03 -0400 [thread overview]
Message-ID: <CAJ0EP42JTNrTE+L6GuG+UkpfF0CtmgwbL14ZnxdE6OpGz0LcJg@mail.gmail.com> (raw)
In-Reply-To: <20131010220455.35a59c40@gentoo.org>
On Thu, Oct 10, 2013 at 4:04 PM, Michał Górny <mgorny@gentoo.org> wrote:
> Hello,
>
> After adding python_gen_any_dep to solve issues with dependencies of
> python-any-r1 packages, there's yet another thing that needs some of
> our attention.
>
> Most of python-any-r1 ebuilds use Python during build-time only. I'm
> not aware of a single python-any-r1 ebuild that would use Python during
> pkg_* functions. This means that a typical python-any-r1 ebuild would
> need to:
>
> pkg_setup() {
> [[ ${MERGE_TYPE} != binary ]] && python-any-r1_pkg_setup
> }
>
> As you can guess, only a few ebuilds actually do that, and it's not
> really friendly to repeat that over and over again.
>
> While having this snippet missing usually doesn't cause much bad, it
> can be quite hurtful to binary packages in the future. Most
> importantly, when an ebuild uses uncommon version of Python during
> build time, the binary package will fail to install --
> python-any-r1_pkg_setup will bail out being unable to find supported
> Python.
>
> Therefore, I think it would be beneficial to add the MERGE_TYPE check
> inside pkg_setup. In case someone needs Python during binary package
> install, we can (likely in the future):
>
> 1. add a variable to disable the MERGE_TYPE check,
>
> 2. add a new function that does the actual Python setup and make
> the default pkg_setup() a common-case wrapper for it.
>
> What are your thoughts?
>
#2 sounds like a solid plan.
next prev parent reply other threads:[~2013-10-10 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 20:04 [gentoo-python] python-any-r1 and MERGE_TYPE Michał Górny
2013-10-10 23:05 ` Mike Gilbert [this message]
2013-10-11 9:04 ` [gentoo-python] " Marien Zwart
2013-10-12 11:16 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ0EP42JTNrTE+L6GuG+UkpfF0CtmgwbL14ZnxdE6OpGz0LcJg@mail.gmail.com \
--to=floppym@gentoo.org \
--cc=gentoo-python@lists.gentoo.org \
--cc=mgorny@gentoo.org \
--cc=python@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox