From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-python+bounces-412-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id CBED7198005 for <garchives@archives.gentoo.org>; Wed, 6 Mar 2013 15:28:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C37AEE0B4D; Wed, 6 Mar 2013 15:28:29 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4A6A7E0B4D for <gentoo-python@lists.gentoo.org>; Wed, 6 Mar 2013 15:28:29 +0000 (UTC) Received: from mail-ia0-x231.google.com (mail-ia0-x231.google.com [IPv6:2607:f8b0:4001:c02::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id 6C91B33DCDF for <gentoo-python@lists.gentoo.org>; Wed, 6 Mar 2013 15:28:28 +0000 (UTC) Received: by mail-ia0-f177.google.com with SMTP id y25so2151728iay.8 for <gentoo-python@lists.gentoo.org>; Wed, 06 Mar 2013 07:28:26 -0800 (PST) Precedence: bulk List-Post: <mailto:gentoo-python@lists.gentoo.org> List-Help: <mailto:gentoo-python+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-python+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-python+subscribe@lists.gentoo.org> List-Id: Discussions centering around the Python ecosystem in Gentoo Linux <gentoo-python.gentoo.org> X-BeenThere: gentoo-python@gentoo.org X-BeenThere: gentoo-python@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.50.100.201 with SMTP id fa9mr10621563igb.28.1362583706727; Wed, 06 Mar 2013 07:28:26 -0800 (PST) Received: by 10.64.102.66 with HTTP; Wed, 6 Mar 2013 07:28:26 -0800 (PST) In-Reply-To: <1362580294-3336-1-git-send-email-mgorny@gentoo.org> References: <1362580294-3336-1-git-send-email-mgorny@gentoo.org> Date: Wed, 6 Mar 2013 10:28:26 -0500 Message-ID: <CAJ0EP41T74CptO535bhEWwpR3KNprdSSkwjc4H3eAqEHCVRPoA@mail.gmail.com> Subject: [gentoo-python] Re: [PATCH python-r1] Move validity checks into _python_obtain_impls. From: Mike Gilbert <floppym@gentoo.org> To: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= <mgorny@gentoo.org> Cc: gentoo-python@lists.gentoo.org, python@gentoo.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 33839977-9e29-4813-8760-26fa3ef259a7 X-Archives-Hash: 5f5985f8f725e3a68f8914d616a6b965 On Wed, Mar 6, 2013 at 9:31 AM, Micha=C5=82 G=C3=B3rny <mgorny@gentoo.org> = wrote: > That is, _python_check_USE_PYTHON and _python_validate_useflags. Those > are always used along with per-implementation tasks, so better to have > them in _python_obtain_impls than call three functions every time. > > Also, remove redundant invocation. > > Note: rebased on multibuild_copy_sources() patch branch. > --- > gx86/eclass/python-r1.eclass | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass > index 36b20dc..9e625f5 100644 > --- a/gx86/eclass/python-r1.eclass > +++ b/gx86/eclass/python-r1.eclass > @@ -357,9 +357,6 @@ python_gen_cond_dep() { > python_copy_sources() { > debug-print-function ${FUNCNAME} "${@}" > > - _python_validate_useflags > - _python_check_USE_PYTHON > - > local MULTIBUILD_VARIANTS > _python_obtain_impls > > @@ -579,6 +576,9 @@ _python_check_USE_PYTHON() { > # @DESCRIPTION: > # Set up the enabled implementation list. > _python_obtain_impls() { > + _python_validate_useflags > + _python_check_USE_PYTHON > + > MULTIBUILD_VARIANTS=3D() > > for impl in "${_PYTHON_ALL_IMPLS[@]}"; do > @@ -621,9 +621,6 @@ _python_multibuild_wrapper() { > python_foreach_impl() { > debug-print-function ${FUNCNAME} "${@}" > > - _python_validate_useflags > - _python_check_USE_PYTHON > - > local MULTIBUILD_VARIANTS > _python_obtain_impls > > @@ -695,8 +692,6 @@ python_export_best() { > python_replicate_script() { > debug-print-function ${FUNCNAME} "${@}" > > - _python_validate_useflags > - > local suffixes=3D() > > _add_suffix() { > -- > 1.8.1.5 > ok