Re: [gentoo-python] Re: [PATCH] Introduce python_newscript().

[Mike Gilbert <floppym@gentoo.org>]

On Sat, Feb 2, 2013 at 4:58 AM, Michał Górny <mgorny@gentoo.org> wrote:
> On Fri, 1 Feb 2013 20:56:36 -0500
> Mike Gilbert <floppym@gentoo.org> wrote:
>
>> On Fri, Feb 1, 2013 at 8:46 PM, Michał Górny <mgorny@gentoo.org> wrote:
>> > Requested by jlec, I think.
>> > ---
>> >  gx86/eclass/python-utils-r1.eclass | 47 ++++++++++++++++++++++++++++++--------
>> >  1 file changed, 37 insertions(+), 10 deletions(-)
>> >
>> > diff --git a/gx86/eclass/python-utils-r1.eclass b/gx86/eclass/python-utils-r1.eclass
>> > index b425302..c5a1f6e 100644
>> > --- a/gx86/eclass/python-utils-r1.eclass
>> > +++ b/gx86/eclass/python-utils-r1.eclass
>> > @@ -521,7 +521,34 @@ python_scriptinto() {
>> >  python_doscript() {
>> >         debug-print-function ${FUNCNAME} "${@}"
>> >
>> > +       local f
>> > +       for f; do
>> > +               python_newscript "${f}" "${f}"
>> > +       done
>> > +}
>>
>>
>> Won't this break on something like "python_doscript path/to/script"?
>> That would result in this call:
>>
>> python_newscript path/to/script path/to/script
>>
>> If I'm reading python_newscript correctly, $2 should not have any path
>> information.
>
> Correct, thanks. It's now:
>
>         python_newscript "${f}" "${f##*/}"
>
> I've also removed 'oldfn' from python_newscript() which is practically
> unused.
>

Ok. +1 from me then.