[gentoo-python] [PATCH] Support overriding PYTHON_COMPAT.

[gentoo-python] [PATCH] Support overriding PYTHON_COMPAT.

[Michał Górny]

PYTHON_COMPAT_OVERRIDE is an environment variable which overrides
the current value of PYTHON_COMPAT.

Useful for testing packages with new Python implementations quickly
without modifying the ebuild. Outputs a lot of noisy warnings to make
sure people notice how hacky it is.

Example use:

$ PYTHON_COMPAT_OVERRIDE=python3_3 emerge -1v dev-python/nose
---
 gx86/eclass/python-any-r1.eclass    | 5 ++++-
 gx86/eclass/python-r1.eclass        | 5 ++++-
 gx86/eclass/python-single-r1.eclass | 5 ++++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/gx86/eclass/python-any-r1.eclass b/gx86/eclass/python-any-r1.eclass
index ad56dc7..cd23aa4 100644
--- a/gx86/eclass/python-any-r1.eclass
+++ b/gx86/eclass/python-any-r1.eclass
@@ -65,7 +65,10 @@ if [[ ! ${_PYTHON_ANY_R1} ]]; then
 # @CODE
 # PYTHON_COMPAT=( python{2_5,2_6,2_7} )
 # @CODE
-if ! declare -p PYTHON_COMPAT &>/dev/null; then
+if [[ ${PYTHON_COMPAT_OVERRIDE} ]]; then
+	ewarn "PYTHON_COMPAT overriden: ${PYTHON_COMPAT_OVERRIDE}"
+	PYTHON_COMPAT=( ${PYTHON_COMPAT_OVERRIDE} )
+elif ! declare -p PYTHON_COMPAT &>/dev/null; then
 	die 'PYTHON_COMPAT not declared.'
 fi
 
diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass
index 39de7f2..63bfb4e 100644
--- a/gx86/eclass/python-r1.eclass
+++ b/gx86/eclass/python-r1.eclass
@@ -66,7 +66,10 @@ inherit python-utils-r1
 # @CODE
 # PYTHON_COMPAT=( python{2_5,2_6,2_7} )
 # @CODE
-if ! declare -p PYTHON_COMPAT &>/dev/null; then
+if [[ ${PYTHON_COMPAT_OVERRIDE} ]]; then
+	ewarn "PYTHON_COMPAT overriden: ${PYTHON_COMPAT_OVERRIDE}"
+	PYTHON_COMPAT=( ${PYTHON_COMPAT_OVERRIDE} )
+elif ! declare -p PYTHON_COMPAT &>/dev/null; then
 	if [[ ${CATEGORY}/${PN} == dev-python/python-exec ]]; then
 		PYTHON_COMPAT=( "${_PYTHON_ALL_IMPLS[@]}" )
 	else
diff --git a/gx86/eclass/python-single-r1.eclass b/gx86/eclass/python-single-r1.eclass
index 51807f2..73f05f6 100644
--- a/gx86/eclass/python-single-r1.eclass
+++ b/gx86/eclass/python-single-r1.eclass
@@ -70,7 +70,10 @@ if [[ ! ${_PYTHON_SINGLE_R1} ]]; then
 # @CODE
 # PYTHON_COMPAT=( python{2_5,2_6,2_7} )
 # @CODE
-if ! declare -p PYTHON_COMPAT &>/dev/null; then
+if [[ ${PYTHON_COMPAT_OVERRIDE} ]]; then
+	ewarn "PYTHON_COMPAT overriden: ${PYTHON_COMPAT_OVERRIDE}"
+	PYTHON_COMPAT=( ${PYTHON_COMPAT_OVERRIDE} )
+elif ! declare -p PYTHON_COMPAT &>/dev/null; then
 	die 'PYTHON_COMPAT not declared.'
 fi
 
-- 
1.8.0.2

[gentoo-python] Re: [PATCH] Support overriding PYTHON_COMPAT.

[Mike Gilbert]

On Thu, Dec 13, 2012 at 5:44 AM, Michał Górny <mgorny@gentoo.org> wrote:
> PYTHON_COMPAT_OVERRIDE is an environment variable which overrides
> the current value of PYTHON_COMPAT.
>
> Useful for testing packages with new Python implementations quickly
> without modifying the ebuild. Outputs a lot of noisy warnings to make
> sure people notice how hacky it is.
>
> Example use:
>
> $ PYTHON_COMPAT_OVERRIDE=python3_3 emerge -1v dev-python/nose

Seems like an ok idea to me.

No eclass documentation?

Re: [gentoo-python] Re: [PATCH] Support overriding PYTHON_COMPAT.

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 724 bytes --]

On Thu, 13 Dec 2012 10:30:50 -0500
Mike Gilbert <floppym@gentoo.org> wrote:

> On Thu, Dec 13, 2012 at 5:44 AM, Michał Górny <mgorny@gentoo.org> wrote:
> > PYTHON_COMPAT_OVERRIDE is an environment variable which overrides
> > the current value of PYTHON_COMPAT.
> >
> > Useful for testing packages with new Python implementations quickly
> > without modifying the ebuild. Outputs a lot of noisy warnings to make
> > sure people notice how hacky it is.
> >
> > Example use:
> >
> > $ PYTHON_COMPAT_OVERRIDE=python3_3 emerge -1v dev-python/nose
> 
> Seems like an ok idea to me.
> 
> No eclass documentation?

I knew I forgot about something! Give me a few minutes.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

[gentoo-python] [PATCH] Add docs.

[Michał Górny]

---
 gx86/eclass/python-any-r1.eclass    | 12 ++++++++++++
 gx86/eclass/python-r1.eclass        | 12 ++++++++++++
 gx86/eclass/python-single-r1.eclass | 12 ++++++++++++
 3 files changed, 36 insertions(+)

diff --git a/gx86/eclass/python-any-r1.eclass b/gx86/eclass/python-any-r1.eclass
index cd23aa4..a8872df 100644
--- a/gx86/eclass/python-any-r1.eclass
+++ b/gx86/eclass/python-any-r1.eclass
@@ -72,6 +72,18 @@ elif ! declare -p PYTHON_COMPAT &>/dev/null; then
 	die 'PYTHON_COMPAT not declared.'
 fi
 
+# @ECLASS-VARIABLE: PYTHON_COMPAT_OVERRIDE
+# @INTERNAL
+# @DESCRIPTION:
+# This variable can be used to quickly override the value
+# of PYTHON_COMPAT for a package. It should be noted that it is intended
+# for testing packages only, and it must not be used in ebuilds.
+#
+# Example use:
+# @CODE
+# PYTHON_COMPAT_OVERRIDE=python3_3 emerge -1v dev-python/foo
+# @CODE
+
 # @ECLASS-VARIABLE: PYTHON_REQ_USE
 # @DEFAULT_UNSET
 # @DESCRIPTION:
diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass
index 63bfb4e..a97c948 100644
--- a/gx86/eclass/python-r1.eclass
+++ b/gx86/eclass/python-r1.eclass
@@ -77,6 +77,18 @@ elif ! declare -p PYTHON_COMPAT &>/dev/null; then
 	fi
 fi
 
+# @ECLASS-VARIABLE: PYTHON_COMPAT_OVERRIDE
+# @INTERNAL
+# @DESCRIPTION:
+# This variable can be used to quickly override the value
+# of PYTHON_COMPAT for a package. It should be noted that it is intended
+# for testing packages only, and it must not be used in ebuilds.
+#
+# Example use:
+# @CODE
+# PYTHON_COMPAT_OVERRIDE=python3_3 emerge -1v dev-python/foo
+# @CODE
+
 # @ECLASS-VARIABLE: PYTHON_REQ_USE
 # @DEFAULT_UNSET
 # @DESCRIPTION:
diff --git a/gx86/eclass/python-single-r1.eclass b/gx86/eclass/python-single-r1.eclass
index 73f05f6..c0ea168 100644
--- a/gx86/eclass/python-single-r1.eclass
+++ b/gx86/eclass/python-single-r1.eclass
@@ -77,6 +77,18 @@ elif ! declare -p PYTHON_COMPAT &>/dev/null; then
 	die 'PYTHON_COMPAT not declared.'
 fi
 
+# @ECLASS-VARIABLE: PYTHON_COMPAT_OVERRIDE
+# @INTERNAL
+# @DESCRIPTION:
+# This variable can be used to quickly override the value
+# of PYTHON_COMPAT for a package. It should be noted that it is intended
+# for testing packages only, and it must not be used in ebuilds.
+#
+# Example use:
+# @CODE
+# PYTHON_COMPAT_OVERRIDE=python3_3 emerge -1v dev-python/foo
+# @CODE
+
 # @ECLASS-VARIABLE: PYTHON_REQ_USE
 # @DEFAULT_UNSET
 # @DESCRIPTION:
-- 
1.8.0.2

Re: [gentoo-python] [PATCH] Support overriding PYTHON_COMPAT.

[Nikolaj Sjujskij]

Den 2012-12-13 14:44:41 skrev Michał Górny <mgorny@gentoo.org>:

> PYTHON_COMPAT_OVERRIDE is an environment variable which overrides
> the current value of PYTHON_COMPAT.
>
> Useful for testing packages with new Python implementations quickly
> without modifying the ebuild. Outputs a lot of noisy warnings to make
> sure people notice how hacky it is.
>
> Example use:
>
> $ PYTHON_COMPAT_OVERRIDE=python3_3 emerge -1v dev-python/nose

Has it been pushed to tree?

  % grep -r PYTHON_COMPAT_OVERRIDE /usr/portage/eclass/*
<nothing>

And I don't see anything related in ML archives. Have I missed something?

Re: [gentoo-python] [PATCH] Support overriding PYTHON_COMPAT.

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

On Wed, 13 Mar 2013 13:20:19 +0400
"Nikolaj Sjujskij" <sterkrig@myopera.com> wrote:

> Den 2012-12-13 14:44:41 skrev Michał Górny <mgorny@gentoo.org>:
> 
> > PYTHON_COMPAT_OVERRIDE is an environment variable which overrides
> > the current value of PYTHON_COMPAT.
> >
> > Useful for testing packages with new Python implementations quickly
> > without modifying the ebuild. Outputs a lot of noisy warnings to make
> > sure people notice how hacky it is.
> >
> > Example use:
> >
> > $ PYTHON_COMPAT_OVERRIDE=python3_3 emerge -1v dev-python/nose
> 
> Has it been pushed to tree?
> 
>   % grep -r PYTHON_COMPAT_OVERRIDE /usr/portage/eclass/*
> <nothing>
> 
> And I don't see anything related in ML archives. Have I missed something?

It couldn't work properly, so I withdrawn it. The major problem is that
metadata becomes affected by environmental variables.

Sadly, portage can't handle that nicely. Usually, it just results in
portage 'sticking' with one particular set of USE flags on the package
and trying to use the other one at the same time. In other words, a lot
of random behavior and QA warnings.

Probably, the nearest thing that could work is PYTHON_COMPAT_OVERRIDE
which doesn't use the USE flags but instead forces all impls listed.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]

Re: [gentoo-python] [PATCH] Support overriding PYTHON_COMPAT.

[Nikolaj Sjujskij]

Den 2013-03-13 23:49:33 skrev Michał Górny <mgorny@gentoo.org>:

> On Wed, 13 Mar 2013 13:20:19 +0400
> "Nikolaj Sjujskij" <sterkrig@myopera.com> wrote:
>
>> Den 2012-12-13 14:44:41 skrev Michał Górny <mgorny@gentoo.org>:
>>
>>> PYTHON_COMPAT_OVERRIDE is an environment variable which overrides
>>> the current value of PYTHON_COMPAT.
>>>
>>> Useful for testing packages with new Python implementations quickly
>>> without modifying the ebuild. Outputs a lot of noisy warnings to make
>>> sure people notice how hacky it is.
>>>
>>> Example use:
>>>
>>> $ PYTHON_COMPAT_OVERRIDE=python3_3 emerge -1v dev-python/nose
>>
>> Has it been pushed to tree?
>>
>>   % grep -r PYTHON_COMPAT_OVERRIDE /usr/portage/eclass/*
>> <nothing>
>>
>> And I don't see anything related in ML archives. Have I missed  
>> something?
>
> It couldn't work properly, so I withdrawn it. The major problem is that
> metadata becomes affected by environmental variables.
>
> Sadly, portage can't handle that nicely. Usually, it just results in
> portage 'sticking' with one particular set of USE flags on the package
> and trying to use the other one at the same time. In other words, a lot
> of random behavior and QA warnings.
>
> Probably, the nearest thing that could work is PYTHON_COMPAT_OVERRIDE
> which doesn't use the USE flags but instead forces all impls listed.
  I see... Well, that's unfortunate, I hoped to test pylint with it,  
hacking ebuild just for changing PYTHON_COMPAT isn't much fun.

Re: [gentoo-python] [PATCH] Support overriding PYTHON_COMPAT.

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

On Thu, 14 Mar 2013 17:10:26 +0400
"Nikolaj Sjujskij" <sterkrig@myopera.com> wrote:

> Den 2013-03-13 23:49:33 skrev Michał Górny <mgorny@gentoo.org>:
> 
> > It couldn't work properly, so I withdrawn it. The major problem is that
> > metadata becomes affected by environmental variables.
> >
> > Sadly, portage can't handle that nicely. Usually, it just results in
> > portage 'sticking' with one particular set of USE flags on the package
> > and trying to use the other one at the same time. In other words, a lot
> > of random behavior and QA warnings.
> >
> > Probably, the nearest thing that could work is PYTHON_COMPAT_OVERRIDE
> > which doesn't use the USE flags but instead forces all impls listed.
>   I see... Well, that's unfortunate, I hoped to test pylint with it,  
> hacking ebuild just for changing PYTHON_COMPAT isn't much fun.

Do you consider it useful enough if PYTHON_COMPAT_OVERRIDE affected
the build process only? Most importantly, visible USE flags
and dependency resolution wouldn't be affected.

I asked Zac about a possibility of disabling cache conditionally
to a variable but I don't think that reached anywhere.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]

Re: [gentoo-python] [PATCH] Support overriding PYTHON_COMPAT.

[Nikolaj Sjujskij]

Den 2013-03-14 20:15:55 skrev Michał Górny <mgorny@gentoo.org>:

> On Thu, 14 Mar 2013 17:10:26 +0400
> "Nikolaj Sjujskij" <sterkrig@myopera.com> wrote:
>
>> Den 2013-03-13 23:49:33 skrev Michał Górny <mgorny@gentoo.org>:
>>
>>> It couldn't work properly, so I withdrawn it. The major problem is  
>>> that metadata becomes affected by environmental variables.
>>>
>>> Sadly, portage can't handle that nicely. Usually, it just results in
>>> portage 'sticking' with one particular set of USE flags on the package
>>> and trying to use the other one at the same time. In other words, a  
>>> lot of random behavior and QA warnings.
>>>
>>> Probably, the nearest thing that could work is PYTHON_COMPAT_OVERRIDE
>>> which doesn't use the USE flags but instead forces all impls listed.
>>  I see... Well, that's unfortunate, I hoped to test pylint with it,
>> hacking ebuild just for changing PYTHON_COMPAT isn't much fun.
> Do you consider it useful enough if PYTHON_COMPAT_OVERRIDE affected
> the build process only? Most importantly, visible USE flags
> and dependency resolution wouldn't be affected.
  Yep, I think so. If you mean "build and install" by "build phase".
Suppose I do
  $ PYTHON_COMPAT_OVERRIDE="python3_3" emerge -1 dev-python/foo

It fails with "bar not found" (bar isn't installed for Python 3.3 as well)
  $ PYTHON_COMPAT_OVERRIDE="python3_3" emerge -1 dev-python/bar  
dev-python/foo

If modules are both OK wth Python 3.3, I want them to be installed for it  
as well. If that's the case, it'd be perfectly fine.

Re: [gentoo-python] [PATCH] Support overriding PYTHON_COMPAT.

[Mike Gilbert]

On Thu, Mar 14, 2013 at 12:15 PM, Michał Górny <mgorny@gentoo.org> wrote:
> On Thu, 14 Mar 2013 17:10:26 +0400
> "Nikolaj Sjujskij" <sterkrig@myopera.com> wrote:
>
>> Den 2013-03-13 23:49:33 skrev Michał Górny <mgorny@gentoo.org>:
>>
>> > It couldn't work properly, so I withdrawn it. The major problem is that
>> > metadata becomes affected by environmental variables.
>> >
>> > Sadly, portage can't handle that nicely. Usually, it just results in
>> > portage 'sticking' with one particular set of USE flags on the package
>> > and trying to use the other one at the same time. In other words, a lot
>> > of random behavior and QA warnings.
>> >
>> > Probably, the nearest thing that could work is PYTHON_COMPAT_OVERRIDE
>> > which doesn't use the USE flags but instead forces all impls listed.
>>   I see... Well, that's unfortunate, I hoped to test pylint with it,
>> hacking ebuild just for changing PYTHON_COMPAT isn't much fun.
>
> Do you consider it useful enough if PYTHON_COMPAT_OVERRIDE affected
> the build process only? Most importantly, visible USE flags
> and dependency resolution wouldn't be affected.

That sounds good enough to me. I usually do initial testing with the
ebuild command anyway.

Re: [gentoo-python] [PATCH] Support overriding PYTHON_COMPAT.

[Nikolaj Sjujskij]

Den 2013-03-14 23:02:45 skrev Mike Gilbert <floppym@gentoo.org>:

> On Thu, Mar 14, 2013 at 12:15 PM, Michał Górny <mgorny@gentoo.org> wrote:
>> On Thu, 14 Mar 2013 17:10:26 +0400
>> "Nikolaj Sjujskij" <sterkrig@myopera.com> wrote:
>>
>>> Den 2013-03-13 23:49:33 skrev Michał Górny <mgorny@gentoo.org>:
>>>
>>>> It couldn't work properly, so I withdrawn it. The major problem is
>>> that
>>>> metadata becomes affected by environmental variables.
>>>>
>>>> Sadly, portage can't handle that nicely. Usually, it just results in
>>>> portage 'sticking' with one particular set of USE flags on the
>>> package
>>>> and trying to use the other one at the same time. In other words, a
>>> lot
>>>> of random behavior and QA warnings.
>>>>
>>>> Probably, the nearest thing that could work is PYTHON_COMPAT_OVERRIDE
>>>> which doesn't use the USE flags but instead forces all impls listed.
>>>   I see... Well, that's unfortunate, I hoped to test pylint with it,
>>> hacking ebuild just for changing PYTHON_COMPAT isn't much fun.
>>
>> Do you consider it useful enough if PYTHON_COMPAT_OVERRIDE affected
>> the build process only? Most importantly, visible USE flags
>> and dependency resolution wouldn't be affected.
>
> That sounds good enough to me. I usually do initial testing with the
> ebuild command anyway.
That's fine for developer, who can bump ebuild afterwards, but hacking  
ebuild just to report a bug and have your changes overwritten on the next  
sync is a bit annoying :)