[gentoo-python] Re: [PATCHES] Cleaning python_foreach_impl() up and introduce a parallel variant

[Mike Gilbert <floppym@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]

On 02/21/2013 05:07 PM, Michał Górny wrote:
> Hello,
> 
> I'm sending a batch of patches (git-kind of replies to this mail).
> The patches do the following:
> 
> 
> 1) clean up failure handling in python_foreach_impl().
> 
> Currently, python_foreach_impl supposedly dies if one of the functions
> returns failure. This is quite unnecessary since most of the functions
> called there are supposed to be fatal themselves, and may be a bit
> confusing.
> 
> The idea is that:
> 
>   python_foreach_impl foo
> 
> should be as close to:
> 
>   for x in ...; do foo; done
> 
> as possible. The implicit '|| die' doesn't really look helpful since it
> may hurt people with small unimportant conditionals at the end of their
> functions, and may cause a few others to actually rely
> on python_foreach_impl handling failures for them.
> 
> Therefore, the function is not fatal anymore. Instead, it just returns
> 0 for complete success or status of first failure. In any case,
> the thingie called should 'die' on itself.
> 
> 
> 2) introduce a parallel variant of python_foreach_impl().
> 
> Based on the code from distutils-r1. For that reason and compatibility,
> the variable controlling no of jobs is still being called
> 'DISTUTILS_JOBS'.
> 
> The new function is also used in distutils-r1, with the two last
> patches doing pre-merge cleanup and actually using it.
> 
> 
> 3) move split log handling into python*_foreach_impl().
> 
> With the parallel build feature no longer being distutils-specific,
> the split logs shall be accessible outside of it. Therefore, I have
> moved their support completely to python*_foreach_impl() functions.
> 
> 

I don't have any problems with this as a whole.

I trust you will do some testing before moving it to the tree; if you
want some help with that, I can pitch in.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]