public inbox for gentoo-python@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: Ian Stakenvicius <axs@gentoo.org>
Cc: gentoo-python@lists.gentoo.org
Subject: Re: [gentoo-python] Reducing exceptionality cases for PYTHON_SINGLE_TARGET
Date: Thu, 30 Oct 2014 20:43:18 +0100	[thread overview]
Message-ID: <20141030204318.63f8d104@pomiot.lan> (raw)
In-Reply-To: <54528FAD.8080000@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

Dnia 2014-10-30, o godz. 15:21:17
Ian Stakenvicius <axs@gentoo.org> napisał(a):

> After discussion and review by mgorny, and significantly more testing,
> here's an updated version of the previous patch.
> 
> To reiterate, this patch changes python-single-r1 so that if there is
> only one supported Python implementation that can satisfy the ebuild,
> then PYTHON_SINGLE_TARGET is ignored, and the ebuild is bound by the
> value(s) set in PYTHON_TARGETS instead.

It is not ignored but not declared, which is good. Ignoring is bad :).

So I was pretty skeptic about this at first but after thinking it all
over a few times, I think it will work just fine. While it benefits
only the 'bad' kind of packages and adds some complexity, I believe
this is a worthwhile change.

Now that Python 2.6 is removed, there are many packages that support
only Python 2.7. For those packages, having two control variables is
pointless. We still need to keep PYTHON_TARGETS for USE dependency
matches against the package but we can safely remove
PYTHON_SINGLE_TARGET for it will be handled properly by (+) and (-)
defaults in the eclasses.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

  reply	other threads:[~2014-10-30 19:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 18:17 [gentoo-python] Reducing exceptionality cases for PYTHON_SINGLE_TARGET Ian Stakenvicius
2014-10-29 18:25 ` W. Trevor King
2014-10-29 18:40   ` Ian Stakenvicius
     [not found]   ` <5451330B.7000705@gentoo.org>
     [not found]     ` <20141029184254.GI15443@odin.tremily.us>
2014-10-29 18:47       ` Ian Stakenvicius
2014-10-29 18:31 ` Michał Górny
2014-10-29 18:39   ` Ian Stakenvicius
2014-10-29 20:09     ` Michał Górny
2014-10-29 20:21       ` Mike Gilbert
2014-10-29 20:25         ` Michał Górny
2014-10-30 19:21           ` Ian Stakenvicius
2014-10-30 19:43             ` Michał Górny [this message]
2014-10-30 20:26               ` Mike Gilbert
2014-10-30 21:31                 ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141030204318.63f8d104@pomiot.lan \
    --to=mgorny@gentoo.org \
    --cc=axs@gentoo.org \
    --cc=gentoo-python@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox