From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 217F61381F3 for ; Sat, 14 Sep 2013 23:05:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AF4DFE0AC1; Sat, 14 Sep 2013 23:05:41 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2637AE0AC1 for ; Sat, 14 Sep 2013 23:05:41 +0000 (UTC) Received: from localhost (87-205-68-74.adsl.inetia.pl [87.205.68.74]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 19A9633EAA9; Sat, 14 Sep 2013 23:05:38 +0000 (UTC) Date: Sun, 15 Sep 2013 00:38:52 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Mike Gilbert Cc: gentoo-python , Gentoo Python Project Subject: Re: [gentoo-python] Re: [PATCH 5/8] distutils-r1: disable sub-root merging. Message-ID: <20130915003852.3f989dab@gentoo.org> In-Reply-To: References: <1379098729-2801-1-git-send-email-mgorny@gentoo.org> <1379098729-2801-6-git-send-email-mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.9.2-dirty (GTK+ 2.24.20; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Discussions centering around the Python ecosystem in Gentoo Linux X-BeenThere: gentoo-python@gentoo.org X-BeenThere: gentoo-python@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/jJAQyzr5DvnQvRb3FR.3emn"; protocol="application/pgp-signature" X-Archives-Salt: 850aa931-9da4-4391-9627-97cacab430a6 X-Archives-Hash: 276fd0a266eb6e92fefe664f821fe12d --Sig_/jJAQyzr5DvnQvRb3FR.3emn Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dnia 2013-09-14, o godz. 18:16:33 Mike Gilbert napisa=C5=82(a): > On Fri, Sep 13, 2013 at 2:58 PM, Micha=C5=82 G=C3=B3rny wrote: > > The sub-roots are no longer necessary since we're installing scripts to > > per-impl directories initially. > > --- > > gx86/eclass/distutils-r1.eclass | 9 +++------ > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/gx86/eclass/distutils-r1.eclass b/gx86/eclass/distutils-r1= .eclass > > index 7102c58..5fcb55e 100644 > > --- a/gx86/eclass/distutils-r1.eclass > > +++ b/gx86/eclass/distutils-r1.eclass > > @@ -476,9 +476,7 @@ distutils-r1_python_install() { > > addpredict "$(python_get_sitedir)" > > addpredict /usr/lib/portage/pym > > > > - local root=3D${D}/_${EPYTHON} > > - [[ ${DISTUTILS_SINGLE_IMPL} ]] && root=3D${D} > > - flags+=3D( --root=3D"${root}" ) > > + flags+=3D( --root=3D"${D}" ) > > > > if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then > > local PYTHON_SCRIPTDIR > > @@ -488,13 +486,12 @@ distutils-r1_python_install() { > > > > esetup.py install "${flags[@]}" "${@}" > > > > - if [[ -d ${root}$(python_get_sitedir)/tests ]]; then > > + if [[ -d ${D}$(python_get_sitedir)/tests ]]; then > > die "Package installs 'tests' package, file collisions = likely." > > fi > > > > if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then > > - _distutils-r1_wrap_scripts "${root}" > > - multibuild_merge_root "${root}" "${D}" > > + _distutils-r1_wrap_scripts "${D}" > > fi > > } > > > > -- > > 1.8.3.2 > > >=20 > I believe this patch causes a race condition which causes > java-config's ebuild to fail. >=20 > running install_data > running install_egg_info > Writing /tmp/portage/dev-java/java-config-2.2.0/image/usr/lib64/python2.7= /site-packages/java_config- > 2.2.0-py2.7.egg-info > error: /tmp/portage/dev-java/java-config-2.2.0/image//usr/share/java-conf= ig-2/config/: > File exists I love when people hack build systems and have no idea about writing build systems... What are you suggesting? Finding all the broken stuff and fixing it, or restoring sub-roots? --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/jJAQyzr5DvnQvRb3FR.3emn Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (GNU/Linux) iQJ8BAEBCgBmBQJSNOWAXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOb4cP/AgpxMzXdjjtffqNIyr7bm5p xJnR4Wv5LPXFgWqmHAv4RHH+PTmXJh9Q3JTrZtt6nYL6nThDL6SWs6iF+Y9K2uZg DH509InYhB0QCfxO2KJ7ILw0wFOpdU6pN3yXIcsNHsocoug/a8ysdU0hMuCASR9Z Ple18OxmaeaK7Jszo+8ycmW7JkY1DF+xPCL2iOO9GVyK7BMiY0jrqwjUBF/5uCVh gN4S0Ss9WadE9T8y0+gROg+7lEyjRvmE28O7343112xcXrs4IWi/CAj3Tmp1r7vP kkqAyHBU+3MrXpTGaKAYTdbEYHpWVnOiQResPqS57fV9nyvuDFUANNebZeUk8grS DvhuRNj1O517taDm0eIMk8MtJ0o4PPqzgDrJTJZKOGubbHJUcnNGyq1fOG+ZYVgW PImP7pVlrZ7dHnoYS4vd1k8xbBLTD8bo8TPpwbwaA6K839P0Sk1ivcf+/sRWYZaA YCeJ5C7diKF+vYnI3szblKTQ4aye8UOqorvgIJA5DwvCa4WbMLuF0oKHknfA/478 VKX6ZsFgUahF4CWRjhE1vwXBoqnenRUUEAErJ0Rl2fkkN4DR7eLIZGG82gkb/CfD xb9RA1hIWnj19eMtmqrxIMCauMJoVMo/YjlWV/f4hjR/UIDktfr2VuC1RJ4gk9zd 1LKUIxsPPEVVHJhY+OZq =5hcD -----END PGP SIGNATURE----- --Sig_/jJAQyzr5DvnQvRb3FR.3emn--