From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4310A1381F3 for ; Sat, 27 Jul 2013 09:45:41 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C8DD3E09C9; Sat, 27 Jul 2013 09:45:36 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3E689E09C9 for ; Sat, 27 Jul 2013 09:45:36 +0000 (UTC) Received: from localhost (213-238-102-188.adsl.inetia.pl [213.238.102.188]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 082B333E1C2; Sat, 27 Jul 2013 09:45:33 +0000 (UTC) Date: Sat, 27 Jul 2013 11:45:48 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Cc: gentoo-python@lists.gentoo.org Subject: Re: [gentoo-python] [PATCH 2/6] [python-any-r1] do not use has_version() for interpreter checks. Message-ID: <20130727114548.459fcc67@gentoo.org> In-Reply-To: <1374486679-15887-2-git-send-email-mgorny@gentoo.org> References: <20130722114917.4f8d4b9a@gentoo.org> <1374486679-15887-2-git-send-email-mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.9.2-dirty (GTK+ 2.24.20; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Discussions centering around the Python ecosystem in Gentoo Linux X-BeenThere: gentoo-python@gentoo.org X-BeenThere: gentoo-python@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/EwslCspUcCN5ieedN//SWi/"; protocol="application/pgp-signature" X-Archives-Salt: 1ed8ed20-dcab-4e2e-80dd-663be40b9441 X-Archives-Hash: f6a6a68f86b5996b234dc7bc80b47f38 --Sig_/EwslCspUcCN5ieedN//SWi/ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dnia 2013-07-22, o godz. 11:51:15 Micha=C5=82 G=C3=B3rny napisa=C5=82(a): > has_version() can't handle any-of deps, and I see no point in > introducing special magic to handle pypy-bin there. Instead, just check > if the interpreter executable is installed. It is simpler and faster > this way. > --- > gx86/eclass/python-any-r1.eclass | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/gx86/eclass/python-any-r1.eclass b/gx86/eclass/python-any-r1= .eclass > index aa11cf7..b392453 100644 > --- a/gx86/eclass/python-any-r1.eclass > +++ b/gx86/eclass/python-any-r1.eclass > @@ -176,9 +176,10 @@ _python_EPYTHON_supported() { > esac > =20 > if has "${i}" "${PYTHON_COMPAT[@]}"; then > - local PYTHON_PKG_DEP > - python_export "${i}" PYTHON_PKG_DEP > - if ROOT=3D/ has_version "${PYTHON_PKG_DEP}"; then > + local PYTHON > + python_export PYTHON > + > + if [[ -x ${PYTHON} ]]; then > if declare -f python_check_deps >/dev/null; then > local PYTHON_USEDEP=3D"python_targets_${i}(-),python_single_target_$= {i}(+)" > python_check_deps marienz noticed that the previous version enforced PYTHON_REQ_USE and the new one doesn't. Let's discard this patch then and look for a better solution. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/EwslCspUcCN5ieedN//SWi/ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQJ8BAEBCgBmBQJR85bMXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKxeEP/2oNYZCVsIVCem0KmctYYkOu qWCX7xVCVwllu3+rRqTaX7JON9HhsgiDHSrb0328eDicSfD4EIMy6GSaYeWBI3Ds XoNt0OBc9qWVoinhsR32K06Y9jIPIjsVh/YVxgjjeMnKHAxhr4sOaM96V9bVm36D lO3naYGRwHMOKNLt00bhct92LpcuC3xePn0n1FpX8ekiLX7XT+qsU/iv226ntcVG HtMrbuM9grc0Cjc/b1oeZA7CAhbfVSSMkDW0mNUkLXs4zjB63nzvh8ujwED46zsV j8mEQMsVWXk3PDrblt4I43RQuuoXLmlcX/3lfAeeTcbI8LlqVQ+pUoNpGIniPnZY ZTuTqUhBFEPMRcLyZjxfYTAwS8An+joaPn+TOBBiqZ9QOds1s+w4OGj0B9boBXEQ aSpcLFHkGg5NqIgtkgrmAyHVHiGBCKZzP3ZX5d8a6T2tYQKnNzO7gsw5YRXG9bP4 iPxrI/7QxgUS5ZlAn+TF2INBATcS7edtlgPiqltls383wPxywLsiPbtgPw00SNFD vXsHIw6MK+MQWaNXtQQWyKg3XrFjAThCTinRfTsnXeSNucnK4SrpZ2qkOgP4PsND gUSfWt7lQmwWXjS3knN+5DU4AP2uFycXr8+gQmRzD3AgHnG6CgM4pZ/Zi7UnTG1H GtWj/yCY+7Y4/jN8G4K3 =X+6A -----END PGP SIGNATURE----- --Sig_/EwslCspUcCN5ieedN//SWi/--