public inbox for gentoo-python@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-python@lists.gentoo.org
Cc: python@gentoo.org
Subject: [gentoo-python] [PATCHES] Cleaning python_foreach_impl() up and introduce a parallel variant
Date: Thu, 21 Feb 2013 23:07:24 +0100	[thread overview]
Message-ID: <20130221230724.15b66f86@pomiocik.lan> (raw)

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

Hello,

I'm sending a batch of patches (git-kind of replies to this mail).
The patches do the following:


1) clean up failure handling in python_foreach_impl().

Currently, python_foreach_impl supposedly dies if one of the functions
returns failure. This is quite unnecessary since most of the functions
called there are supposed to be fatal themselves, and may be a bit
confusing.

The idea is that:

  python_foreach_impl foo

should be as close to:

  for x in ...; do foo; done

as possible. The implicit '|| die' doesn't really look helpful since it
may hurt people with small unimportant conditionals at the end of their
functions, and may cause a few others to actually rely
on python_foreach_impl handling failures for them.

Therefore, the function is not fatal anymore. Instead, it just returns
0 for complete success or status of first failure. In any case,
the thingie called should 'die' on itself.


2) introduce a parallel variant of python_foreach_impl().

Based on the code from distutils-r1. For that reason and compatibility,
the variable controlling no of jobs is still being called
'DISTUTILS_JOBS'.

The new function is also used in distutils-r1, with the two last
patches doing pre-merge cleanup and actually using it.


3) move split log handling into python*_foreach_impl().

With the parallel build feature no longer being distutils-specific,
the split logs shall be accessible outside of it. Therefore, I have
moved their support completely to python*_foreach_impl() functions.


-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]

             reply	other threads:[~2013-02-21 22:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-21 22:07 Michał Górny [this message]
2013-02-21 22:10 ` [gentoo-python] [PATCH 1/5] Make python_foreach_impl() non-fatal Michał Górny
2013-02-21 22:10 ` [gentoo-python] [PATCH 2/5] Introduce python_parallel_foreach_impl() Michał Górny
2013-02-21 22:10 ` [gentoo-python] [PATCH 3/5] Init&finish multijob inside d-r1_run_foreach_impl() Michał Górny
2013-02-21 22:10 ` [gentoo-python] [PATCH 4/5] Use python_parallel_foreach_impl() in distutils-r1 Michał Górny
2013-02-21 22:10 ` [gentoo-python] [PATCH 5/5] Re-enable split logs, now in python*_foreach_impl() Michał Górny
2013-02-24  1:42   ` [gentoo-python] " Mike Gilbert
2013-02-24 10:03     ` Michał Górny
2013-02-24  1:45 ` [gentoo-python] Re: [PATCHES] Cleaning python_foreach_impl() up and introduce a parallel variant Mike Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130221230724.15b66f86@pomiocik.lan \
    --to=mgorny@gentoo.org \
    --cc=gentoo-python@lists.gentoo.org \
    --cc=python@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox