[gentoo-python] [PATCH] Introduce run_in_build_dir() as requested in a few ebuilds.

[gentoo-python] [PATCH] Introduce run_in_build_dir() as requested in a few ebuilds.

[Michał Górny]

As people wanted to make a horrible monster out of this if added
to eutils, just add it here.
---
 gx86/eclass/python-r1.eclass | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass
index 63dc556..27653af 100644
--- a/gx86/eclass/python-r1.eclass
+++ b/gx86/eclass/python-r1.eclass
@@ -681,5 +681,24 @@ python_replicate_script() {
 	done
 }
 
+# @FUNCTION: run_in_build_dir
+# @USAGE: <argv>...
+# @DESCRIPTION:
+# Run the given command in the directory pointed by BUILD_DIR.
+run_in_build_dir() {
+	debug-print-function ${FUNCNAME} "${@}"
+	local ret
+
+	[[ ${#} -ne 0 ]] || die "${FUNCNAME}: no command specified."
+	[[ ${BUILD_DIR} ]] || die "${FUNCNAME}: BUILD_DIR not set."
+
+	pushd "${BUILD_DIR}" &>/dev/null || die
+	"${@}"
+	ret=${?}
+	popd &>/dev/null || die
+
+	return ${ret}
+}
+
 _PYTHON_R1=1
 fi
-- 
1.8.1.1

[gentoo-python] Re: [PATCH] Introduce run_in_build_dir() as requested in a few ebuilds.

[Mike Gilbert]

On Sat, Jan 26, 2013 at 6:28 AM, Michał Górny <mgorny@gentoo.org> wrote:
> As people wanted to make a horrible monster out of this if added
> to eutils, just add it here.
> ---
>  gx86/eclass/python-r1.eclass | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass
> index 63dc556..27653af 100644
> --- a/gx86/eclass/python-r1.eclass
> +++ b/gx86/eclass/python-r1.eclass
> @@ -681,5 +681,24 @@ python_replicate_script() {
>         done
>  }
>
> +# @FUNCTION: run_in_build_dir
> +# @USAGE: <argv>...
> +# @DESCRIPTION:
> +# Run the given command in the directory pointed by BUILD_DIR.
> +run_in_build_dir() {
> +       debug-print-function ${FUNCNAME} "${@}"
> +       local ret
> +
> +       [[ ${#} -ne 0 ]] || die "${FUNCNAME}: no command specified."
> +       [[ ${BUILD_DIR} ]] || die "${FUNCNAME}: BUILD_DIR not set."
> +
> +       pushd "${BUILD_DIR}" &>/dev/null || die
> +       "${@}"
> +       ret=${?}
> +       popd &>/dev/null || die
> +
> +       return ${ret}
> +}
> +
>  _PYTHON_R1=1
>  fi
> --
> 1.8.1.1
>

Maybe this should be prefixed with "python_" so as not to clobber the
same function which may be added to some other eclass?

Re: [gentoo-python] Re: [PATCH] Introduce run_in_build_dir() as requested in a few ebuilds.

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

On Sat, 26 Jan 2013 10:43:13 -0500
Mike Gilbert <floppym@gentoo.org> wrote:

> Maybe this should be prefixed with "python_" so as not to clobber the
> same function which may be added to some other eclass?

I was wondering about the same thing but supposedly the same function
in some other eclass should do the same ;).

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]