From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-python+bounces-345-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
by finch.gentoo.org (Postfix) with ESMTP id 0F63F138438
for <garchives@archives.gentoo.org>; Sat, 12 Jan 2013 21:35:36 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 8A79CE0642;
Sat, 12 Jan 2013 21:35:16 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
(using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id 0017AE0642
for <gentoo-python@lists.gentoo.org>; Sat, 12 Jan 2013 21:35:15 +0000 (UTC)
Received: from pomiocik.lan (77-253-134-231.adsl.inetia.pl [77.253.134.231])
(using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
(No client certificate requested)
(Authenticated sender: mgorny)
by smtp.gentoo.org (Postfix) with ESMTPSA id B24D233DA17;
Sat, 12 Jan 2013 21:35:13 +0000 (UTC)
Date: Sat, 12 Jan 2013 22:35:37 +0100
From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= <mgorny@gentoo.org>
To: Mike Gilbert <floppym@gentoo.org>
Cc: gentoo-python@lists.gentoo.org, python@gentoo.org
Subject: Re: [gentoo-python] Re: [PATCH] Export best implementation build
dir as BUILD_DIR in common phases.
Message-ID: <20130112223537.2cbfc29d@pomiocik.lan>
In-Reply-To: <50F1B3BC.6040709@gentoo.org>
References: <1358016741-15029-1-git-send-email-mgorny@gentoo.org>
<50F1B3BC.6040709@gentoo.org>
Organization: Gentoo
X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-python@lists.gentoo.org>
List-Help: <mailto:gentoo-python+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-python+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-python+subscribe@lists.gentoo.org>
List-Id: Discussions centering around the Python ecosystem in Gentoo Linux <gentoo-python.gentoo.org>
X-BeenThere: gentoo-python@gentoo.org
X-BeenThere: gentoo-python@lists.gentoo.org
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=PGP-SHA256;
boundary="Sig_/EuoW9EoiYLK/9NYN1IK+iPF"; protocol="application/pgp-signature"
X-Archives-Salt: 801386f7-5755-4613-954f-c05e8b283220
X-Archives-Hash: 6476ae48acbc76fafb2a9211ea26a175
--Sig_/EuoW9EoiYLK/9NYN1IK+iPF
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On Sat, 12 Jan 2013 14:04:28 -0500
Mike Gilbert <floppym@gentoo.org> wrote:
> On 01/12/2013 01:52 PM, Micha=C5=82 G=C3=B3rny wrote:
> > This is more friendly than BEST_BUILD_DIR and should not cause trouble
> > in the common cases.
> > ---
> > gx86/eclass/distutils-r1.eclass | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/gx86/eclass/distutils-r1.eclass b/gx86/eclass/distutils-r1=
.eclass
> > index 8156a36..9d6c714 100644
> > --- a/gx86/eclass/distutils-r1.eclass
> > +++ b/gx86/eclass/distutils-r1.eclass
> > @@ -450,9 +450,11 @@ distutils-r1_run_phase() {
> > # @DESCRIPTION:
> > # Run the given command, restoring the best-implementation state.
> > _distutils-r1_run_common_phase() {
> > + local DISTUTILS_ORIG_BUILD_DIR=3D${BUILD_DIR}
> > +
> > local EPYTHON=3D${_DISTUTILS_BEST_IMPL[0]}
> > local PYTHON=3D${_DISTUTILS_BEST_IMPL[1]}
> > - local BEST_BUILD_DIR=3D${_DISTUTILS_BEST_IMPL[2]}
> > + local BUILD_DIR=3D${_DISTUTILS_BEST_IMPL[2]}
> > local PYTHONPATH=3D${_DISTUTILS_BEST_IMPL[3]}
> > =20
> > export EPYTHON PYTHON PYTHONPATH
> >=20
>=20
> I never really understood the point of BEST_BUILD_DIR anyway. Did
> anything ever use it?
Well, the one ebuild that needed distutils BUILD_DIR.
The major issue is that BUILD_DIR is used in python_foreach_impl to
construct implementation-specific BUILD_DIRs. It's an unlikely scenario
but it will be a bit broken if anything in python_*_all() used
python_foreach_impl() and BUILD_DIR set by it.
--=20
Best regards,
Micha=C5=82 G=C3=B3rny
--Sig_/EuoW9EoiYLK/9NYN1IK+iPF
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
iJwEAQEIAAYFAlDx1ykACgkQfXuS5UK5QB0SwgQAg390UgDwaGDXOpAYS5h+EyXh
VpGttaCHc39xNrXh+1stPqF6MU4YFlxIhzDght5OqJsTtdwKRRNEqvyWr/vGHHe2
TmCvtv4nGnuJoRcPXlt9eRNtMbz6EqlUWv7I2ROHRw2H5NFLE9xfUX+I9F3pkYxH
RmynNiX8qg79aiP2QbM=
=DWQu
-----END PGP SIGNATURE-----
--Sig_/EuoW9EoiYLK/9NYN1IK+iPF--