public inbox for gentoo-python@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: Mike Gilbert <floppym@gentoo.org>
Cc: gentoo-python@lists.gentoo.org
Subject: Re: [gentoo-python] [PATCH] Support -A / --ABIs-patterns option in python_mod_optimize() and python_mod_cleanup()
Date: Thu, 29 Dec 2011 15:06:21 +0100	[thread overview]
Message-ID: <20111229150621.6d6583fd@pomiocik.lan> (raw)
In-Reply-To: <4EFC7013.70508@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

On Thu, 29 Dec 2011 08:50:11 -0500
Mike Gilbert <floppym@gentoo.org> wrote:

> On 12/29/2011 08:41 AM, Michał Górny wrote:
> > On Thu, 29 Dec 2011 08:08:26 -0500
> > Mike Gilbert <floppym@gentoo.org> wrote:
> > 
> >> This patch allows python_mod_optimize to be used in cases where a
> >> different set of python modules is installed depending on the
> >> python abi.
> >>
> >> For example, dev-python/feedparse-5.1 (not yet in the tree)
> >> installs the _feedparser_sgmllib.py module only in python-3*.
> > 
> > Could you paste some example on how it is supposed to be used?
> > 
> 
> Sure. Borrowed from feedparser-5.1.ebuild in Progress:
> 
> pkg_postinst() {
>     python_mod_optimize -A "2.*" feedparser.py
>     python_mod_optimize -A "3.*" feedparser.py _feedparser_sgmllib.py
> }
> 
> pkg_postrm() {
>     python_mod_cleanup -A "2.*" feedparser.py
>     python_mod_cleanup -A "3.*" feedparser.py _feedparser_sgmllib.py
> }

Ok, now that I see it, I think you're inventing a really big hammer to
get rid of a single mosquito.

On the other hand, I don't think I can think of a good per-ebuild way
to handle this. I'd rather start by pinging upstream not to pollute
global namespace and install a package instead; even if it supposed to
contain __init__.py only.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

  reply	other threads:[~2011-12-29 14:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-29 13:08 [gentoo-python] [PATCH] Support -A / --ABIs-patterns option in python_mod_optimize() and python_mod_cleanup() Mike Gilbert
2011-12-29 13:41 ` Michał Górny
2011-12-29 13:50   ` Mike Gilbert
2011-12-29 14:06     ` Michał Górny [this message]
2011-12-29 14:26       ` Mike Gilbert
2011-12-29 14:49         ` Mike Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111229150621.6d6583fd@pomiocik.lan \
    --to=mgorny@gentoo.org \
    --cc=floppym@gentoo.org \
    --cc=gentoo-python@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox