[gentoo-python] [PATCH python-r1] Move validity checks into _python_obtain_impls.

[gentoo-python] [PATCH python-r1] Move validity checks into _python_obtain_impls.

[Michał Górny]

That is, _python_check_USE_PYTHON and _python_validate_useflags. Those
are always used along with per-implementation tasks, so better to have
them in _python_obtain_impls than call three functions every time.

Also, remove redundant invocation.

Note: rebased on multibuild_copy_sources() patch branch.
---
 gx86/eclass/python-r1.eclass | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass
index 36b20dc..9e625f5 100644
--- a/gx86/eclass/python-r1.eclass
+++ b/gx86/eclass/python-r1.eclass
@@ -357,9 +357,6 @@ python_gen_cond_dep() {
 python_copy_sources() {
 	debug-print-function ${FUNCNAME} "${@}"
 
-	_python_validate_useflags
-	_python_check_USE_PYTHON
-
 	local MULTIBUILD_VARIANTS
 	_python_obtain_impls
 
@@ -579,6 +576,9 @@ _python_check_USE_PYTHON() {
 # @DESCRIPTION:
 # Set up the enabled implementation list.
 _python_obtain_impls() {
+	_python_validate_useflags
+	_python_check_USE_PYTHON
+
 	MULTIBUILD_VARIANTS=()
 
 	for impl in "${_PYTHON_ALL_IMPLS[@]}"; do
@@ -621,9 +621,6 @@ _python_multibuild_wrapper() {
 python_foreach_impl() {
 	debug-print-function ${FUNCNAME} "${@}"
 
-	_python_validate_useflags
-	_python_check_USE_PYTHON
-
 	local MULTIBUILD_VARIANTS
 	_python_obtain_impls
 
@@ -695,8 +692,6 @@ python_export_best() {
 python_replicate_script() {
 	debug-print-function ${FUNCNAME} "${@}"
 
-	_python_validate_useflags
-
 	local suffixes=()
 
 	_add_suffix() {
-- 
1.8.1.5

[gentoo-python] Re: [PATCH python-r1] Move validity checks into _python_obtain_impls.

[Mike Gilbert]

On Wed, Mar 6, 2013 at 9:31 AM, Michał Górny <mgorny@gentoo.org> wrote:
> That is, _python_check_USE_PYTHON and _python_validate_useflags. Those
> are always used along with per-implementation tasks, so better to have
> them in _python_obtain_impls than call three functions every time.
>
> Also, remove redundant invocation.
>
> Note: rebased on multibuild_copy_sources() patch branch.
> ---
>  gx86/eclass/python-r1.eclass | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass
> index 36b20dc..9e625f5 100644
> --- a/gx86/eclass/python-r1.eclass
> +++ b/gx86/eclass/python-r1.eclass
> @@ -357,9 +357,6 @@ python_gen_cond_dep() {
>  python_copy_sources() {
>         debug-print-function ${FUNCNAME} "${@}"
>
> -       _python_validate_useflags
> -       _python_check_USE_PYTHON
> -
>         local MULTIBUILD_VARIANTS
>         _python_obtain_impls
>
> @@ -579,6 +576,9 @@ _python_check_USE_PYTHON() {
>  # @DESCRIPTION:
>  # Set up the enabled implementation list.
>  _python_obtain_impls() {
> +       _python_validate_useflags
> +       _python_check_USE_PYTHON
> +
>         MULTIBUILD_VARIANTS=()
>
>         for impl in "${_PYTHON_ALL_IMPLS[@]}"; do
> @@ -621,9 +621,6 @@ _python_multibuild_wrapper() {
>  python_foreach_impl() {
>         debug-print-function ${FUNCNAME} "${@}"
>
> -       _python_validate_useflags
> -       _python_check_USE_PYTHON
> -
>         local MULTIBUILD_VARIANTS
>         _python_obtain_impls
>
> @@ -695,8 +692,6 @@ python_export_best() {
>  python_replicate_script() {
>         debug-print-function ${FUNCNAME} "${@}"
>
> -       _python_validate_useflags
> -
>         local suffixes=()
>
>         _add_suffix() {
> --
> 1.8.1.5
>

ok