public inbox for gentoo-python@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-python@lists.gentoo.org
Cc: python@gentoo.org, "Michał Górny" <mgorny@gentoo.org>
Subject: [gentoo-python] [PATCH updated 2/3] Don't rely on phase function return code.
Date: Mon,  3 Dec 2012 12:00:05 +0100	[thread overview]
Message-ID: <1354532406-5591-2-git-send-email-mgorny@gentoo.org> (raw)
In-Reply-To: <1354532406-5591-1-git-send-email-mgorny@gentoo.org>

It prohibits constructs like 'use x && y', and is not really necessary
when '|| die' should be used there anyway.
---
 gx86/eclass/distutils-r1.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gx86/eclass/distutils-r1.eclass b/gx86/eclass/distutils-r1.eclass
index db8fe86..a490252 100644
--- a/gx86/eclass/distutils-r1.eclass
+++ b/gx86/eclass/distutils-r1.eclass
@@ -380,9 +380,9 @@ distutils-r1_run_phase() {
 	fi
 
 	if [[ ${DISTUTILS_NO_PARALLEL_BUILD} ]]; then
-		"${@}" || die "${1} failed."
+		"${@}"
 	else
-		multijob_child_init "${@}" || die "${1} failed."
+		multijob_child_init "${@}"
 	fi
 
 	if [[ ${DISTUTILS_IN_SOURCE_BUILD} ]]; then
-- 
1.8.0



  reply	other threads:[~2012-12-03 11:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03 11:00 [gentoo-python] [PATCH updated 1/3] Set env for best Python impl in *_all() phases Michał Górny
2012-12-03 11:00 ` Michał Górny [this message]
2012-12-03 11:00 ` [gentoo-python] [PATCH updated 3/3] Example benefit of those changes Michał Górny
2012-12-03 15:46 ` [gentoo-python] Re: [PATCH updated 1/3] Set env for best Python impl in *_all() phases Mike Gilbert
2012-12-03 18:52   ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354532406-5591-2-git-send-email-mgorny@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-python@lists.gentoo.org \
    --cc=python@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox