public inbox for gentoo-proxy-maint@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-proxy-maint] [PATCH] games-arcade/oshu: Fix tests
@ 2020-04-01 18:07 Haelwenn (lanodan) Monnier
  2020-04-04  7:45 ` Joonas Niilola
  0 siblings, 1 reply; 2+ messages in thread
From: Haelwenn (lanodan) Monnier @ 2020-04-01 18:07 UTC (permalink / raw
  To: gentoo-proxy-maint; +Cc: Haelwenn (lanodan) Monnier

Turn out it was failing because cmake.eclass calls ctest directly

Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
---
 games-arcade/oshu/oshu-2.0.1.ebuild | 8 ++++----
 games-arcade/oshu/oshu-9999.ebuild  | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/games-arcade/oshu/oshu-2.0.1.ebuild b/games-arcade/oshu/oshu-2.0.1.ebuild
index 84d415b3c11..f394d808178 100644
--- a/games-arcade/oshu/oshu-2.0.1.ebuild
+++ b/games-arcade/oshu/oshu-2.0.1.ebuild
@@ -32,10 +32,6 @@ RDEPEND="
 
 DEPEND="${RDEPEND}"
 
-# Doesn't build executable needed for the test
-# https://github.com/fmang/oshu/issues/87
-RESTRICT="test"
-
 src_prepare() {
 	if use osu-skin; then
 		eapply "${FILESDIR}/oshu-2.0.0-use_unpacked_osu-skin.patch"
@@ -53,3 +49,7 @@ src_configure() {
 
 	cmake_src_configure
 }
+
+src_test() {
+	cmake_build check
+}
diff --git a/games-arcade/oshu/oshu-9999.ebuild b/games-arcade/oshu/oshu-9999.ebuild
index 84d415b3c11..f394d808178 100644
--- a/games-arcade/oshu/oshu-9999.ebuild
+++ b/games-arcade/oshu/oshu-9999.ebuild
@@ -32,10 +32,6 @@ RDEPEND="
 
 DEPEND="${RDEPEND}"
 
-# Doesn't build executable needed for the test
-# https://github.com/fmang/oshu/issues/87
-RESTRICT="test"
-
 src_prepare() {
 	if use osu-skin; then
 		eapply "${FILESDIR}/oshu-2.0.0-use_unpacked_osu-skin.patch"
@@ -53,3 +49,7 @@ src_configure() {
 
 	cmake_src_configure
 }
+
+src_test() {
+	cmake_build check
+}
-- 
2.24.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [gentoo-proxy-maint] [PATCH] games-arcade/oshu: Fix tests
  2020-04-01 18:07 [gentoo-proxy-maint] [PATCH] games-arcade/oshu: Fix tests Haelwenn (lanodan) Monnier
@ 2020-04-04  7:45 ` Joonas Niilola
  0 siblings, 0 replies; 2+ messages in thread
From: Joonas Niilola @ 2020-04-04  7:45 UTC (permalink / raw
  To: gentoo-proxy-maint


[-- Attachment #1.1: Type: text/plain, Size: 1754 bytes --]

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b23467f58e057f864b964b41fe311f401517588

On 4/1/20 9:07 PM, Haelwenn (lanodan) Monnier wrote:
> Turn out it was failing because cmake.eclass calls ctest directly
>
> Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
> ---
>  games-arcade/oshu/oshu-2.0.1.ebuild | 8 ++++----
>  games-arcade/oshu/oshu-9999.ebuild  | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/games-arcade/oshu/oshu-2.0.1.ebuild b/games-arcade/oshu/oshu-2.0.1.ebuild
> index 84d415b3c11..f394d808178 100644
> --- a/games-arcade/oshu/oshu-2.0.1.ebuild
> +++ b/games-arcade/oshu/oshu-2.0.1.ebuild
> @@ -32,10 +32,6 @@ RDEPEND="
>  
>  DEPEND="${RDEPEND}"
>  
> -# Doesn't build executable needed for the test
> -# https://github.com/fmang/oshu/issues/87
> -RESTRICT="test"
> -
>  src_prepare() {
>  	if use osu-skin; then
>  		eapply "${FILESDIR}/oshu-2.0.0-use_unpacked_osu-skin.patch"
> @@ -53,3 +49,7 @@ src_configure() {
>  
>  	cmake_src_configure
>  }
> +
> +src_test() {
> +	cmake_build check
> +}
> diff --git a/games-arcade/oshu/oshu-9999.ebuild b/games-arcade/oshu/oshu-9999.ebuild
> index 84d415b3c11..f394d808178 100644
> --- a/games-arcade/oshu/oshu-9999.ebuild
> +++ b/games-arcade/oshu/oshu-9999.ebuild
> @@ -32,10 +32,6 @@ RDEPEND="
>  
>  DEPEND="${RDEPEND}"
>  
> -# Doesn't build executable needed for the test
> -# https://github.com/fmang/oshu/issues/87
> -RESTRICT="test"
> -
>  src_prepare() {
>  	if use osu-skin; then
>  		eapply "${FILESDIR}/oshu-2.0.0-use_unpacked_osu-skin.patch"
> @@ -53,3 +49,7 @@ src_configure() {
>  
>  	cmake_src_configure
>  }
> +
> +src_test() {
> +	cmake_build check
> +}


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 642 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-04  7:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-01 18:07 [gentoo-proxy-maint] [PATCH] games-arcade/oshu: Fix tests Haelwenn (lanodan) Monnier
2020-04-04  7:45 ` Joonas Niilola

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox