From: Joonas Niilola <juippis@gentoo.org>
To: gentoo-proxy-maint@lists.gentoo.org
Subject: Re: [gentoo-proxy-maint] [PATCH] games-arcade/oshu: Fix tests
Date: Sat, 4 Apr 2020 10:45:18 +0300 [thread overview]
Message-ID: <a9c0048c-6d44-6b4d-c02f-5b223436b201@gentoo.org> (raw)
In-Reply-To: <20200401180747.23842-1-contact@hacktivis.me>
[-- Attachment #1.1: Type: text/plain, Size: 1754 bytes --]
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b23467f58e057f864b964b41fe311f401517588
On 4/1/20 9:07 PM, Haelwenn (lanodan) Monnier wrote:
> Turn out it was failing because cmake.eclass calls ctest directly
>
> Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
> ---
> games-arcade/oshu/oshu-2.0.1.ebuild | 8 ++++----
> games-arcade/oshu/oshu-9999.ebuild | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/games-arcade/oshu/oshu-2.0.1.ebuild b/games-arcade/oshu/oshu-2.0.1.ebuild
> index 84d415b3c11..f394d808178 100644
> --- a/games-arcade/oshu/oshu-2.0.1.ebuild
> +++ b/games-arcade/oshu/oshu-2.0.1.ebuild
> @@ -32,10 +32,6 @@ RDEPEND="
>
> DEPEND="${RDEPEND}"
>
> -# Doesn't build executable needed for the test
> -# https://github.com/fmang/oshu/issues/87
> -RESTRICT="test"
> -
> src_prepare() {
> if use osu-skin; then
> eapply "${FILESDIR}/oshu-2.0.0-use_unpacked_osu-skin.patch"
> @@ -53,3 +49,7 @@ src_configure() {
>
> cmake_src_configure
> }
> +
> +src_test() {
> + cmake_build check
> +}
> diff --git a/games-arcade/oshu/oshu-9999.ebuild b/games-arcade/oshu/oshu-9999.ebuild
> index 84d415b3c11..f394d808178 100644
> --- a/games-arcade/oshu/oshu-9999.ebuild
> +++ b/games-arcade/oshu/oshu-9999.ebuild
> @@ -32,10 +32,6 @@ RDEPEND="
>
> DEPEND="${RDEPEND}"
>
> -# Doesn't build executable needed for the test
> -# https://github.com/fmang/oshu/issues/87
> -RESTRICT="test"
> -
> src_prepare() {
> if use osu-skin; then
> eapply "${FILESDIR}/oshu-2.0.0-use_unpacked_osu-skin.patch"
> @@ -53,3 +49,7 @@ src_configure() {
>
> cmake_src_configure
> }
> +
> +src_test() {
> + cmake_build check
> +}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 642 bytes --]
prev parent reply other threads:[~2020-04-04 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 18:07 [gentoo-proxy-maint] [PATCH] games-arcade/oshu: Fix tests Haelwenn (lanodan) Monnier
2020-04-04 7:45 ` Joonas Niilola [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9c0048c-6d44-6b4d-c02f-5b223436b201@gentoo.org \
--to=juippis@gentoo.org \
--cc=gentoo-proxy-maint@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox