From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8ED53138350 for ; Mon, 30 Mar 2020 06:43:52 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B417DE096B; Mon, 30 Mar 2020 06:43:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 475D0E096B for ; Mon, 30 Mar 2020 06:43:51 +0000 (UTC) Received: from [192.168.1.219] (dsl-tkubng11-54f8a9-242.dhcp.inet.fi [84.248.169.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: juippis) by smtp.gentoo.org (Postfix) with ESMTPSA id 34A9734F28B for ; Mon, 30 Mar 2020 06:43:50 +0000 (UTC) Subject: Re: [gentoo-proxy-maint] [PATCH 1/2] games-arcade/oshu: Version bump, 2.0.1 To: gentoo-proxy-maint@lists.gentoo.org References: <20200330023058.19893-1-contact@hacktivis.me> From: Joonas Niilola Message-ID: Date: Mon, 30 Mar 2020 09:43:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Proxy Maintainers X-BeenThere: gentoo-proxy-maint@gentoo.org X-BeenThere: gentoo-proxy-maint@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 In-Reply-To: <20200330023058.19893-1-contact@hacktivis.me> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="smVPLrC2dEXjz4YnjZK9Oz1kD34SUa7QA" X-Archives-Salt: 70ce782f-97a7-4af0-9468-38d2e9d56225 X-Archives-Hash: 870c8a30e3bf5256eece552cff7f80d1 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --smVPLrC2dEXjz4YnjZK9Oz1kD34SUa7QA Content-Type: multipart/mixed; boundary="GQgEvoDj6y3eL5z4TjeV99Q6ce9l7zUUo" --GQgEvoDj6y3eL5z4TjeV99Q6ce9l7zUUo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US On 3/30/20 5:30 AM, Haelwenn (lanodan) Monnier wrote: > Signed-off-by: Haelwenn (lanodan) Monnier > --- > games-arcade/oshu/Manifest | 1 + > games-arcade/oshu/oshu-2.0.1.ebuild | 65 +++++++++++++++++++++++++++++= > 2 files changed, 66 insertions(+) > create mode 100644 games-arcade/oshu/oshu-2.0.1.ebuild > > diff --git a/games-arcade/oshu/Manifest b/games-arcade/oshu/Manifest > index ef952619335..58793eeb050 100644 > --- a/games-arcade/oshu/Manifest > +++ b/games-arcade/oshu/Manifest > @@ -1,2 +1,3 @@ > DIST oshu-2.0.0.tar.gz 144088 BLAKE2B c4383746624f4de62e158a2f94d4e5c1= a3e2f037fd05d80607932414f20a031103bd73f108644a93faadf61c21f3d2505da3afd2e= a7ea43bd59e32966724928b SHA512 ed2b8294b06d239948c563135d997b422191be681f= f86714a244ca64079251508a5a62e23cf3ae1e0ac2b3128b6401901233714eab778798929= 6ca1700192643 > +DIST oshu-2.0.1.tar.gz 144900 BLAKE2B 47f1d0a11255459ae357142499aeffcf= 07fbcad961cb34ba98e9efa7cb4229cf8d61ec836a4c899f2ea0883f1252395bc0c6ff34c= 5d670d67091cf6483d135ff SHA512 65768b3d8e7733464f05a19bbee594c0be728267bb= d0667bc0f34e0d01a39e52d4ecce89a9223f7c454d73b21bc735401e9d83eea8b0a2eaf1c= 7825a3bd6b1cf > DIST oshu-skin-v1.tar.gz 2224947 BLAKE2B 0b463133dd7ab54421551627d1293= 2f5257848b1130d57af8c2ff6b6836a49c9322b8f2f7e95de540909390d0139e547650a6b= b321614cf92fac464b09075674 SHA512 d562294ac5e122a9d9971e3ab92f6168d848177= cc5e22a94bbc450fde2b3b14007796a24d33722da9b6675467b109ce128ba94dca5dcc7c6= 1c91c1e373032618 > diff --git a/games-arcade/oshu/oshu-2.0.1.ebuild b/games-arcade/oshu/os= hu-2.0.1.ebuild > new file mode 100644 > index 00000000000..b46284d4604 > --- /dev/null > +++ b/games-arcade/oshu/oshu-2.0.1.ebuild > @@ -0,0 +1,65 @@ > +# Copyright 1999-2020 Gentoo Authors > +# Distributed under the terms of the GNU General Public License v2 > + > +EAPI=3D7 > + > +CMAKE_MIN_VERSION=3D"3.9.0" > + > +inherit cmake-utils Try to use cmake.eclass, cmake-utils is being deprecated for this kind of use. Remember to update functions below. > + > +DESCRIPTION=3D"Lightweight osu! port" > +HOMEPAGE=3D"https://github.com/fmang/oshu" > + > +if [[ $PV =3D *9999 ]]; then > + inherit git-r3 > + EGIT_REPO_URI=3D"https://github.com/fmang/oshu.git" > + SRC_URI=3D"osu-skin? ( https://www.mg0.fr/oshu/skins/osu-v1.tar.gz ->= ${PN}-skin-v1.tar.gz )" > +else > + SRC_URI=3D"https://github.com/fmang/oshu/archive/${PV}.tar.gz -> oshu= -${PV}.tar.gz > + osu-skin? ( https://www.mg0.fr/oshu/skins/osu-v1.tar.gz -> ${PN}-ski= n-v1.tar.gz )" > + KEYWORDS=3D"~amd64 ~x86" > +fi > + > +LICENSE=3D"GPL-3 CC-BY-NC-4.0" > +SLOT=3D"0" > +IUSE=3D"osu-skin" > + > +RDEPEND=3D" > + >=3Dmedia-libs/libsdl2-2.0.5:=3D > + media-libs/sdl2-image:=3D > + x11-libs/cairo:=3D > + x11-libs/pango:=3D > + media-video/ffmpeg:=3D > +" Only ffmpeg from has subslots, so :=3D on the other ones are redundant. > + > +DEPEND=3D"${RDEPEND}" > + > +RESTRICT=3D"test" Why? Add a comment and preferably a bug number / upstream issue on top to explain the restriction. > + > +src_prepare() { > + if use osu-skin; then > + eapply "${FILESDIR}/oshu-2.0.0-use_unpacked_osu-skin.patch" > + mv "${WORKDIR}/osu" share/skins/ || die > + fi > + > + cmake-utils_src_prepare > +} > + > +src_configure() { > + local mycmakeargs=3D( > + '-DOSHU_DEFAULT_SKIN=3D'$(usex osu-skin 'osu' 'minimal') > + '-DOSHU_SKINS=3Dminimal'$(usex osu-skin ';osu' '') > + ) > + > + cmake-utils_src_configure > +} > + > +pkg_postinst() { > + xdg_desktop_database_update > + xdg_mimeinfo_database_update > +} > + > +pkg_postrm() { > + xdg_desktop_database_update > + xdg_mimeinfo_database_update > +} No xdg* eclass is inherited. I'm aware cmake.utils inherits it, but you should imply the eclasses whose functions you use, so if the situation with cmake.eclass changes in future this won't break. You can also use xdg.eclass and you don't have to define pkg_{postinst,postrm} in this ebuild at all. --GQgEvoDj6y3eL5z4TjeV99Q6ce9l7zUUo-- --smVPLrC2dEXjz4YnjZK9Oz1kD34SUa7QA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGnBAEBCgCRFiEEltRJ9L6XRmDQCngHc4OUK43AaWIFAl6BlSJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk2 RDQ0OUY0QkU5NzQ2NjBEMDBBNzgwNzczODM5NDJCOERDMDY5NjITHGp1aXBwaXNA Z2VudG9vLm9yZwAKCRBzg5QrjcBpYtKRB/0TRo7Lr8A1E3da0SiqEo4Oq3dpGVsJ PADHQJKr5kH6KNrGRoY6scYNIEbC7t3IHPMpMks0Ydi8395Janh33ATcFyivgYlT m7g8zcq2GrE1W/r7ny/r1Ru+uEcMZENK2OtAoA36K1rKZckQK+A5N+R/17Pb57PE PZenXAryVrk3ZeiFV7G2yAC1qpWMyeFzD7SerfkPVakp+SAcH4B6RGn16MefVeys KEnBBSsvYc+Z0jpNPz6yz129XzwVdKyQ0EDt995ENJb3Y6c4Rt5uXO3eCchMaoc3 tEEV59as210zVjCUv7Ey0WwympW9a4+rBE/Dgb6ud5tse/4Ynzn4i6CM =9c9V -----END PGP SIGNATURE----- --smVPLrC2dEXjz4YnjZK9Oz1kD34SUa7QA--