public inbox for gentoo-proxy-maint@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-proxy-maint] [PATCH 1/2] app-emulation/crun: bump to 0.13
@ 2020-05-13 17:12 Robert Günzler
  2020-05-13 17:12 ` [gentoo-proxy-maint] [PATCH 2/2] app-emulation/crun: new maintainer Robert Günzler
  2020-05-15 13:25 ` [gentoo-proxy-maint] [PATCH 1/2] app-emulation/crun: bump to 0.13 Joonas Niilola
  0 siblings, 2 replies; 10+ messages in thread
From: Robert Günzler @ 2020-05-13 17:12 UTC (permalink / raw
  To: gentoo-proxy-maint; +Cc: Robert Günzler

From: Robert Günzler <r@gnzler.io>

Closes: https://bugs.gentoo.org/709982
Signed-off-by: Robert Günzler <r@gnzler.io>
---
 app-emulation/crun/Manifest                   |  2 +-
 .../{crun-0.10.6.ebuild => crun-0.13.ebuild}  | 34 ++++++++++---------
 ...duplicate-json_common-in-makefile-am.patch | 31 +++++++++++++++++
 3 files changed, 50 insertions(+), 17 deletions(-)
 rename app-emulation/crun/{crun-0.10.6.ebuild => crun-0.13.ebuild} (69%)
 create mode 100644 app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch

diff --git a/app-emulation/crun/Manifest b/app-emulation/crun/Manifest
index 1652b2325..24ebd99e1 100644
--- a/app-emulation/crun/Manifest
+++ b/app-emulation/crun/Manifest
@@ -1 +1 @@
-DIST crun-0.10.6.tar.gz 1242736 BLAKE2B 840699c6a07ddaef3f6ab4ce226fa6c4ebf0e32641012b6467a2a622d575a48286555b84140d5a1c947b5ef00a691045b0618533fb246bfb6d605baa262febe4 SHA512 b7db09d0c7d2d6e8b1ea239ead5a2ca2b97f188a74f08f0d5ac787e0a698fddf596e7cfdde482c6bc8790d06a7705613e877344a44691c0be7388e6d046c4b15
+DIST crun-0.13.tar.gz 1305048 BLAKE2B fbffabf4cfc744522147b47c5e2bf2bc48e074866108ec4ec8ab94e7ebdc39451851696fabde268b5853e1c3fafb0ac93527e08fdb766acebdd7cf952a9e1a9e SHA512 314612eaf3097160e9369b3400ac8a83e173ef1a53295191c925e96212ba00d032883db1e4615b8ba42ddb08f1e31ca5e5088ea583a469835ac3c27087a88d6e
diff --git a/app-emulation/crun/crun-0.10.6.ebuild b/app-emulation/crun/crun-0.13.ebuild
similarity index 69%
rename from app-emulation/crun/crun-0.10.6.ebuild
rename to app-emulation/crun/crun-0.13.ebuild
index a644095e8..7b7d5fcda 100644
--- a/app-emulation/crun/crun-0.10.6.ebuild
+++ b/app-emulation/crun/crun-0.13.ebuild
@@ -5,20 +5,19 @@ EAPI=7
 
 PYTHON_COMPAT=( python3_{6,7} )
 
-inherit python-any-r1
+inherit autotools python-any-r1
 
 DESCRIPTION="A fast and low-memory footprint OCI Container Runtime fully written in C"
 HOMEPAGE="https://github.com/containers/crun"
 SRC_URI="https://github.com/containers/${PN}/releases/download/${PV}/${P}.tar.gz"
 
-LICENSE="GPL-3 LGPL-3+"
+LICENSE="GPL-2+ LGPL-2.1+"
 SLOT="0"
 KEYWORDS="~amd64"
 IUSE="bpf +caps doc seccomp systemd static-libs"
 
 DEPEND="
 	dev-libs/yajl
-	sys-libs/libseccomp
 	caps? ( sys-libs/libcap )
 	seccomp? ( sys-libs/libseccomp )
 	systemd? ( sys-apps/systemd:= )
@@ -30,14 +29,26 @@ BDEPEND="
 "
 
 # the crun test suite is comprehensive to the extent that tests will fail
-# within a sandbox environment, due to the nature of the priveledges
-# required to create linux "containers."
+# within a sandbox environment, due to the nature of the privileges
+# required to create linux "containers".
 RESTRICT="test"
 
 DOCS=README.md
 
+
+PATCHES=(
+	# see https://709982.bugs.gentoo.org/attachment.cgi?id=614208
+	"${FILESDIR}/libocispec-deduplicate-json_common-in-makefile-am.patch"
+)
+
+src_prepare() {
+	default
+	eautoreconf
+}
+
 src_configure() {
 	econf \
+		--disable-criu \
 		$(use_enable bpf) \
 		$(use_enable caps) \
 		$(use_enable seccomp) \
@@ -46,27 +57,18 @@ src_configure() {
 }
 
 src_compile() {
-	pushd libocispec || die
-	emake
-	popd || die
+	emake -C libocispec
 	emake crun
 	if use doc ; then
-		emake crun.1
+		emake generate-man
 	fi
 }
 
 src_install() {
-	pushd libocispec || die
-	emake "DESTDIR=${D}" install-exec
-	popd || die
 	emake "DESTDIR=${D}" install-exec
 	if use doc ; then
 		emake "DESTDIR=${D}" install-man
 	fi
 
-	# there is currently a bug in upstream autotooling that continues to build static libraries despite
-	# explicit configure options
-	use static-libs || find "${ED}"/usr -name '*.la' -delete
-
 	einstalldocs
 }
diff --git a/app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch b/app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch
new file mode 100644
index 000000000..7d188abf8
--- /dev/null
+++ b/app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch
@@ -0,0 +1,31 @@
+From 9d58891c058efa55c7b95cb90597d4cadc5c66d8 Mon Sep 17 00:00:00 2001
+From: Bruce Guenter <bruce@untroubled.org>
+Date: Mon, 17 Feb 2020 13:54:14 -0600
+Subject: [PATCH] De-duplicate json_common in Makefile.am
+
+The source file src/json_common.c is listed twice in Makefile.am,
+leading libtool to produce an archive with duplicated symbols. This
+change removes the duplicate source.
+
+This was introduced in commit 2e318803a2c49521ea448e3ae010b1564a7e95ed
+
+Signed-off-by: Bruce Guenter <bruce@untroubled.org>
+---
+ Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 65bed45..c7ede83 100644
+--- a/libocispec/Makefile.am
++++ b/libocispec/Makefile.am
+@@ -7,7 +7,7 @@ GITIGNOREFILES = build-aux/ gtk-doc.make config.h.in aclocal.m4
+ noinst_LTLIBRARIES = libocispec.la
+ noinst_LIBRARIES = libocispec.a
+
+-SOURCE_FILES = src/json_common.c \
++SOURCE_FILES = \
+ 	src/image_spec_schema_config_schema.c \
+ 	src/image_spec_schema_content_descriptor.c \
+ 	src/image_spec_schema_defs.c \
+--
+2.24.1
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-06-06  7:57 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-13 17:12 [gentoo-proxy-maint] [PATCH 1/2] app-emulation/crun: bump to 0.13 Robert Günzler
2020-05-13 17:12 ` [gentoo-proxy-maint] [PATCH 2/2] app-emulation/crun: new maintainer Robert Günzler
2020-05-15 13:25 ` [gentoo-proxy-maint] [PATCH 1/2] app-emulation/crun: bump to 0.13 Joonas Niilola
2020-05-19 11:45   ` [gentoo-proxy-maint] [PATCH v2 1/3] app-emulation/crun: Bump " Robert Günzler
2020-05-19 11:45     ` [gentoo-proxy-maint] [PATCH v2 2/3] app-emulation/crun: Remove 0.10.6 Robert Günzler
2020-05-19 11:45     ` [gentoo-proxy-maint] [PATCH v2 3/3] app-emulation/crun: new maintainer Robert Günzler
2020-06-02 10:59     ` [gentoo-proxy-maint] [PATCH v2 1/3] app-emulation/crun: Bump to 0.13 Joonas Niilola
2020-06-02 11:19       ` Michał Górny
2020-06-03 23:36       ` Robert Günzler
2020-06-06  7:57         ` Joonas Niilola

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox