[gentoo-proxy-maint] [PATCH 1/2] app-emulation/crun: bump to 0.13

[gentoo-proxy-maint] [PATCH 1/2] app-emulation/crun: bump to 0.13

[Robert Günzler]

From: Robert Günzler <r@gnzler.io>

Closes: https://bugs.gentoo.org/709982
Signed-off-by: Robert Günzler <r@gnzler.io>
---
 app-emulation/crun/Manifest                   |  2 +-
 .../{crun-0.10.6.ebuild => crun-0.13.ebuild}  | 34 ++++++++++---------
 ...duplicate-json_common-in-makefile-am.patch | 31 +++++++++++++++++
 3 files changed, 50 insertions(+), 17 deletions(-)
 rename app-emulation/crun/{crun-0.10.6.ebuild => crun-0.13.ebuild} (69%)
 create mode 100644 app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch

diff --git a/app-emulation/crun/Manifest b/app-emulation/crun/Manifest
index 1652b2325..24ebd99e1 100644
--- a/app-emulation/crun/Manifest
+++ b/app-emulation/crun/Manifest
@@ -1 +1 @@
-DIST crun-0.10.6.tar.gz 1242736 BLAKE2B 840699c6a07ddaef3f6ab4ce226fa6c4ebf0e32641012b6467a2a622d575a48286555b84140d5a1c947b5ef00a691045b0618533fb246bfb6d605baa262febe4 SHA512 b7db09d0c7d2d6e8b1ea239ead5a2ca2b97f188a74f08f0d5ac787e0a698fddf596e7cfdde482c6bc8790d06a7705613e877344a44691c0be7388e6d046c4b15
+DIST crun-0.13.tar.gz 1305048 BLAKE2B fbffabf4cfc744522147b47c5e2bf2bc48e074866108ec4ec8ab94e7ebdc39451851696fabde268b5853e1c3fafb0ac93527e08fdb766acebdd7cf952a9e1a9e SHA512 314612eaf3097160e9369b3400ac8a83e173ef1a53295191c925e96212ba00d032883db1e4615b8ba42ddb08f1e31ca5e5088ea583a469835ac3c27087a88d6e
diff --git a/app-emulation/crun/crun-0.10.6.ebuild b/app-emulation/crun/crun-0.13.ebuild
similarity index 69%
rename from app-emulation/crun/crun-0.10.6.ebuild
rename to app-emulation/crun/crun-0.13.ebuild
index a644095e8..7b7d5fcda 100644
--- a/app-emulation/crun/crun-0.10.6.ebuild
+++ b/app-emulation/crun/crun-0.13.ebuild
@@ -5,20 +5,19 @@ EAPI=7
 
 PYTHON_COMPAT=( python3_{6,7} )
 
-inherit python-any-r1
+inherit autotools python-any-r1
 
 DESCRIPTION="A fast and low-memory footprint OCI Container Runtime fully written in C"
 HOMEPAGE="https://github.com/containers/crun"
 SRC_URI="https://github.com/containers/${PN}/releases/download/${PV}/${P}.tar.gz"
 
-LICENSE="GPL-3 LGPL-3+"
+LICENSE="GPL-2+ LGPL-2.1+"
 SLOT="0"
 KEYWORDS="~amd64"
 IUSE="bpf +caps doc seccomp systemd static-libs"
 
 DEPEND="
 	dev-libs/yajl
-	sys-libs/libseccomp
 	caps? ( sys-libs/libcap )
 	seccomp? ( sys-libs/libseccomp )
 	systemd? ( sys-apps/systemd:= )
@@ -30,14 +29,26 @@ BDEPEND="
 "
 
 # the crun test suite is comprehensive to the extent that tests will fail
-# within a sandbox environment, due to the nature of the priveledges
-# required to create linux "containers."
+# within a sandbox environment, due to the nature of the privileges
+# required to create linux "containers".
 RESTRICT="test"
 
 DOCS=README.md
 
+
+PATCHES=(
+	# see https://709982.bugs.gentoo.org/attachment.cgi?id=614208
+	"${FILESDIR}/libocispec-deduplicate-json_common-in-makefile-am.patch"
+)
+
+src_prepare() {
+	default
+	eautoreconf
+}
+
 src_configure() {
 	econf \
+		--disable-criu \
 		$(use_enable bpf) \
 		$(use_enable caps) \
 		$(use_enable seccomp) \
@@ -46,27 +57,18 @@ src_configure() {
 }
 
 src_compile() {
-	pushd libocispec || die
-	emake
-	popd || die
+	emake -C libocispec
 	emake crun
 	if use doc ; then
-		emake crun.1
+		emake generate-man
 	fi
 }
 
 src_install() {
-	pushd libocispec || die
-	emake "DESTDIR=${D}" install-exec
-	popd || die
 	emake "DESTDIR=${D}" install-exec
 	if use doc ; then
 		emake "DESTDIR=${D}" install-man
 	fi
 
-	# there is currently a bug in upstream autotooling that continues to build static libraries despite
-	# explicit configure options
-	use static-libs || find "${ED}"/usr -name '*.la' -delete
-
 	einstalldocs
 }
diff --git a/app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch b/app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch
new file mode 100644
index 000000000..7d188abf8
--- /dev/null
+++ b/app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch
@@ -0,0 +1,31 @@
+From 9d58891c058efa55c7b95cb90597d4cadc5c66d8 Mon Sep 17 00:00:00 2001
+From: Bruce Guenter <bruce@untroubled.org>
+Date: Mon, 17 Feb 2020 13:54:14 -0600
+Subject: [PATCH] De-duplicate json_common in Makefile.am
+
+The source file src/json_common.c is listed twice in Makefile.am,
+leading libtool to produce an archive with duplicated symbols. This
+change removes the duplicate source.
+
+This was introduced in commit 2e318803a2c49521ea448e3ae010b1564a7e95ed
+
+Signed-off-by: Bruce Guenter <bruce@untroubled.org>
+---
+ Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 65bed45..c7ede83 100644
+--- a/libocispec/Makefile.am
++++ b/libocispec/Makefile.am
+@@ -7,7 +7,7 @@ GITIGNOREFILES = build-aux/ gtk-doc.make config.h.in aclocal.m4
+ noinst_LTLIBRARIES = libocispec.la
+ noinst_LIBRARIES = libocispec.a
+
+-SOURCE_FILES = src/json_common.c \
++SOURCE_FILES = \
+ 	src/image_spec_schema_config_schema.c \
+ 	src/image_spec_schema_content_descriptor.c \
+ 	src/image_spec_schema_defs.c \
+--
+2.24.1
-- 
2.26.2

[gentoo-proxy-maint] [PATCH 2/2] app-emulation/crun: new maintainer

[Robert Günzler]

From: Robert Günzler <r@gnzler.io>

Signed-off-by: Robert Günzler <r@gnzler.io>
---
 app-emulation/crun/metadata.xml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/app-emulation/crun/metadata.xml b/app-emulation/crun/metadata.xml
index 53609eb7d..4564ac525 100644
--- a/app-emulation/crun/metadata.xml
+++ b/app-emulation/crun/metadata.xml
@@ -1,7 +1,13 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
 <pkgmetadata>
-	<!-- maintainer-needed -->
+	<maintainer type="project">
+		<email>proxy-maint@gentoo.org</email>
+		<name>Proxy Maintainers</name>
+	</maintainer>
+	<maintainer type="person">
+		<email>robert@gnzler.io</email>
+	</maintainer>
 	<longdescription lang="en">
 		While most of the tools used in the Linux containers ecosystem are written in
 		Go, crun authors believe C is a better fit for a lower level tool like a
-- 
2.26.2

Re: [gentoo-proxy-maint] [PATCH 1/2] app-emulation/crun: bump to 0.13

[Joonas Niilola]

[-- Attachment #1.1: Type: text/plain, Size: 444 bytes --]


On 5/13/20 8:12 PM, Robert Günzler wrote:
> From: Robert Günzler <r@gnzler.io>
>
> Closes: https://bugs.gentoo.org/709982
> Signed-off-by: Robert Günzler <r@gnzler.io>
> ---
>  app-emulation/crun/Manifest                   |  2 +-
>  .../{crun-0.10.6.ebuild => crun-0.13.ebuild}  | 34 ++++++++++---------

Please split this into two separate commits. One for adding a new file
and one for removing an old one.

-- juippis



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 642 bytes --]

[gentoo-proxy-maint] [PATCH v2 1/3] app-emulation/crun: Bump to 0.13

[Robert Günzler]

From: Robert Günzler <r@gnzler.io>

Closes: https://bugs.gentoo.org/709982
Signed-off-by: Robert Günzler <r@gnzler.io>
---
Splits the removal of the old package and adding of the new one into
separate commits

 app-emulation/crun/Manifest                   |  1 +
 app-emulation/crun/crun-0.13.ebuild           | 74 +++++++++++++++++++
 ...duplicate-json_common-in-makefile-am.patch | 31 ++++++++
 3 files changed, 106 insertions(+)
 create mode 100644 app-emulation/crun/crun-0.13.ebuild
 create mode 100644 app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch

diff --git a/app-emulation/crun/Manifest b/app-emulation/crun/Manifest
index 1652b2325..56e3366c8 100644
--- a/app-emulation/crun/Manifest
+++ b/app-emulation/crun/Manifest
@@ -1 +1,2 @@
+DIST crun-0.13.tar.gz 1305048 BLAKE2B fbffabf4cfc744522147b47c5e2bf2bc48e074866108ec4ec8ab94e7ebdc39451851696fabde268b5853e1c3fafb0ac93527e08fdb766acebdd7cf952a9e1a9e SHA512 314612eaf3097160e9369b3400ac8a83e173ef1a53295191c925e96212ba00d032883db1e4615b8ba42ddb08f1e31ca5e5088ea583a469835ac3c27087a88d6e
 DIST crun-0.10.6.tar.gz 1242736 BLAKE2B 840699c6a07ddaef3f6ab4ce226fa6c4ebf0e32641012b6467a2a622d575a48286555b84140d5a1c947b5ef00a691045b0618533fb246bfb6d605baa262febe4 SHA512 b7db09d0c7d2d6e8b1ea239ead5a2ca2b97f188a74f08f0d5ac787e0a698fddf596e7cfdde482c6bc8790d06a7705613e877344a44691c0be7388e6d046c4b15
diff --git a/app-emulation/crun/crun-0.13.ebuild b/app-emulation/crun/crun-0.13.ebuild
new file mode 100644
index 000000000..7b7d5fcda
--- /dev/null
+++ b/app-emulation/crun/crun-0.13.ebuild
@@ -0,0 +1,74 @@
+# Copyright 2019-2020 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=7
+
+PYTHON_COMPAT=( python3_{6,7} )
+
+inherit autotools python-any-r1
+
+DESCRIPTION="A fast and low-memory footprint OCI Container Runtime fully written in C"
+HOMEPAGE="https://github.com/containers/crun"
+SRC_URI="https://github.com/containers/${PN}/releases/download/${PV}/${P}.tar.gz"
+
+LICENSE="GPL-2+ LGPL-2.1+"
+SLOT="0"
+KEYWORDS="~amd64"
+IUSE="bpf +caps doc seccomp systemd static-libs"
+
+DEPEND="
+	dev-libs/yajl
+	caps? ( sys-libs/libcap )
+	seccomp? ( sys-libs/libseccomp )
+	systemd? ( sys-apps/systemd:= )
+"
+RDEPEND="${DEPEND}"
+BDEPEND="
+	${PYTHON_DEPS}
+	doc? ( dev-go/go-md2man )
+"
+
+# the crun test suite is comprehensive to the extent that tests will fail
+# within a sandbox environment, due to the nature of the privileges
+# required to create linux "containers".
+RESTRICT="test"
+
+DOCS=README.md
+
+
+PATCHES=(
+	# see https://709982.bugs.gentoo.org/attachment.cgi?id=614208
+	"${FILESDIR}/libocispec-deduplicate-json_common-in-makefile-am.patch"
+)
+
+src_prepare() {
+	default
+	eautoreconf
+}
+
+src_configure() {
+	econf \
+		--disable-criu \
+		$(use_enable bpf) \
+		$(use_enable caps) \
+		$(use_enable seccomp) \
+		$(use_enable systemd) \
+		$(usex static-libs '--enabled-shared  --enabled-static' '--enable-shared --disable-static' '' '')
+}
+
+src_compile() {
+	emake -C libocispec
+	emake crun
+	if use doc ; then
+		emake generate-man
+	fi
+}
+
+src_install() {
+	emake "DESTDIR=${D}" install-exec
+	if use doc ; then
+		emake "DESTDIR=${D}" install-man
+	fi
+
+	einstalldocs
+}
diff --git a/app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch b/app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch
new file mode 100644
index 000000000..7d188abf8
--- /dev/null
+++ b/app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch
@@ -0,0 +1,31 @@
+From 9d58891c058efa55c7b95cb90597d4cadc5c66d8 Mon Sep 17 00:00:00 2001
+From: Bruce Guenter <bruce@untroubled.org>
+Date: Mon, 17 Feb 2020 13:54:14 -0600
+Subject: [PATCH] De-duplicate json_common in Makefile.am
+
+The source file src/json_common.c is listed twice in Makefile.am,
+leading libtool to produce an archive with duplicated symbols. This
+change removes the duplicate source.
+
+This was introduced in commit 2e318803a2c49521ea448e3ae010b1564a7e95ed
+
+Signed-off-by: Bruce Guenter <bruce@untroubled.org>
+---
+ Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 65bed45..c7ede83 100644
+--- a/libocispec/Makefile.am
++++ b/libocispec/Makefile.am
+@@ -7,7 +7,7 @@ GITIGNOREFILES = build-aux/ gtk-doc.make config.h.in aclocal.m4
+ noinst_LTLIBRARIES = libocispec.la
+ noinst_LIBRARIES = libocispec.a
+
+-SOURCE_FILES = src/json_common.c \
++SOURCE_FILES = \
+ 	src/image_spec_schema_config_schema.c \
+ 	src/image_spec_schema_content_descriptor.c \
+ 	src/image_spec_schema_defs.c \
+--
+2.24.1
-- 
2.26.2

[gentoo-proxy-maint] [PATCH v2 2/3] app-emulation/crun: Remove 0.10.6

[Robert Günzler]

From: Robert Günzler <r@gnzler.io>

Signed-off-by: Robert Günzler <r@gnzler.io>
---
 app-emulation/crun/Manifest           |  1 -
 app-emulation/crun/crun-0.10.6.ebuild | 72 ---------------------------
 2 files changed, 73 deletions(-)
 delete mode 100644 app-emulation/crun/crun-0.10.6.ebuild

diff --git a/app-emulation/crun/Manifest b/app-emulation/crun/Manifest
index 56e3366c8..24ebd99e1 100644
--- a/app-emulation/crun/Manifest
+++ b/app-emulation/crun/Manifest
@@ -1,2 +1 @@
 DIST crun-0.13.tar.gz 1305048 BLAKE2B fbffabf4cfc744522147b47c5e2bf2bc48e074866108ec4ec8ab94e7ebdc39451851696fabde268b5853e1c3fafb0ac93527e08fdb766acebdd7cf952a9e1a9e SHA512 314612eaf3097160e9369b3400ac8a83e173ef1a53295191c925e96212ba00d032883db1e4615b8ba42ddb08f1e31ca5e5088ea583a469835ac3c27087a88d6e
-DIST crun-0.10.6.tar.gz 1242736 BLAKE2B 840699c6a07ddaef3f6ab4ce226fa6c4ebf0e32641012b6467a2a622d575a48286555b84140d5a1c947b5ef00a691045b0618533fb246bfb6d605baa262febe4 SHA512 b7db09d0c7d2d6e8b1ea239ead5a2ca2b97f188a74f08f0d5ac787e0a698fddf596e7cfdde482c6bc8790d06a7705613e877344a44691c0be7388e6d046c4b15
diff --git a/app-emulation/crun/crun-0.10.6.ebuild b/app-emulation/crun/crun-0.10.6.ebuild
deleted file mode 100644
index a644095e8..000000000
--- a/app-emulation/crun/crun-0.10.6.ebuild
+++ /dev/null
@@ -1,72 +0,0 @@
-# Copyright 2019-2020 Gentoo Authors
-# Distributed under the terms of the GNU General Public License v2
-
-EAPI=7
-
-PYTHON_COMPAT=( python3_{6,7} )
-
-inherit python-any-r1
-
-DESCRIPTION="A fast and low-memory footprint OCI Container Runtime fully written in C"
-HOMEPAGE="https://github.com/containers/crun"
-SRC_URI="https://github.com/containers/${PN}/releases/download/${PV}/${P}.tar.gz"
-
-LICENSE="GPL-3 LGPL-3+"
-SLOT="0"
-KEYWORDS="~amd64"
-IUSE="bpf +caps doc seccomp systemd static-libs"
-
-DEPEND="
-	dev-libs/yajl
-	sys-libs/libseccomp
-	caps? ( sys-libs/libcap )
-	seccomp? ( sys-libs/libseccomp )
-	systemd? ( sys-apps/systemd:= )
-"
-RDEPEND="${DEPEND}"
-BDEPEND="
-	${PYTHON_DEPS}
-	doc? ( dev-go/go-md2man )
-"
-
-# the crun test suite is comprehensive to the extent that tests will fail
-# within a sandbox environment, due to the nature of the priveledges
-# required to create linux "containers."
-RESTRICT="test"
-
-DOCS=README.md
-
-src_configure() {
-	econf \
-		$(use_enable bpf) \
-		$(use_enable caps) \
-		$(use_enable seccomp) \
-		$(use_enable systemd) \
-		$(usex static-libs '--enabled-shared  --enabled-static' '--enable-shared --disable-static' '' '')
-}
-
-src_compile() {
-	pushd libocispec || die
-	emake
-	popd || die
-	emake crun
-	if use doc ; then
-		emake crun.1
-	fi
-}
-
-src_install() {
-	pushd libocispec || die
-	emake "DESTDIR=${D}" install-exec
-	popd || die
-	emake "DESTDIR=${D}" install-exec
-	if use doc ; then
-		emake "DESTDIR=${D}" install-man
-	fi
-
-	# there is currently a bug in upstream autotooling that continues to build static libraries despite
-	# explicit configure options
-	use static-libs || find "${ED}"/usr -name '*.la' -delete
-
-	einstalldocs
-}
-- 
2.26.2

[gentoo-proxy-maint] [PATCH v2 3/3] app-emulation/crun: new maintainer

[Robert Günzler]

From: Robert Günzler <r@gnzler.io>

Signed-off-by: Robert Günzler <r@gnzler.io>
---
 app-emulation/crun/metadata.xml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/app-emulation/crun/metadata.xml b/app-emulation/crun/metadata.xml
index 53609eb7d..4564ac525 100644
--- a/app-emulation/crun/metadata.xml
+++ b/app-emulation/crun/metadata.xml
@@ -1,7 +1,13 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
 <pkgmetadata>
-	<!-- maintainer-needed -->
+	<maintainer type="project">
+		<email>proxy-maint@gentoo.org</email>
+		<name>Proxy Maintainers</name>
+	</maintainer>
+	<maintainer type="person">
+		<email>robert@gnzler.io</email>
+	</maintainer>
 	<longdescription lang="en">
 		While most of the tools used in the Linux containers ecosystem are written in
 		Go, crun authors believe C is a better fit for a lower level tool like a
-- 
2.26.2

Re: [gentoo-proxy-maint] [PATCH v2 1/3] app-emulation/crun: Bump to 0.13

[Joonas Niilola]

[-- Attachment #1.1: Type: text/plain, Size: 1379 bytes --]


On 5/19/20 2:45 PM, Robert Günzler wrote:
> From: Robert Günzler <r@gnzler.io>
>
> Closes: https://bugs.gentoo.org/709982
> Signed-off-by: Robert Günzler <r@gnzler.io>
> ---
> Splits the removal of the old package and adding of the new one into
> separate commits
>
>  app-emulation/crun/Manifest                   |  1 +
>  app-emulation/crun/crun-0.13.ebuild           | 74 +++++++++++++++++++
>  ...duplicate-json_common-in-makefile-am.patch | 31 ++++++++
>  3 files changed, 106 insertions(+)
>  create mode 100644 app-emulation/crun/crun-0.13.ebuild
>  create mode 100644 app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch
>
> diff --git a/app-emulation/crun/Manifest b/app-emulation/crun/Manifest
> index 1652b2325..56e3366c8 100644
> --- a/app-emulation/crun/Manifest
> +++ b/app-emulation/crun/Manifest

Thanks, merged 2 first commits.

I didn't put you as a maintainer because I don't want to deal with
continuous e-mail patches. And doesn't look like anyone else is dealing
with them either. So please, if you want to become the maintainer, start
pushing contributions through Github.

I don't know what the situation is with Gitlab, but that should be(come)
another channel to contribute from, if by some principal Github doesn't
work for you.

(https://gitlab.com/gentoo/gentoo)

-- juippis




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 642 bytes --]

Re: [gentoo-proxy-maint] [PATCH v2 1/3] app-emulation/crun: Bump to 0.13

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]

On Tue, 2020-06-02 at 13:59 +0300, Joonas Niilola wrote:
> On 5/19/20 2:45 PM, Robert Günzler wrote:
> > From: Robert Günzler <r@gnzler.io>
> > 
> > Closes: https://bugs.gentoo.org/709982
> > Signed-off-by: Robert Günzler <r@gnzler.io>
> > ---
> > Splits the removal of the old package and adding of the new one into
> > separate commits
> > 
> >  app-emulation/crun/Manifest                   |  1 +
> >  app-emulation/crun/crun-0.13.ebuild           | 74 +++++++++++++++++++
> >  ...duplicate-json_common-in-makefile-am.patch | 31 ++++++++
> >  3 files changed, 106 insertions(+)
> >  create mode 100644 app-emulation/crun/crun-0.13.ebuild
> >  create mode 100644 app-emulation/crun/files/libocispec-deduplicate-json_common-in-makefile-am.patch
> > 
> > diff --git a/app-emulation/crun/Manifest b/app-emulation/crun/Manifest
> > index 1652b2325..56e3366c8 100644
> > --- a/app-emulation/crun/Manifest
> > +++ b/app-emulation/crun/Manifest
> 
> Thanks, merged 2 first commits.
> 
> I didn't put you as a maintainer because I don't want to deal with
> continuous e-mail patches. And doesn't look like anyone else is dealing
> with them either. So please, if you want to become the maintainer, start
> pushing contributions through Github.
> 
> I don't know what the situation is with Gitlab, but that should be(come)
> another channel to contribute from, if by some principal Github doesn't
> work for you.
> 
> (https://gitlab.com/gentoo/gentoo)
> 

Not this GitLab, it's not maintained by anyone in proxy-maint.  If it
all, it will be our own self-hosted instance.  However, so far people
suggest that GitLab's review tooling is inferior to GitHub's.

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]

Re: [gentoo-proxy-maint] [PATCH v2 1/3] app-emulation/crun: Bump to 0.13

[Robert Günzler]

On Tue Jun 2, 2020 at 3:59 PM CEST, Joonas Niilola wrote:
> I didn't put you as a maintainer because I don't want to deal with
> continuous e-mail patches. And doesn't look like anyone else is dealing
> with them either. So please, if you want to become the maintainer, start
> pushing contributions through Github.
>

Sad. But I get it if that's more work for you... github works if that's
the only alternative.

> I don't know what the situation is with Gitlab, but that should be(come)
> another channel to contribute from, if by some principal Github doesn't
> work for you.

Did you take a look at https://sourcehut.org at all? I think the
direction they're going with fusing the email and web-based workflows is
nice: https://sourcehut.org/blog/2019-10-15-whats-cooking-october-2019/

	robert

Re: [gentoo-proxy-maint] [PATCH v2 1/3] app-emulation/crun: Bump to 0.13

[Joonas Niilola]

[-- Attachment #1.1: Type: text/plain, Size: 1523 bytes --]


On 6/4/20 2:36 AM, Robert Günzler wrote:
> Did you take a look at https://sourcehut.org at all? I think the
> direction they're going with fusing the email and web-based workflows is
> nice: https://sourcehut.org/blog/2019-10-15-whats-cooking-october-2019/
>
> 	robert
>
Maybe the paste service comes closest to what I'd be looking for here.
Basically a simple wgettable git-format patch-file.

My workflow example:

1: Open https://github.com/gentoo/gentoo/pull/16029

2: Launch a container with up-to-date ~ stage3,

3: "fullget.sh 16029" (a bash script to download
https://patch-diff.githubusercontent.com/raw/gentoo/gentoo/pull/XXXXXX.patch
and apply it to containers portage tree)(fullget.sh, because there is
another script to cherry-pick commits),

4: pkgcheck scan --commits,

5: depmerge.sh package (emerge -1av --onlydeps --with-test-deps "$@"),

6: testmerge.sh package (emerge -1av with
https://wiki.gentoo.org/wiki/Package_testing#make.conf these settings),

7: If all is good, switch to desktop shell and ::gentoo repo, use "pram
16029" (https://packages.gentoo.org/packages/app-portage/pram)

(I'm looking to automate steps 3-6 with one command)


With e-mail patches, I have to copypaste them manually into container,
and then apply them manually to ::gentoo repo one-by-one. It's not a lot
extra work, but it slows down the process a bit. And reviewing
contribution is a bit tedious compared to Github, especially if there is
a big contribution.

-- juippis



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 642 bytes --]