public inbox for gentoo-project@lists.gentoo.org
 help / color / mirror / Atom feed
From: Michael Jones <gentoo@jonesmz.com>
To: gentoo-project@lists.gentoo.org
Cc: sam@gentoo.org
Subject: Re: [gentoo-project] [RFC] glep-0076: add clarification about the sign-off requirements
Date: Wed, 28 Jul 2021 12:26:29 -0500	[thread overview]
Message-ID: <CABfmKSJ6TWmp5hB4KJKPXFstOpGRi1ZcBSi+QaVMTdqvduwFAQ@mail.gmail.com> (raw)
In-Reply-To: <89597AB4-A82E-4FA4-B9D1-3490D384DB1E@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 2562 bytes --]

On Wed, Jul 28, 2021 at 10:42 AM Sam James <sam@gentoo.org> wrote:

>
>
> > On 28 Jul 2021, at 12:50, Thomas Deutschmann <whissi@gentoo.org> wrote:
> >
> > Hi,
> >
> > this was also my understanding. GLEP 76 applies to everyone -- no
> exception and during discussion we explicit agreed that it's better to
> reject any contribution from individual(s) who cannot do the sign-off for
> whatever reason.
> >
> > Keep in mind: Whoever will proxy such a commit will be 100% responsible
> in the end. For purely self-protection reasons nobody should proxy a commit
> he/she doesn't understand, doesn't know the origin or in general has any
> doubts about. _You_ will be responsible for this because _you_ introduced
> the commit in Gentoo.
>
> Agreed, but s/commit/contribution/?
>
> >
> > That said, an individual who doesn't want to do the sign-off for
> whatever reason could also contribute without getting attribution if
> contributor will find a developer who is willing to do this (=what happens
> for most small proposed bug fixes via b.g.o for example).
> >
> >
>
> Right.
>
> Part of the reason why I'm keen on this proposal is that there's no
> practical difference between accepting a patch on Bugzilla and
> re-committing it under my own name and just merging their PR. I suppose if
> we're clear on guidelines,
> dropping signoffs where people admit their names are fake would be okay,
> but it still feels like extra work for developers when merging PRs.
>
> best,
> sam
>




I've not followed this full discussion, but has the propensity for projects
other than Gentoo to add the git signed-off-by field to commits on behalf
of people been brought up? I've seen that happen in OpenWRT twice, as well
as other random projects.

I can't imagine that using the git signed-off-by field is in any way
legally meaningful unless you're also requiring developers register their
public key with Gentoo, and then sign their commits with their pub/priv
key. You also have to consider that the signed-off-by field is used by
different projects in very different ways, and there's no legal precedent
that I'm aware of that implies that signed-off-by means "I wrote this",
since there are project that use it as "I've approved this".

Anything less than that is just asking for someone to, entirely plausibly,
claim that they were not the person who added the signed-off-by field to
the commit in question, and good luck proving otherwise. Or that they meant
something very different than what Gentoo thinks they did when they added
signed-off-by to their commit.

[-- Attachment #2: Type: text/html, Size: 3235 bytes --]

  reply	other threads:[~2021-07-28 17:26 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28  4:07 [gentoo-project] [RFC] glep-0076: add clarification about the sign-off requirements Joonas Niilola
2021-07-28  4:29 ` Sam James
2021-07-28  9:49   ` Emily Rowlands
2021-07-28  7:14 ` Michał Górny
2021-07-28 10:39   ` Ulrich Mueller
2021-07-28 11:50     ` Thomas Deutschmann
2021-07-28 15:42       ` Sam James
2021-07-28 17:26         ` Michael Jones [this message]
2021-07-28 10:49 ` Andrew Ammerlaan
2021-07-28 11:22   ` Ulrich Mueller
2021-07-28 14:08     ` Marek Szuba
2021-07-28 14:47       ` Ulrich Mueller
2021-07-28 15:03         ` Rich Freeman
2021-07-28 15:08           ` Ulrich Mueller
2021-07-28 15:15             ` Rich Freeman
2021-07-28 15:49               ` Ulrich Mueller
2021-07-29  6:36           ` Joonas Niilola
2021-07-28 15:12         ` Andrew Ammerlaan
2021-07-28 15:14           ` Marek Szuba
2021-07-28 14:33     ` Rich Freeman
2021-07-29  6:39       ` Joonas Niilola
2021-07-29  8:05         ` Ulrich Mueller
2021-07-29  8:31           ` Joonas Niilola
2021-07-29  9:53             ` Ulrich Mueller
2021-07-29 10:30               ` Joonas Niilola
2021-07-29 11:46                 ` Ulrich Mueller
2021-07-28 17:30 ` Alec Warner
2021-07-29  6:28   ` Joonas Niilola
2021-08-05  6:01 ` Anna Vyalkova
2021-08-05  9:43   ` Ulrich Mueller
2021-08-05 11:02     ` Anna Vyalkova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABfmKSJ6TWmp5hB4KJKPXFstOpGRi1ZcBSi+QaVMTdqvduwFAQ@mail.gmail.com \
    --to=gentoo@jonesmz.com \
    --cc=gentoo-project@lists.gentoo.org \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox