public inbox for gentoo-project@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download: 
* [gentoo-project] [RFC] glep-0076: add clarification about the sign-off requirements
@ 2021-07-28  4:07 99% Joonas Niilola
  0 siblings, 0 replies; 1+ results
From: Joonas Niilola @ 2021-07-28  4:07 UTC (permalink / raw
  To: gentoo-project; +Cc: Joonas Niilola

Summary:
Make it clearer that a sign-off to a git commit is only required from
the committer, not from the author. It's only encouraged for the
authors.

Rationale:
1. We're actively rejecting contributions from people who do not wish to
have their real name shown in public, or link it to their Git*
accounts.

2. We have no way of knowing or confirming whether the given name is
"legal". I'd rather not have the sign-off from the author in the first
place than see clearly made up names in there, with a fresh-made Git*
account with no prior activity.

3. Recently we've had a couple of cases where our long-standing
contributors, with ~300 commits in total, reveal they've been using
pseudonyms. I'm sure there are many others. AFAIK all their commits
should then be revoked, and possibly future contributions rejected
due to trust issues?

4. As said, there are already devs committing work from people we
know to have made-up names. And/or there are devs committing patches
without the sign-off to begin with.

5. The infra git-hooks currently only check for a matching sign-off
from the committer anyway.

Final words:
So currently, this GLEP can be interpreted in two different ways: the
sign-off is and isn't required from the author. This does harm
towards contributors who work with devs who do require the sign-off
from the author, and thus the GLEP needs to be updated and enforced
one way or the other. I vote what benefits our contributors, and
therefore us, better.

Signed-off-by: Joonas Niilola <juippis@gentoo.org>
---
 glep-0076.rst | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/glep-0076.rst b/glep-0076.rst
index 4aa5ee5..faa760d 100644
--- a/glep-0076.rst
+++ b/glep-0076.rst
@@ -8,10 +8,11 @@ Author: Richard Freeman <rich0@gentoo.org>,
         Michał Górny <mgorny@gentoo.org>
 Type: Informational
 Status: Active
-Version: 1.1
+Version: 1.2
 Created: 2013-04-23
-Last-Modified: 2018-12-09
-Post-History: 2018-06-10, 2018-06-19, 2018-08-31, 2018-09-26
+Last-Modified: 2021-07-28
+Post-History: 2018-06-10, 2018-06-19, 2018-08-31, 2018-09-26,
+              2021-07-28
 Content-Type: text/x-rst
 ---
 
@@ -138,7 +139,10 @@ the Certificate of Origin by adding ::
 
 to the commit message as a separate line.  The sign-off must contain
 the committer's legal name as a natural person, i.e., the name that
-would appear in a government issued document.
+would appear in a government issued document. It's strongly encouraged
+that the original contribution author also adds their sign-off, to at
+least indicate they are aware of this GLEP. But it's required only
+from the committer.
 
 The following is the current Gentoo Certificate of Origin, revision 1:
 
@@ -301,6 +305,9 @@ iv.  The original point (d) has been transformed into a stand-alone
 v.   The term "open source" has been replaced by "free software"
      throughout.
 
+vi.  Clarify that a sign-off is only strictly required from the
+     committer, not from the author.
+
 The new point was deemed necessary to allow committing license files
 into the Gentoo repository, since those files usually do not permit
 modification.  It has been established that adding a clear provision
-- 
2.31.1



^ permalink raw reply related	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-07-28  4:07 99% [gentoo-project] [RFC] glep-0076: add clarification about the sign-off requirements Joonas Niilola

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox