From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4E3211387FD for ; Mon, 9 Jun 2014 16:43:33 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 77133E08A4; Mon, 9 Jun 2014 16:43:31 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CFAF5E088A for ; Mon, 9 Jun 2014 16:43:30 +0000 (UTC) Received: from [192.168.1.130] (CPE002401f30b73-CM78cd8ec1b205.cpe.net.cable.rogers.com [99.224.181.112]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: axs) by smtp.gentoo.org (Postfix) with ESMTPSA id AC80833FD38 for ; Mon, 9 Jun 2014 16:43:29 +0000 (UTC) Message-ID: <5395E434.9020903@gentoo.org> Date: Mon, 09 Jun 2014 12:43:32 -0400 From: Ian Stakenvicius User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Project discussion list X-BeenThere: gentoo-project@lists.gentoo.org Reply-To: gentoo-project@lists.gentoo.org MIME-Version: 1.0 To: gentoo-project@lists.gentoo.org Subject: Re: [gentoo-project] Re: EAPI6 Features References: <5395C54E.9020802@gentoo.org> <5395D2D9.8090702@gentoo.org> <21397.57209.48487.252718@a1i15.kph.uni-mainz.de> <20140609183127.37705e89@pomiot.lan> In-Reply-To: <20140609183127.37705e89@pomiot.lan> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8bit X-Archives-Salt: 06bde5f9-c0ee-458a-8118-58037d9c5af3 X-Archives-Hash: 8846a21db56fb97c59896058fef30030 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 09/06/14 12:31 PM, Michał Górny wrote: > Dnia 2014-06-09, o godz. 18:23:21 Ulrich Mueller > napisał(a): > >>>>>>> On Mon, 09 Jun 2014, Jonathan Callen wrote: >> >>> Just as a thought, perhaps we might add another phase, named >>> like "src_postpatch" (open to bikesheding), and have the >>> `eapply_user` called automatically between src_prepare and >>> src_postpatch. Any post-user patch code (like eautoreconf) >>> would then go in src_postpatch. >> >>> Thoughts? >> >> As I said before, I believe that the package manager shouldn't >> perform any magic operations between src_* phases. Calling >> eapply_user like this is effectively an additional phase, so it's >> conceptually cleaner to make it a regular phase function (e.g., >> src_userpatch) which would be called between src_prepare and >> src_postpatch. > > Sounds insanely complex for a minor issue. What's the problem with > ebuilds calling 'default' in src_prepare() to get user patches > applied (and possibly ${PATCHES[@]} as well)? > Again, it's a bit of a special case this it's just 'one' build system, but, what if either a user's patch changes configure.ac , but the ebuild itself hasn't patched configure.ac and so doesn't eautoreconf (or for that matter, doesn't even inherit autotools). The 'default' src_prepare would need to be smart enough to know that the patch is changing build system bits, and either trigger the appropriate prepare commands (eautoreconf or similar) or at least EQAWARN that the patch applied but won't take effect. And technically that eqawarn should only occur if there is no eautoreconf coming up in src_prepare (which could very well happen -after- 'default').. - ----- I read earlier that the proposal is saying that src_prepare() needs to be implemented for every package; it may make sense to include eclass-inherited implementations in this too, since I expect it would be more palatable to i.e. force inherit autotools-utils than to force a handwritten, previously-unneeded src_prepare -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iF4EAREIAAYFAlOV5DQACgkQ2ugaI38ACPD1mAD/StbF40970Sorj2nr9SvBTqwf rnl4spmgkTr26EECMMMA/ijDZEviIJfgUv2j7aeC5mhwAmMIKWz+NnBpQlMZ1jxf =7/2K -----END PGP SIGNATURE-----