Re: [gentoo-project] Re: EAPI6 Features

[Ian Stakenvicius <axs@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 09/06/14 12:31 PM, Michał Górny wrote:
> Dnia 2014-06-09, o godz. 18:23:21 Ulrich Mueller <ulm@gentoo.org>
> napisał(a):
> 
>>>>>>> On Mon, 09 Jun 2014, Jonathan Callen wrote:
>> 
>>> Just as a thought, perhaps we might add another phase, named
>>> like "src_postpatch" (open to bikesheding), and have the
>>> `eapply_user` called automatically between src_prepare and
>>> src_postpatch. Any post-user patch code (like eautoreconf)
>>> would then go in src_postpatch.
>> 
>>> Thoughts?
>> 
>> As I said before, I believe that the package manager shouldn't
>> perform any magic operations between src_* phases. Calling
>> eapply_user like this is effectively an additional phase, so it's
>> conceptually cleaner to make it a regular phase function (e.g.,
>> src_userpatch) which would be called between src_prepare and
>> src_postpatch.
> 
> Sounds insanely complex for a minor issue. What's the problem with 
> ebuilds calling 'default' in src_prepare() to get user patches
> applied (and possibly ${PATCHES[@]} as well)?
> 

Again, it's a bit of a special case this it's just 'one' build system,
but, what if either a user's patch changes configure.ac , but the
ebuild itself hasn't patched configure.ac and so doesn't eautoreconf
(or for that matter, doesn't even inherit autotools).

The 'default' src_prepare would need to be smart enough to know that
the patch is changing build system bits, and either trigger the
appropriate prepare commands (eautoreconf or similar) or at least
EQAWARN that the patch applied but won't take effect.  And technically
that eqawarn should only occur if there is no eautoreconf coming up in
src_prepare (which could very well happen -after- 'default')..

- -----

I read earlier that the proposal is saying that src_prepare() needs to
be implemented for every package; it may make sense to include
eclass-inherited implementations in this too, since I expect it would
be more palatable to i.e. force inherit autotools-utils than to force
a handwritten, previously-unneeded src_prepare


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iF4EAREIAAYFAlOV5DQACgkQ2ugaI38ACPD1mAD/StbF40970Sorj2nr9SvBTqwf
rnl4spmgkTr26EECMMMA/ijDZEviIJfgUv2j7aeC5mhwAmMIKWz+NnBpQlMZ1jxf
=7/2K
-----END PGP SIGNATURE-----