From: Jonathan Callen <jcallen@gentoo.org>
To: gentoo-project@lists.gentoo.org
Subject: [gentoo-project] Re: EAPI6 Features
Date: Mon, 09 Jun 2014 11:29:29 -0400 [thread overview]
Message-ID: <5395D2D9.8090702@gentoo.org> (raw)
In-Reply-To: <5395C54E.9020802@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 06/09/2014 10:31 AM, Ian Stakenvicius wrote:
> On 08/06/14 09:04 AM, Rich Freeman wrote:
>> Most of the proposed EAPI6 features seem ripe for acceptance,
>> but I figured I'd comment on a few here in case others want to
>> weigh in.
>>> b) User patches Bug #475288 [15], PMS wording [16] - Needs 4a)
>>> - Current wording of the spec requires that every ebuild must
>>> include a call to the function in src_prepare, which is
>>> controversial. - Names "apply_user_patches" or "eapply_user"
>>> have been suggested.
>>>
>
>> I'm generally fine with it (we can bikeshed the name to death
>> later), but is there any reason to not just simply apply the
>> patches after src_prepare is done and not make maintainers call
>> it? If we're concerned about sequencing with other activities in
>> src_prepare then that is fine - I don't have a big problem with
>> it being a fatal error if it doesn't get called.
>
>
> General guidelines for epatch_user is that it should be placed
> after all ${S} manipulation but before eautoreconf. Otherwise
> anything that modifies configure.ac won't take effect.
>
> If src_prepare is defined, that would mean it'd have to be put
> right in the middle, still. If it isn't defined, then either an
> eclass would need to handle it as appropriate (i think many do;
> autotools-utils.eclass iirc has some code for this?), or the
> default src_prepare phase function would need to get a -lot- more
> complicated in order to handle patches that touch certain
> build-systems.
>
> Or would we just ban build-system patches from user patches?
>
>
Just as a thought, perhaps we might add another phase, named like
"src_postpatch" (open to bikesheding), and have the `eapply_user`
called automatically between src_prepare and src_postpatch. Any
post-user patch code (like eautoreconf) would then go in src_postpatch.
Thoughts?
- --
Jonathan Callen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBCgAGBQJTldLZAAoJELHSF2kinlg4RqQP/RviMdnLAGRAy60m+qEDWy3C
ZvANn6sIjQtcXU37aX5Li1/7QC+RGqD6w7KLElJpL8D4MSL1ga8ORw5NY4VE+But
XB7n8mpzZZpxU7IHxfZ4gLMmz4OHXDQP34LNmxzVffftU/+H9U0k7WKeNGLL4C1H
ZBB8NkyLwGzlfIDQfCsFoDJCl5ebUi0ecijPVHOucuBwyPMTTJFg92fm8r/5vJ+C
F+N0+LoGzyBX0G9Xp/Ygtd69wALxpqv05g4zRdpAu8WaBZ+2s6SiuBif3DIAFykC
PurzfwSFqIk0rtF2p27W3WFAAXV7Zam1b7Kadw6BnrfZxmHsurgbvTHk5J309Z2S
J+9P5oIH2dTzXhV9Npk0kRHoMPxOQWMeXRQ9f9fAmFgPyLnTzfLBgtAQMIdGba1W
COnIk1Je3lfAv98NGv1hvZNOe8N8NbdSaf2kkfDFtppCVOHvaWVAhBQ0V0rJO92Q
1i9h53XwTxOk6aKkUgOsiW/qgIvx8wgLuVKOJd5ADR/4FHvlJbjlI5b+K+eV07Vv
wk/I8FsopEJdCX9r4oCecYRk1OwY5Xz+T8sZhrjQXISxQv38Byn8v+1h81MT/K2K
a0l/BqAplRv7SRkB4hkJq/azK70dgulIFDN/aQiUgjgGxedjyPEMFLN2Sy10va6g
bHYZ+Xwx7/pXIq5kXy9s
=Bhve
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-06-09 15:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 13:04 [gentoo-project] EAPI6 Features Rich Freeman
2014-06-08 14:38 ` Ulrich Mueller
2014-06-08 15:09 ` Rich Freeman
2014-06-08 19:15 ` Pacho Ramos
2014-06-08 20:56 ` Ulrich Mueller
2014-06-09 8:50 ` Pacho Ramos
2014-06-08 21:49 ` Michał Górny
2014-06-08 15:29 ` Jeroen Roovers
2014-06-08 16:56 ` Ulrich Mueller
2014-06-08 17:22 ` Andreas K. Huettel
2014-06-08 17:26 ` Ciaran McCreesh
2014-06-08 17:28 ` Ulrich Mueller
2014-06-08 21:40 ` Michał Górny
2014-06-08 22:58 ` Rich Freeman
2014-06-09 2:57 ` Michał Górny
2014-06-09 10:12 ` Ulrich Mueller
2014-06-09 14:31 ` Ian Stakenvicius
2014-06-09 15:29 ` Jonathan Callen [this message]
2014-06-09 16:23 ` [gentoo-project] " Ulrich Mueller
2014-06-09 16:31 ` Michał Górny
2014-06-09 16:43 ` Ian Stakenvicius
2014-06-09 16:47 ` Ulrich Mueller
2014-06-09 19:20 ` Jeroen Roovers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5395D2D9.8090702@gentoo.org \
--to=jcallen@gentoo.org \
--cc=gentoo-project@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox