From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1SbCKL-0005KE-3Z for garchives@archives.gentoo.org; Sun, 03 Jun 2012 15:02:45 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AEBF2E0587 for ; Sun, 3 Jun 2012 15:02:44 +0000 (UTC) Received: from mail-ey0-f181.google.com (mail-ey0-f181.google.com [209.85.215.181]) by pigeon.gentoo.org (Postfix) with ESMTP id 81068E07D5 for ; Sun, 3 Jun 2012 12:24:52 +0000 (UTC) Received: by eaae12 with SMTP id e12so941423eaa.40 for ; Sun, 03 Jun 2012 05:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=yuJk+cK+yPZ9UqubemiM+IMGgh+l1TGfuCUeIinEzlE=; b=K/BCVYRBQuQ8q1w6MtNI83+LoSQNE8hTPvmVb9Pu/ofPIuiypZtoQZolXA1nGIB0p8 41VdtdwjN2NlQDwN53LrhJCsr1gGPuxf5jWV7h3YpfvF8NbOJlYbUFR6R0N3qXbrdyqX TKatdVUHkhAtKjTvgPad7T4ZwtDQUXoDvoGjLpUMWM+G1kCX5Kt7yZ5i6PnPmU4CKDym 9wAOhO1jfWwOqNJJeUxZq3MUmVWzDiS43GzI/6Gb0JLfScXwdRMMoKrCOo2mNNZWsLMe /15oGN0CTn5CiIf4WFj1fl3e0Dl0EWO4BpCms/S4kw6a/YJ9jWnqK4D1mYH4cI4CLIXW YY0A== Received: by 10.14.188.130 with SMTP id a2mr3829288een.86.1338726286473; Sun, 03 Jun 2012 05:24:46 -0700 (PDT) Received: from [192.168.1.72] (93-97-149-234.zone5.bethere.co.uk. [93.97.149.234]) by mx.google.com with ESMTPS id u7sm26240519eeb.7.2012.06.03.05.24.45 (version=SSLv3 cipher=OTHER); Sun, 03 Jun 2012 05:24:45 -0700 (PDT) Sender: Markos Chandras Message-ID: <4FCB578B.8010606@gentoo.org> Date: Sun, 03 Jun 2012 13:24:43 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120602 Thunderbird/12.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Project discussion list X-BeenThere: gentoo-project@lists.gentoo.org Reply-To: gentoo-project@lists.gentoo.org MIME-Version: 1.0 To: gentoo-project@lists.gentoo.org Subject: Re: [gentoo-project] Re: Call for agenda items -- Council meeting 2012-06-12 References: <4FCAA2F3.1070309@gentoo.org> <20426.43332.37753.819773@a1i15.kph.uni-mainz.de> <4FCAD7F3.9010101@gentoo.org> <4FCAD95A.9010903@gentoo.org> <4FCB1DC1.60704@gentoo.org> <4FCB31EE.3030709@gentoo.org> In-Reply-To: <4FCB31EE.3030709@gentoo.org> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: 25c81c91-0088-46ba-bbaf-b79910735dae X-Archives-Hash: 174d39be4fee739d8468725c80dc1326 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 06/03/2012 10:44 AM, Samuli Suominen wrote: > On 06/03/2012 11:18 AM, Markos Chandras wrote: >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 >> >> On 06/03/2012 04:26 AM, Samuli Suominen wrote: >>> On 06/03/2012 06:20 AM, Samuli Suominen wrote: >>>> On 06/03/2012 03:01 AM, Ulrich Mueller wrote: >>>>>>>>>> On Sun, 03 Jun 2012, Samuli Suominen wrote: >>>>> >>>>>>> On 05/29/2012 10:09 AM, Fabian Groffen wrote: >>>>>> http://archives.gentoo.org/gentoo-dev/msg_920c6d6daafe7702bfa3b8a2bc21e0c1.xml >>>>>> >>>>>> >>>>>> >>>>> >>>>>>> >>>>>> >> >>>>>> Can you indicate what the council has to vote on/decide for this one? >>>>> >>>>>> EAPI=5 >>>>> >>>>>> optional: "$@" placement in default for src_configure() >>>>> >>>>>> econf "$@" >>>>> >>>>>> optional: "$@" placement in default for src_compile() >>>>> >>>>>> emake "$@" >>>>> >>>>> I still don't see the point of it. econf or emake could >>>>> just be called directly. We won't gain anything by allowing >>>>> arguments, but only complicate things. >>>>> >>>>>> this one is what I'm really after for: >>>>> >>>>>> default for src_install() in EAPI=5 should accept "$@" >>>>>> in correct place to avoid usage of EXTRA_EMAKE within >>>>>> ebuilds/eclasses and to avoid duplicating the Portage >>>>>> code for DOCS. NOTE: When this was last voted on for >>>>>> EAPI=3, we didn't have this DOCS handling, and this >>>>>> wasn't important yet. >>>>> >>>>>> emake DESTDIR="${D}" "$@" install >>>>> >>>>> Again, this could be called directly, which has the >>>>> advantage that it makes it obvious that src_install isn't >>>>> the default. >>>> >>>> The difference is working the tree when you have to alter >>>> ebuilds which have been written like: >>>> >>>> DOCS=( AUTHORS README.NOW "${FILESDIR}"/README.Gentoo ) >>>> >>>> src_install() { default >>>> >>>> echo "Some command here." } >>>> >>>> At this point you have to move content of DOCS which may or >>>> may not rely on the ""quoting with array"". Remove the call >>>> to default. And then duplicate the EAPI=4 default into the >>>> ebuild. >>>> >>>> And then replicate that every month dozen times and keep on >>>> doing it for some months. Get frustrated. >>>> >>>> If that's not enough, then you get all excited about EAPI=4 >>>> and finally think you have a replacement for base.eclass to >>>> port xfconf.eclass away from the thing when you only used it >>>> for default src_install() to avoid code duplication... >>>> >>>> Think you are all done, and then get complainment that >>>> support for extra arguments for xfconf_src_install was >>>> killed, and was required for things like: >>>> >>>> xfconf_src_install htmldirectory=/usr/share/doc/${PF}/html >>>> imagesdir=/usr/share/doc/${PF}/html/images >>>> >>>> Where sedding the build system runs maintainer mode at .in >>>> level, and runnning autotools (.am level) requires heavy >>>> documentation dependencies. You go back to base.eclass and >>>> get frustrated more. >>>> >>>> I hope that clears things up ;-) >>>> >>> >>> Also, if not implemented, what is the replacement for >>> EXTRA_EMAKE which we are allowed to use from ebuilds? Or are we >>> allowed to use it? I think PMS didn't forbid it the last time I >>> checked and it has consumers in tree already. >>> >>> And if not implemented, would the council please vote on >>> banning the usage of `default` in src_install() directly from >>> ebuilds? The syntax back and forth converting MUST stop. >>> >>> - Samuli >>> >> What is the problem with "default" in src_install? > > Did you not read the mail at all? The lack of support for > arguments makes it useless, and even harmful/annoying when you have > to convert them constantly around the tree > > -Samuli > You don't have to be offensive. Of course I've read it. My point is that if you use "default" in src_install, you need the default function for that EAPI. If you want to override it then implement your own email install line. I just don't understand why you want us to ban it. Personally I find it useful to call "default" from src_install. - -- Regards, Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBCgAGBQJPy1eLAAoJEPqDWhW0r/LCHW8P/iJIY1I+s8Tn1qEcFj6ZUbXI /QI7XPyDbaZMcr3XwoaYuxrj7QLx3XUipnutcSfZP9hLlLsVmYOf2OtBwJZyRpdr wnxNXFh7yFkJncFjLIldvJ1be8eLaZmA+PnkzqIHc+mX+BpyP48ISF1CFQAwLAP5 llMGHV3DZ7C0Fw4p3qDsyohnL1wwNyC5e3Mq/rfuurddn0bN4aKwyKjVY5SBrt/+ xQQoXvTN/up8BcEllLEXGBmgp7aHVxUQR6guW4Q+j7sab6Lxn4HRzakwEYVeBB9K PAe8V9OGRCXCZhVUUp8rNob8rJy2HRLT95yfV3qHYAsPDXxpiGMObafMR8bPhLiu 0Uq+4ODBJW49cTlpCv/jQ+ztHuM1aeZgy6kDurDpgGH+VeTZiG5bk7wVUdzsPZcx g5GmYHLxBTT3sQ3ynntezTRLNg62UgfLdItIMe2INfNgf4FC6hlNgo53irNR+RrK S8u11r9bLGmp84GbBPxJvhpbpcjS7lJfCgPQAVR8ZrV5NrgYiiCSd7Vl30l39iUR Ltn/5A7DxlN0ua5X1sDp37Y0VPUoAtiL99hzFELCoRKV891zDlcDPhOajiBBDM+V JHKsmT8ckIsjbCuN5EuSMSHnFDNGvsAoLauMMZXAbmNeNpSZ61VWBI/nipcC32i9 j8arDp1/i9aCctAy9jTC =Dnf1 -----END PGP SIGNATURE-----