Re: [gentoo-project] ChangeLog generation: Edit generated Changelogs

[Markos Chandras <hwoarang@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 09/19/11 17:27, Fabian Groffen wrote:
> On 19-09-2011 16:44:51 +0300, Markos Chandras wrote:
>> On 09/19/11 16:26, Fabian Groffen wrote:
>>> I would prefer going this route myself.  Generate all
>>> ChangeLogs from commit messages only.  This is easy to
>>> implement (POC is running for Prefix), but has a little issue
>>> with ChangeLog being in Manifest file. I think we should just
>>> omit it, or (better) allow the Manifest to have multiple signed
>>> parts, such that the ebuilds, dists and files are signed by the
>>> committing developer, and the ChangeLog is signed by the
>>> generation process (like snapshots are).
>> If you generate Changelogs from commit messages then you dont
>> need to place the to $VCS unless you want to edit them ( see
>> below )
> 
> I can't parse/don't understand this sentence.  Could you 
> explain/elaborate?
Yeah it is obvious that I can't type. What I meant was that if we use
the commit logs to generate the ChangeLogs then we can do that on
server side (just before populating the portage tree to rsync
mirrors). In this case we do not need to store the Changelog files on
$VCS.
> 
>>> The council has, however, (like Markos' initial mail
>>> explained) decided that ChangeLog entries must be updatable
>>> (e.g. corrected) afterwards.
>> Really? when? There is no decision on this topic yet[1](3rd
>> bullet point). If I am wrong, please point me to the correct
>> source. I thought this discussion is about whether we want to
>> edit them afterwards or not. So unless we decide to edit them, we
>> don't need ChangeLog files
> 
> Sorry, I recalled the details wrong.  The effect is the same
> though, a file needs to exist:
> 
> [quote from [1]] - Vote: Retroactively change existing entries, yes
> or no. - We will append to changelogs and retain all existing
> changelog messages. [/quote from [1]]
> 

Yes a file is needed but like I said before, this file can be
generated on a post-commit server just before populating portage to
rsync servers

> An additional advantage of keeping the file is that we can easily
> fix all entries that people wrote/committed ugly and helpless
> messages for, like "^" and so on.
> 
In this case you need smart filtering tools to avoid duplicate
messages ( one from $commit_message and the one you wrote yourself to
fix that message ). However, this will be the case if we decide to
allow edits on ChangeLogs.

- -- 
Regards,
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)

iQIcBAEBCgAGBQJOd22rAAoJEPqDWhW0r/LC8iYP/3rbJ0SaHFL8FWnOBeVP2AUH
WmtCJnJxoMaiktLVTQHFflFJb28MYKKC9Gytox3pubGdvOO2/8cqNIjR/qT+G+xj
pOrp71ikgOmJwjkuN6UtcuqCFNpwLpWnOt1i9FZ/tlJeY3ihFPpMLA+768QKgUDf
c3qtchSQR4By/sVEp+0WYQcybFSOez7HMtpxzrT2mwBMK2nE5AfrqczsuXnbdVi4
8Q+VQKdM6PGaawrDUb7yz6Jx+jyIhfmJc/xun/cPa0xXUpSN3LuBnLDpW6JOJNFo
UfFNylmxTCJevf5R5oGSC80TEhGbm7Dit/SWRmo/dzut67uXDTqBr4nTDY0KmAZu
wJdiNuWA4UThWk7F/86DRooRH5xyqxoLFcEphrgq9mR+uQDv5W7OAwn0YqVZoQCS
wY3YeAVHPFnKU965/QTwJz/K7vOYVvkRahkP1yRFMv7bYGmpdYzewa0ycN/sYIuC
vC4wwkEhhOBr+ymdozka46gc2ucXpL6YyfJADZuvQQW6f/zcqjWJN0nDwaN8jRf2
ULY+HzfOOSKmGUsi7JY5tHJnneB9TkzOTao0oz2w5M/OGTqJfIHGOhXGtgjTBOf4
yjzPytdkVmq7A3P8A0CnZicdFv+6UfEYFSeXgX4MPrDE0FaZFx9T80RCljn71rXx
YTGqLdK/OxXJ1kRnkGea
=08+b
-----END PGP SIGNATURE-----