From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4FF801387FD for ; Mon, 9 Jun 2014 16:47:41 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B30AFE088A; Mon, 9 Jun 2014 16:47:39 +0000 (UTC) Received: from a1www.kph.uni-mainz.de (a1www.kph.uni-mainz.de [134.93.134.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E60F4E0882 for ; Mon, 9 Jun 2014 16:47:38 +0000 (UTC) Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1www.kph.uni-mainz.de (8.14.7/8.14.7) with ESMTP id s59GlXem004632; Mon, 9 Jun 2014 18:47:33 +0200 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.8/8.14.2) with ESMTP id s59GlWll000802; Mon, 9 Jun 2014 18:47:32 +0200 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.8/8.14.8/Submit) id s59GlWFk000798; Mon, 9 Jun 2014 18:47:32 +0200 Message-ID: <21397.58660.582111.76486@a1i15.kph.uni-mainz.de> Date: Mon, 9 Jun 2014 18:47:32 +0200 To: =?iso-8859-2?Q?Micha=B3_G=F3rny?= Cc: gentoo-project@lists.gentoo.org Subject: Re: [gentoo-project] Re: EAPI6 Features In-Reply-To: <20140609183127.37705e89@pomiot.lan> References: <5395C54E.9020802@gentoo.org> <5395D2D9.8090702@gentoo.org> <21397.57209.48487.252718@a1i15.kph.uni-mainz.de> <20140609183127.37705e89@pomiot.lan> X-Mailer: VM 8.2.0b under 24.3.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Project discussion list X-BeenThere: gentoo-project@lists.gentoo.org Reply-To: gentoo-project@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="pgp+signed+dq/txfzgofl/YsT"; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: cb85060c-9b9d-4261-a941-cc7acbb44f60 X-Archives-Hash: 2eb6d3ee8ecdf5cf76b5a4c22c1ffae6 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --pgp+signed+dq/txfzgofl/YsT Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable >>>>> On Mon, 9 Jun 2014, Micha=B3 G=F3rny wrote: > Dnia 2014-06-09, o godz. 18:23:21 > Ulrich Mueller napisa=B3(a): >> As I said before, I believe that the package manager shouldn't >> perform any magic operations between src=5F* phases. Calling >> eapply=5Fuser like this is effectively an additional phase, so it's >> conceptually cleaner to make it a regular phase function (e.g., >> src=5Fuserpatch) which would be called between src=5Fprepare and >> src=5Fpostpatch. > Sounds insanely complex for a minor issue. What's the problem with > ebuilds calling 'default' in src=5Fprepare() to get user patches > applied (and possibly ${PATCHES[@]} as well)=3F Calling it in src=5Fprepare() is perfectly fine with me. The only thing= I'm saying is that we shouldn't call eapply=5Fuser outside of a phase function, whatever that phase function will be. Ulrich --pgp+signed+dq/txfzgofl/YsT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBCAAGBQJTleUaAAoJEMMJBoUcYcJzjdsH/0ddM2laHgjMZ2HJWPLgcpCZ L2ltifZxmm6UMH0s0FjcimbKvhllTL/cEjP3uXZUK54UdFX+9uRlAXlHpUj6PjEm rs+ea3CGDkz8MAFbL4cnC358YpLERfwQKLVIeK6+D3ReUKtuC2e6YMpKmO1JKf4x h/nVEHrMmApDWACIMuAb71s6wXsM/FlIGDuDyeSqpLjQVl3cnSoTlh+sSobF5fUS i+JVbd0ZTsvHe7Gs9i00tC243zqa6Ibw5lYjf09zpzy7gOkZTO7UcLZndQunGlsf KfSQXu57eQmPvni0VHCkWzdVnd0wC2vCFhCfe9SRYSIA0WbN9hCZ2HojkwwG6PE= =yM4W -----END PGP SIGNATURE----- --pgp+signed+dq/txfzgofl/YsT--