public inbox for gentoo-project@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>
Cc: gentoo-project@lists.gentoo.org
Subject: Re: [gentoo-project] Re: EAPI6 Features
Date: Mon, 9 Jun 2014 18:47:32 +0200	[thread overview]
Message-ID: <21397.58660.582111.76486@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <20140609183127.37705e89@pomiot.lan>

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

>>>>> On Mon, 9 Jun 2014, Michał Górny wrote:

> Dnia 2014-06-09, o godz. 18:23:21
> Ulrich Mueller <ulm@gentoo.org> napisał(a):

>> As I said before, I believe that the package manager shouldn't
>> perform any magic operations between src_* phases. Calling
>> eapply_user like this is effectively an additional phase, so it's
>> conceptually cleaner to make it a regular phase function (e.g.,
>> src_userpatch) which would be called between src_prepare and
>> src_postpatch.

> Sounds insanely complex for a minor issue. What's the problem with
> ebuilds calling 'default' in src_prepare() to get user patches
> applied (and possibly ${PATCHES[@]} as well)?

Calling it in src_prepare() is perfectly fine with me. The only thing
I'm saying is that we shouldn't call eapply_user outside of a phase
function, whatever that phase function will be.

Ulrich

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

  parent reply	other threads:[~2014-06-09 16:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-08 13:04 [gentoo-project] EAPI6 Features Rich Freeman
2014-06-08 14:38 ` Ulrich Mueller
2014-06-08 15:09   ` Rich Freeman
2014-06-08 19:15   ` Pacho Ramos
2014-06-08 20:56     ` Ulrich Mueller
2014-06-09  8:50       ` Pacho Ramos
2014-06-08 21:49   ` Michał Górny
2014-06-08 15:29 ` Jeroen Roovers
2014-06-08 16:56   ` Ulrich Mueller
2014-06-08 17:22 ` Andreas K. Huettel
2014-06-08 17:26   ` Ciaran McCreesh
2014-06-08 17:28   ` Ulrich Mueller
2014-06-08 21:40     ` Michał Górny
2014-06-08 22:58       ` Rich Freeman
2014-06-09  2:57         ` Michał Górny
2014-06-09 10:12           ` Ulrich Mueller
2014-06-09 14:31 ` Ian Stakenvicius
2014-06-09 15:29   ` [gentoo-project] " Jonathan Callen
2014-06-09 16:23     ` Ulrich Mueller
2014-06-09 16:31       ` Michał Górny
2014-06-09 16:43         ` Ian Stakenvicius
2014-06-09 16:47         ` Ulrich Mueller [this message]
2014-06-09 19:20         ` Jeroen Roovers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21397.58660.582111.76486@a1i15.kph.uni-mainz.de \
    --to=ulm@gentoo.org \
    --cc=gentoo-project@lists.gentoo.org \
    --cc=mgorny@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox