public inbox for gentoo-project@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-project@lists.gentoo.org
Cc: ulm@gentoo.org
Subject: Re: [gentoo-project] EAPI6 Features
Date: Sun, 8 Jun 2014 23:49:37 +0200	[thread overview]
Message-ID: <20140608234937.223d9c75@pomiot.lan> (raw)
In-Reply-To: <21396.30067.503349.626165@a1i15.kph.uni-mainz.de>

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

Dnia 2014-06-08, o godz. 16:38:43
Ulrich Mueller <ulm@gentoo.org> napisał(a):

> >> d) Source eclasses only once
> >> Bug #422533  
> 
> > Does anybody still want this included?  It seems to me like the list
> > discussion was leading in a different direction, but it isn't 100%
> > clear to me if this is the case.  
> 
> Right, discussion has died down. Many eclasses now use a mechanism
> equivalent to the one in C header files, which seems to do the job.

I specifically did open that bug because eclasses were not using
the same way consistently. More specifically, the 'spank way' usually
involved EXPORT_FUNCTIONS being used inconsistently. As a result,
sometimes phase functions from eclass inherited last weren't actually
effective because the eclass was inherited by another eclass earlier.

Thinking about it right now, I don't think we need anything
EAPI-specific for this. A consistent policy that is respected by all
developers would be enough. I would prefer 'my way' here, that is
guarding all inherits and eclass code except for EXPORT_FUNCTIONS, so
that the repetitive inherit still overrides phase functions.

That is:

  if [[ ! ${_FOO_ECLASS} ]]; then
    inherit bar baz
  fi

  EXPORT_FUNCTIONS src_compile src_install

  if [[ ! ${_FOO_ECLASS} ]]; then
    #...

    _FOO_ECLASS=1
  fi

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

  parent reply	other threads:[~2014-06-08 21:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-08 13:04 [gentoo-project] EAPI6 Features Rich Freeman
2014-06-08 14:38 ` Ulrich Mueller
2014-06-08 15:09   ` Rich Freeman
2014-06-08 19:15   ` Pacho Ramos
2014-06-08 20:56     ` Ulrich Mueller
2014-06-09  8:50       ` Pacho Ramos
2014-06-08 21:49   ` Michał Górny [this message]
2014-06-08 15:29 ` Jeroen Roovers
2014-06-08 16:56   ` Ulrich Mueller
2014-06-08 17:22 ` Andreas K. Huettel
2014-06-08 17:26   ` Ciaran McCreesh
2014-06-08 17:28   ` Ulrich Mueller
2014-06-08 21:40     ` Michał Górny
2014-06-08 22:58       ` Rich Freeman
2014-06-09  2:57         ` Michał Górny
2014-06-09 10:12           ` Ulrich Mueller
2014-06-09 14:31 ` Ian Stakenvicius
2014-06-09 15:29   ` [gentoo-project] " Jonathan Callen
2014-06-09 16:23     ` Ulrich Mueller
2014-06-09 16:31       ` Michał Górny
2014-06-09 16:43         ` Ian Stakenvicius
2014-06-09 16:47         ` Ulrich Mueller
2014-06-09 19:20         ` Jeroen Roovers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140608234937.223d9c75@pomiot.lan \
    --to=mgorny@gentoo.org \
    --cc=gentoo-project@lists.gentoo.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox