From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1R5i2B-00025Y-Cb for garchives@archives.gentoo.org; Mon, 19 Sep 2011 17:53:35 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2591B21C074; Mon, 19 Sep 2011 17:53:24 +0000 (UTC) Received: from amun.cheops.ods.org (amun.cheops.ods.org [83.161.135.166]) by pigeon.gentoo.org (Postfix) with ESMTP id 5E06D21C044 for ; Mon, 19 Sep 2011 17:53:13 +0000 (UTC) Received: from nut.cheops.ods.org ([2001:888:1022:0:ca2a:14ff:fe35:7a00] helo=gentoo.org) by amun.cheops.ods.org with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1R5i1n-0006Af-1q for gentoo-project@lists.gentoo.org; Mon, 19 Sep 2011 19:53:12 +0200 Date: Mon, 19 Sep 2011 19:53:09 +0200 From: Fabian Groffen To: gentoo-project@lists.gentoo.org Subject: Re: [gentoo-project] ChangeLog generation: Edit generated Changelogs Message-ID: <20110919175309.GH1168@gentoo.org> Mail-Followup-To: gentoo-project@lists.gentoo.org References: <20110919132655.GA1168@gentoo.org> <4E774753.7020303@gentoo.org> <20110919142734.GB1168@gentoo.org> <4E776DAC.8020500@gentoo.org> <20110919165152.GD1168@gentoo.org> <4E7774CC.8010906@gentoo.org> <20110919170946.GF1168@gentoo.org> <4E777A2F.3050306@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Project discussion list X-BeenThere: gentoo-project@lists.gentoo.org Reply-To: gentoo-project@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aHyShe78FfJzbeER" Content-Disposition: inline In-Reply-To: <4E777A2F.3050306@gentoo.org> User-Agent: Mutt/1.5.21 (Darwin 11.1.0, VIM - Vi IMproved 7.3) Organization: Gentoo Foundation, Inc. X-Content-Scanned: by amun.cheops.ods.org (Exim Exiscan) using SpamAssassin and ClamAV X-Archives-Salt: X-Archives-Hash: 3b1c753d08f8a12235fd07c3413c5a30 --aHyShe78FfJzbeER Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 19-09-2011 20:21:51 +0300, Markos Chandras wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 >=20 > On 09/19/11 20:09, Fabian Groffen wrote: > >=20 > > $EDITOR ChangeLog && repoman commit -m "added bugref" > >=20 > > (side-note: I don't see the point of your echangelog usage for this > > case) > >=20 > >=20 > Ok pretty much what I said in my previous email. In this case you edit > the ChangeLog but the "added bugref" text will be appended to > Changelog instead of fixing your previous commit message. In my > opinion we have two options here Why? The message will not go to ChangeLog, simply because repoman would not do that, because echangelog doesn't do that as well: [nut:portage/mail-client/mutt] % cvs update cvs update: Updating . cvs update: Updating files [nut:portage/mail-client/mutt] % echangelog "bla" ** ** NOTE: No non-trivial changed files found. Normally echangelog ** should be run after all affected files have been added and/or ** modified. Did you forget to cvs add? ** ** In strict mode, exiting ** If you know what you're doing there pass '--no-strict' to echangelog > 1) Ignore commit messages that only affect ChangeLogs. This requires > the ChangeLog entry to be kept on $VCS cause it is easier we already do that > OR > 2) Remove the head -1 ChangeLog entry and insert the new one. complex for no reason > In both cases, the ChangeLogs need to be on $VCS or put differently, it's the best we can do when it is decided that we need to be able to do things that require a file (like currently already is the case). > The only advantage for having the post-commit server generating the > ChangeLogs is the reduce $VCS size. I can't see any other advantages > whatsoever I think this is non-sense, and only complicates matters. --=20 Fabian Groffen Gentoo on a different level --aHyShe78FfJzbeER Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (Darwin) iEYEARECAAYFAk53gYUACgkQX3X2B8XHTom0RACggLavbQc3Q1KXOVRAbxA2hPDE aAwAn0OdDce9cR88eeaejQ3OosbgEOpi =jgCb -----END PGP SIGNATURE----- --aHyShe78FfJzbeER--