From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1R5dsV-0004Be-Oh for garchives@archives.gentoo.org; Mon, 19 Sep 2011 13:27:20 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 602CA21C071; Mon, 19 Sep 2011 13:27:10 +0000 (UTC) Received: from amun.cheops.ods.org (amun.cheops.ods.org [83.161.135.166]) by pigeon.gentoo.org (Postfix) with ESMTP id 4DFE621C068 for ; Mon, 19 Sep 2011 13:26:59 +0000 (UTC) Received: from nut.cheops.ods.org ([2001:888:1022:0:ca2a:14ff:fe35:7a00] helo=gentoo.org) by amun.cheops.ods.org with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1R5ds9-0004XF-4s for gentoo-project@lists.gentoo.org; Mon, 19 Sep 2011 15:26:58 +0200 Date: Mon, 19 Sep 2011 15:26:55 +0200 From: Fabian Groffen To: gentoo-project@lists.gentoo.org Subject: Re: [gentoo-project] ChangeLog generation: Edit generated Changelogs Message-ID: <20110919132655.GA1168@gentoo.org> Mail-Followup-To: gentoo-project@lists.gentoo.org References: <4E735841.9070209@gentoo.org> <4E73C08B.9030801@gentoo.org> <4E745B01.9040805@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Project discussion list X-BeenThere: gentoo-project@lists.gentoo.org Reply-To: gentoo-project@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cxfMsoqvp1jUizWj" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (Darwin 11.1.0, VIM - Vi IMproved 7.3) Organization: Gentoo Foundation, Inc. X-Content-Scanned: by amun.cheops.ods.org (Exim Exiscan) using SpamAssassin and ClamAV X-Archives-Salt: X-Archives-Hash: 5b3ed6469cac0d42f4a599bd4f69c141 --cxfMsoqvp1jUizWj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 17-09-2011 10:01:47 -0400, Rich Freeman wrote: > On Sat, Sep 17, 2011 at 5:07 AM, Nirbheek Chauhan <[1]nirbheek@gentoo.org> > wrote: >=20 > I agree. Plus, if we use git-notes to *append* to ChangeLog entries > (in case you left out important information), we've covered all bases > as far as I'm concerned. >=20 > If something is REALLY critical that needs to be fixed you can always use= a > hack like adding a line of whitespace or something and re-committing (whi= ch > will work with any scm), but I'd only reserve that for when a changelog > entry is so factually wrong that it risks a real problem. =C2=A0=C2=A0 >=20 > However, I'd really question whether ChangeLogs are the place to store su= ch > a critical piece of documentation in the first place. =C2=A0If it is THAT > important that users know about a change it should be in news. >=20 > I agree that it seems like we're at the point where "just a little better" > is becoming the enemy of "already way better than what we have." I would prefer going this route myself. Generate all ChangeLogs from commit messages only. This is easy to implement (POC is running for Prefix), but has a little issue with ChangeLog being in Manifest file. I think we should just omit it, or (better) allow the Manifest to have multiple signed parts, such that the ebuilds, dists and files are signed by the committing developer, and the ChangeLog is signed by the generation process (like snapshots are). The council has, however, (like Markos' initial mail explained) decided that ChangeLog entries must be updatable (e.g. corrected) afterwards. That makes a (ChangeLog) file IMO necessary, and hence nothing can be done different from making repoman update the ChangeLog itself upon commit one way or another. This isn't really new, it's bug #337853. Note that the latter approach also solves any problems of entry order, as are forseen when using a VCS like git. [1] https://bugs.gentoo.org/show_bug.cgi?id=3D337853 --=20 Fabian Groffen Gentoo on a different level --cxfMsoqvp1jUizWj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (Darwin) iEYEARECAAYFAk53Qx8ACgkQX3X2B8XHTomgsACePDoAe149daYkIE4vPgOOgLCM ZxsAnRQ+rxkiEtjR9tkYaCl3q7zhNJmt =9rpF -----END PGP SIGNATURE----- --cxfMsoqvp1jUizWj--