From: Fabian Groffen <grobian@gentoo.org>
To: gentoo-project@lists.gentoo.org
Subject: Re: [gentoo-project] ChangeLog generation: Edit generated Changelogs
Date: Mon, 19 Sep 2011 15:26:55 +0200 [thread overview]
Message-ID: <20110919132655.GA1168@gentoo.org> (raw)
In-Reply-To: <CAGfcS_nGs6eVFS0N-vbS__-_dKBRcJFWR=ecC5Wk-_0W2=bFnA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2039 bytes --]
On 17-09-2011 10:01:47 -0400, Rich Freeman wrote:
> On Sat, Sep 17, 2011 at 5:07 AM, Nirbheek Chauhan <[1]nirbheek@gentoo.org>
> wrote:
>
> I agree. Plus, if we use git-notes to *append* to ChangeLog entries
> (in case you left out important information), we've covered all bases
> as far as I'm concerned.
>
> If something is REALLY critical that needs to be fixed you can always use a
> hack like adding a line of whitespace or something and re-committing (which
> will work with any scm), but I'd only reserve that for when a changelog
> entry is so factually wrong that it risks a real problem.
>
> However, I'd really question whether ChangeLogs are the place to store such
> a critical piece of documentation in the first place. If it is THAT
> important that users know about a change it should be in news.
>
> I agree that it seems like we're at the point where "just a little better"
> is becoming the enemy of "already way better than what we have."
I would prefer going this route myself. Generate all ChangeLogs from
commit messages only. This is easy to implement (POC is running for
Prefix), but has a little issue with ChangeLog being in Manifest file.
I think we should just omit it, or (better) allow the Manifest to have
multiple signed parts, such that the ebuilds, dists and files are signed
by the committing developer, and the ChangeLog is signed by the
generation process (like snapshots are).
The council has, however, (like Markos' initial mail explained) decided
that ChangeLog entries must be updatable (e.g. corrected) afterwards.
That makes a (ChangeLog) file IMO necessary, and hence nothing can be
done different from making repoman update the ChangeLog itself upon
commit one way or another. This isn't really new, it's bug #337853.
Note that the latter approach also solves any problems of entry order,
as are forseen when using a VCS like git.
[1] https://bugs.gentoo.org/show_bug.cgi?id=337853
--
Fabian Groffen
Gentoo on a different level
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2011-09-19 13:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 14:08 [gentoo-project] ChangeLog generation: Edit generated Changelogs Markos Chandras
2011-09-16 21:32 ` "Paweł Hajdan, Jr."
2011-09-17 8:32 ` Markos Chandras
2011-09-17 9:07 ` Nirbheek Chauhan
2011-09-17 14:01 ` Rich Freeman
2011-09-19 13:26 ` Fabian Groffen [this message]
2011-09-19 13:44 ` Markos Chandras
2011-09-19 14:27 ` Fabian Groffen
2011-09-19 16:28 ` Markos Chandras
2011-09-19 16:51 ` Fabian Groffen
2011-09-19 16:58 ` Markos Chandras
2011-09-19 17:09 ` Fabian Groffen
2011-09-19 17:21 ` Markos Chandras
2011-09-19 17:53 ` Fabian Groffen
2011-09-19 21:39 ` Donnie Berkholz
2011-09-19 21:46 ` Michał Górny
2011-09-20 6:57 ` Fabian Groffen
2011-09-28 17:37 ` Fabian Groffen
2011-09-28 18:24 ` Mr. Aaron W. Swenson
2011-09-29 17:04 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919132655.GA1168@gentoo.org \
--to=grobian@gentoo.org \
--cc=gentoo-project@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox