Re: [gentoo-portage-dev] [PATCH 1/4] Manifest2 hash: Whirlpool

["Robin H. Johnson" <robbat2@gentoo.org>]

On Sat, Oct 01, 2011 at 02:08:57PM -0400, Mike Frysinger wrote:
> On Thursday, September 29, 2011 21:27:39 Robin H. Johnson wrote:
> > Provide public-domain implementation of the Whirlpool hash algorithm to
> > be used as new Manifest2 hash.
> > 
> > Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
> > ---
> >  pym/portage/checksum.py       |    4 +
> >  pym/portage/util/whirlpool.py |  788
> > +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 792
> > insertions(+), 0 deletions(-)
> >  create mode 100644 pym/portage/util/whirlpool.py
> 
> shouldn't we add pycryptoplus to the tree and depend on that rather than 
> copying & pasting their code into portage ?
It looks like they got it from the same source [1] that I did, and
pycryptoplus was written after I wrote the earliest version of this
patch. The source I got it from does NOT package it up in any way.

1. http://www.bjrn.se/code/whirlpoolpy.txt

-- 
Robin Hugh Johnson
Gentoo Linux: Developer, Trustee & Infrastructure Lead
E-Mail     : robbat2@gentoo.org
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85