From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 0F09F138CA2 for ; Tue, 21 Apr 2015 09:48:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 76A45E089F; Tue, 21 Apr 2015 09:48:35 +0000 (UTC) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D7F8EE082D for ; Tue, 21 Apr 2015 09:48:34 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YkUn8-0003wB-Fz for gentoo-portage-dev@lists.gentoo.org; Tue, 21 Apr 2015 11:48:30 +0200 Received: from ip68-231-22-224.ph.ph.cox.net ([68.231.22.224]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Apr 2015 11:48:30 +0200 Received: from 1i5t5.duncan by ip68-231-22-224.ph.ph.cox.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Apr 2015 11:48:30 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-portage-dev@lists.gentoo.org From: Duncan <1i5t5.duncan@cox.net> Subject: [gentoo-portage-dev] Re: [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK Date: Tue, 21 Apr 2015 09:48:25 +0000 (UTC) Message-ID: References: <1429559160-11646-1-git-send-email-bertrand@jacquin.bzh> <55358E1D.1070801@gentoo.org> <55359BBB.4080605@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: ip68-231-22-224.ph.ph.cox.net User-Agent: Pan/0.140 (Chocolate Salty Balls; GIT 048fecd) X-Archives-Salt: d516f9d8-b60d-4900-ab60-df47227375bf X-Archives-Hash: 36c43db6dd64e4b88bc4efa42d1e52fa Zac Medico posted on Mon, 20 Apr 2015 17:37:15 -0700 as excerpted: > On 04/20/2015 05:31 PM, Bertrand Jacquin wrote: >> On 21/04/2015 00:39, Zac Medico wrote: >>> These are in the master branch now: >>> >>> https://gitweb.gentoo.org/proj/portage.git/commit/? id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911 >>> >>> https://gitweb.gentoo.org/proj/portage.git/commit/? id=e74e2670e3f043608fced9847e54bdbb19f35169 >>> >> >> Thanks for that :) >> >>> I modified the test as follows in order to ensure that it still works >>> with shell globs: >>> >>> if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo >>> "${root}"/${no_inst}) ]] ; then >> >> I do not really understand the use case here, do you have an example ? >> >> Cheers, >> > > Well, I don't use INSTALL_MASK myself, so I don't have a real-world > use-case for you. However, it's clear that the code will expand shell > globs, so I preserved that behavior for compatibility. I do, with shell globs, tho I didn't bother checking the above to see if they'd have been affected. The two install-masks with globs I use here are: *.la (Unmasked on libtool itself, since it has a *.la file that other package's .configure scripts test for.) /etc/cron.*/ (I use systemd's timers in place of cron and thus crontablets.) -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman