From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id CACCF138247 for ; Wed, 15 Jan 2014 22:24:29 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9B8EEE0B40; Wed, 15 Jan 2014 22:24:27 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id F23FEE0B3E for ; Wed, 15 Jan 2014 22:24:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 33C6A33F5E5 for ; Wed, 15 Jan 2014 22:24:26 +0000 (UTC) X-Virus-Scanned: by amavisd-new using ClamAV at gentoo.org X-Spam-Flag: NO X-Spam-Score: -1.266 X-Spam-Level: X-Spam-Status: No, score=-1.266 tagged_above=-999 required=5.5 tests=[AWL=-1.141, RCVD_IN_DNSWL_NONE=-0.0001, RP_MATCHES_RCVD=-0.123, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=no Received: from smtp.gentoo.org ([IPv6:::ffff:127.0.0.1]) by localhost (smtp.gentoo.org [IPv6:::ffff:127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qeMFKKbq33ny for ; Wed, 15 Jan 2014 22:24:20 +0000 (UTC) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 65B3533F76A for ; Wed, 15 Jan 2014 22:24:18 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1W3Ysi-0004Kz-L8 for gentoo-portage-dev@gentoo.org; Wed, 15 Jan 2014 23:24:16 +0100 Received: from ip68-231-22-224.ph.ph.cox.net ([68.231.22.224]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Jan 2014 23:24:16 +0100 Received: from 1i5t5.duncan by ip68-231-22-224.ph.ph.cox.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Jan 2014 23:24:16 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-portage-dev@lists.gentoo.org From: Duncan <1i5t5.duncan@cox.net> Subject: [gentoo-portage-dev] Re: [PATCH v4] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 and if pkg_pretend is used in EAPI < 4. Fixes bug 379491. Date: Wed, 15 Jan 2014 22:23:54 +0000 (UTC) Message-ID: References: <1389821748-18454-1-git-send-email-creffett@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: ip68-231-22-224.ph.ph.cox.net User-Agent: Pan/0.140 (Chocolate Salty Balls; GIT 6daf184 /usr/src/portage/src/egit-src/pan2) X-Archives-Salt: 4c58ea4c-ccde-45bd-a4da-9063ca0b18d4 X-Archives-Hash: 1348174b0a2f06ac615b27a7068f95f1 Chris Reffett posted on Wed, 15 Jan 2014 16:35:48 -0500 as excerpted: [snip the actual patch... and that's all the content there was] TL;DR summary: please include commit descriptions and append one-line vN changelogs as the vN increases. I'm not sure whether there's an accepted practice for portage or not, but on the various upstream mailing lists (mostly btrfs, AFAIK using the general lkml/kernel policy) I follow, accepted practice is to: 1) Always include a commit description. 2) For [PATCH vN] commits/posts, append to that description a short (generally but not always one-line) version changelog: [Original commit description, generally unchanged unless a vN significantly changed something at the comment level.] v2: Xxxx pointed out that I missed ... v3: Oops, v2 was incomplete, ignore it v4: Sebastian suggested I use eap_has_function instead of hardcoding EAPI This makes is *FAR* easier for people to track a patch as it evolves, particularly if they've investigated an earlier version and now only care about what has changed since then, or if (like me) they don't really code, but are still interested in following the patch as it evolves, particularly if they've applied and are testing it! Yes, people can go back and find the other version and do a diff, but the vN oneline changelog format is /so/ much easier, and people can still do a diff if they're actually interested once they read the one-line. =:^) -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman