public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Duncan <1i5t5.duncan@cox.net>
To: gentoo-portage-dev@lists.gentoo.org
Subject: [gentoo-portage-dev] Re: [PATCH v4] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 and if pkg_pretend is used in EAPI < 4. Fixes bug 379491.
Date: Wed, 15 Jan 2014 22:23:54 +0000 (UTC)	[thread overview]
Message-ID: <pan$5a36f$6b9a5367$1b3024da$2f1bd367@cox.net> (raw)
In-Reply-To: 1389821748-18454-1-git-send-email-creffett@gentoo.org

Chris Reffett posted on Wed, 15 Jan 2014 16:35:48 -0500 as excerpted:

[snip the actual patch... and that's all the content there was]

TL;DR summary: please include commit descriptions and append one-line vN 
changelogs as the vN increases.

I'm not sure whether there's an accepted practice for portage or not, but 
on the various upstream mailing lists (mostly btrfs, AFAIK using the 
general lkml/kernel policy) I follow, accepted practice is to:

1) Always include a commit description.

2) For [PATCH vN] commits/posts, append to that description a short 
(generally but not always one-line) version changelog:

[Original commit description, generally unchanged unless a vN 
significantly changed something at the comment level.]

v2: Xxxx pointed out that I missed ...
v3: Oops, v2 was incomplete, ignore it
v4: Sebastian suggested I use eap_has_function instead of hardcoding EAPI

This makes is *FAR* easier for people to track a patch as it evolves, 
particularly if they've investigated an earlier version and now only care 
about what has changed since then, or if (like me) they don't really 
code, but are still interested in following the patch as it evolves, 
particularly if they've applied and are testing it!

Yes, people can go back and find the other version and do a diff, but the 
vN oneline changelog format is /so/ much easier, and people can still do 
a diff if they're actually interested once they read the one-line. =:^)

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman



  reply	other threads:[~2014-01-15 22:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 21:35 [gentoo-portage-dev] [PATCH v4] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 and if pkg_pretend is used in EAPI < 4. Fixes bug 379491 Chris Reffett
2014-01-15 22:23 ` Duncan [this message]
2014-01-15 22:54 ` Tom Wijsman
2014-01-19  9:22 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='pan$5a36f$6b9a5367$1b3024da$2f1bd367@cox.net' \
    --to=1i5t5.duncan@cox.net \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox