From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 55C7313877A for ; Wed, 13 Aug 2014 18:00:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DE5C3E0AD6; Wed, 13 Aug 2014 18:00:06 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 61A62E08DC for ; Wed, 13 Aug 2014 18:00:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id ACB3B3405E3 for ; Wed, 13 Aug 2014 18:00:05 +0000 (UTC) X-Virus-Scanned: by amavisd-new using ClamAV at gentoo.org X-Spam-Flag: NO X-Spam-Score: -1.832 X-Spam-Level: X-Spam-Status: No, score=-1.832 tagged_above=-999 required=5.5 tests=[AWL=-0.462, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.668, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=unavailable Received: from smtp.gentoo.org ([IPv6:::ffff:127.0.0.1]) by localhost (smtp.gentoo.org [IPv6:::ffff:127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pz1V5pbJEfDH for ; Wed, 13 Aug 2014 17:59:59 +0000 (UTC) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 68C7A340507 for ; Wed, 13 Aug 2014 17:59:54 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XHcpv-00063z-4U for gentoo-portage-dev@gentoo.org; Wed, 13 Aug 2014 19:59:47 +0200 Received: from ip68-231-22-224.ph.ph.cox.net ([68.231.22.224]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Aug 2014 19:59:47 +0200 Received: from 1i5t5.duncan by ip68-231-22-224.ph.ph.cox.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Aug 2014 19:59:47 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-portage-dev@lists.gentoo.org From: Duncan <1i5t5.duncan@cox.net> Subject: [gentoo-portage-dev] Re: [PATCH 0/4] Autounmask changes Date: Wed, 13 Aug 2014 17:59:34 +0000 (UTC) Message-ID: References: <1407836235-13528-1-git-send-email-bernalex@gentoo.org> <53EB8D23.20208@gentoo.org> <20140813094532.6ba40f8f.dolsen@gentoo.org> <53EB98BC.4050404@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: ip68-231-22-224.ph.ph.cox.net User-Agent: Pan/0.140 (Chocolate Salty Balls; GIT d447f7c /m/p/portage/src/egit-src/pan2) X-Archives-Salt: 3d212ae8-8609-493c-a4f5-1d35311eeaa6 X-Archives-Hash: cd7cea7306814c5e591409178de13d44 Alexander Berntsen posted on Wed, 13 Aug 2014 18:56:28 +0200 as excerpted: > One thing that needs discussion is what to do with the current behaviour > of --autounmask, i.e. printing the suggestions. One thing that was > really weird in my original patches (the ones in this thread) > is this: > > emerge foo # this will do what --autounmask does today > emerge foo --autounmask # this will do what --autounmask-write does > emerge foo -a # this will do what --ask --autounmask-write does > emerge foo --autounmask=n # this will do what --autounmask=n does > > The problem here is that there is no way to do e.g. emerge foo --ask, > and get suggestions any longer. You can either have it prompt to write > stuff, or you can have it not do anything -- but you can't explicitly > have it suggest stuff without prompting to write. This is bad design. > > So either I need to implement tri-state (--autounmask can be yes, no, > suggest), or I need to do something more drastic. This remains my problem with the patches as they are now. * I don't want portage writing mask/use changes on its own under any circumstances, as I use directories and have my own idea of what files I want stuff in. * Never-the-less, I find the suggestions very helpful and indeed, often the easiest way to find out what I need to do. * I routinely use --ask. Currently, --ask assumes "yes" very easily, simply hit return, and I like that behavior for simple merges as it's convenient and easily enough undone. (With --oneshot by default as well, an errant enter is undone easily enough with a --depclean.) The patches as they are now would change that, giving me no way to still get the suggestions with --ask, without chancing the actual write of those changes. That's particularly bad as the currently convenient behavior of letting a simple enter indicate yes makes it all too easy to actually do those writes I don't want done under any circumstances. While I'm fine with --ask defaulting to (the current) --autounmask-write behavior by default, I need a way to get the current --ask --autounmask (without write) behavior too, even if I need to add --autounmask=suggest or some such to DEFAULTOPTS, because that's /my/ configuration's default behavior, and I want it to stay that way. =:^) So please do implement that tri-state --autounmask=suggest behavior. =:^) The only other /possible/ objection I see is the potential version- dependent confusion over --autounmask behavior. An argument could be made that it might be better to simply kill the --autounmask switch, hard- wiring that behavior, and keep the current --autounmask-write name, simply making it the default while still allowing people to explicitly set --autounmask-write=n. That way, while the remaining --autounmask-write parameter would arguably unnecessarily keep it's longer name, there could be no confusion over the changing --autounmask behavior, since that parameter would simply cease to exist. But I don't feel strongly about that. If people think the confusion over --autounmask changing meaning isn't as big a deal as saving those few extra characters necessary for the longer -write variant, fine with me. -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman